Inconsistent loading of third party hook implementations

I was seeing similar results as #9

I originally thought it was token - however further investigation revealed the module_implements_alter cache was an empty array.

I have added my findings to https://www.drupal.org/project/drupal/issues/3354753 🐛 [11.x] Middleware that calls ModuleHandler->alter() can remove hooks from module_implements cache Closed: duplicate which may be helpful debugging information if others run into the same issue.

Created a new MR based on the feedback of Berdir in #12 .

A sidenote: the function _token_core_supported_modules is no longer used but I kept it in because it was inside a comment in the install file.

We've been experiencing these intermittent issues with URL generation and after debugging the "tokens" hooks being called I realised the field_tokens hook wasn't registered in order to be able to replace some URL pattern tokens.

I then came upon this issue and the patch in MR #42 in comment #17 fixed it instantly.

I've had a similar problem mentioned in #19 and MR 42 solved the problem for me.

Merged, thank you.

Berdir → closed merge request !10

Automatically closed - issue fixed for 2 weeks with no activity.

A side effect of this change is that token's hooks are no longer executed first, above other contrib modules. I had a custom module that was relying on token's hooks being invoked first. I solved this by adding my own module_implements_alter to ensure my hook executes last. Maybe not a big deal, I suspect what I was doing was pretty special, just noting it here in case others run into the same.

They weren't really _first_ just earlier. Hooks by default are called alphabetically if they have the same weight (and then the module implements hook can do whatever, but that too is called by weight, name).

But yeah, this is indeed causing some regressions, see 🐛 Updating to Token 1.13 breaks smart_date range tokens Needs review .