Ready to review. Please review and consider if is this may be nice to have, thanks!
It works at Drupal 10.
I need to apply into the Drupal 11 compatibility issue merge request 📌 Automated Drupal 11 compatibility fixes for image_compression Needs review as the hook_file_validate is deprecated →
omarlopesino → made their first commit to this issue’s fork.
omarlopesino → created an issue. See original summary → .
Many thanks everyone! The MR is merged and the functionality is ready at 1.3.0
As far as I know this has been tested by Alex yesterday and it was fine, so maybe we can merge and release another beta.
I have checked it in my project and the data is correctly stored and used by the chatbot. So it works fine.
Disabling refocus works fine and is more comfortable. Working on the two column design.
omarlopesino → made their first commit to this issue’s fork.
I have tested the MR based on #5 in a project with search api solr dense vector and an AI chatbot that uses RAG/Vector search and it works fine. Thanks!
Moving to Needs review.
omarlopesino → created an issue. See original summary → .
That looks good and easy to configure. I can check this approach in my site, and even creating an MR from #5 so it can be reviewed.
omarlopesino → created an issue. See original summary → .
I have reviewed the MR changes and they look good for me. Merging and releasing at beta2.
Moving to needs review as it is complete and tested internally. Please review, thanks!
Released at beta10
This is already finished. Merging it and releasing at beta10.
I will review this tomorrow and very probably merge it and release.
Assigning it to myself, I plan to:
- Add always title and URL.
- If metatag manager service is present, get metatags from entity and add it as meta-???
Merged into 2.x , ready for the next release.
Created MR. A Review will be appreciated. I will merge it on Monday though, as it is stable.
omarlopesino → created an issue.
Released at beta9
It works perfect, thanks also for correcting most of styling errors reported by drupalci!
I've done some slight adjustments and I am merging it.
Thanks!
I've checked it and it works fine: for HTML it downloads a txt and for md it downloads a .md file. Plus, it solves a problem that was making the .txt extension added twice. Merged into 1.x, it will be released asap, thanks!
If it is easy, we could add a selector in the action plugin configuration form to choose between HTML or Markdown. My only concern is I don't remember if that configuration is global for all the selected elements, or is specific for each one. If it is global, go for it. Otherwise, only markdown.
Oh it was on my plans doing this but I haven't started yet, so contributions are welcome :)
If you are going to work on it, I expect that this feature works technically as follows:
- Do a Drupal Action Plugin to save the markdown generated by content_first.builder service into a temporary file.
- Allow this action to be enabled at /admin/content, so any content needing downloading can be selected.
- After doing the bulk operations, save all the files into a ZIP.
- Either display a Drupal message linking the generated file, or auto download it in the next page load.
This would be a "Drupal way" solution that would meet the requirement, otherwise it can become tricky I think.
beta8
The plan is developing it the next week and releasing it at beta7.
omarlopesino → created an issue.
Merged. I will create beta6 release with this.
For the moment , the solution will only provide the content first as markdown. That is because HTML output is sanitized in tokens and markdown should be enough.
omarlopesino → created an issue.
Merged! It will be released at beta 6
I have finished the refactor. I have checked it with a site using content first and the generated content appears equal, without regressions. I have checked: HTML, markdown, copy and download. This is ready to review.
omarlopesino → created an issue.
I've fixed the composer.json too. Waiting for tests to move to RTBC.
omarlopesino → made their first commit to this issue’s fork.
I've checked the code and I fixed it. Can you upgrade to 1.0.0-alpha5 and let me know if you have the same issue? Thanks!
Glad that you have fixed it! I think that the problem is that the module is still not stable. I'll try to release a stable version as soon as I can prioritize it.
Integrating with UI styles currently is not in our scope, but it could be good to considerate as UI styles integrates at entity bundle level and it is more abstracted from CSS variables.
Having said this, the MR has been reviewed so it has been merged.
This is ready to review
Coding style --> fixed
Use custom textarea to allow creating new variables -> Done
Consider validate if new variables are not the same than overriden variables -> I have added a validation to check new css variables have correct format, plus they do not conflict with the variables of the current selector.
Working on a first version that allow replacing global variables. They appear inside a fieldset, and for each one there is a textfield.
Preview:
Pending:
- Coding style
- Use custom textarea to allow creating new variables.
- Consider validate if new variables are not the same than overriden variables.
omarlopesino → created an issue.
Re-rolled to 6.3.x
I've just re-rolled it to solve conflicts with 7.0.5
Postponed until:
- ✨ Add support for path-based invalidation Active is merged.
- Drupal 12 release date gets closer. I think this changes are proper to be added along with the hooks classes refactor.
I have changed it according to the latest changes (supporting of queue invalidation) that were conflicting with this issue.
I see the changes okay but I cannot test it as I don't have configured a site with path based cache. May somebody test it? Thanks!
Working to fix merge conflicts
Merged and released at 1.2.0. Thanks all for the help and feedback!
The MR !10 looks fine.
About the feedback from #7, this module has born as a solution to inmediate purge files, as a project was needing to instantly refresh its financial reports / legal documents after replacing those files having the same. Purge allows it but do not recommend it https://git.drupalcode.org/project/purge#api-examples . In the practice , inmediate purge is working fine.
It is true that not every site needs an inmediate purge, and there are sites where inmediate purging every update file on a page may lead to performance issues. That's why this contribution is very valuable for the project, letting developers to choose the best option for their sites.
After reviewing it, it works fine. The hook update provides the backwards compatibility and it additionally fixes some problems on the hook_requirements. I've merged it and I will create a release right now.
I move it to needs work because I've noted that this solution would fail in sites that do not use layout builder.
I have created a MR solving the problem. Please review, thanks!
omarlopesino → created an issue.
The attached MR adds the API key field to the form and uses it at every api call whenever is available. Please review, thanks!
omarlopesino → created an issue.
Works fine!
Working on it, see the attached MR. I will go back on this tomorrow to review if it is possible to add a different form element type for each property type.
omarlopesino → created an issue.
I have created an MR with the fix. Please review, thanks!
omarlopesino → created an issue.
I've added changes so that the build:watch command works properly. Now it is needed an additional plugin.
I've made a merge request that:
- Compiles any asset from a component's src folder into the component. For example: web/components/chart-element/src/chart-element.ts -> web/components/chart-element/chart-element.js
- Only replaces assets at library info alter when the dev mode is enabled.
Please review, thanks!
omarlopesino → created an issue.
We can fix it alternatively using Paragraphs legacy widget instead of paragraphs stable.
Thanks for the work on the module and the fast response time! I tried this module in a theme and it works great to view all sdcs and show their variants.
MR ready. With this change, the demo exported works great. May you review it? Thanks!
omarlopesino → created an issue.
Thanks for the feedback!
After testing the compatibility change at a Drupal 11 site, the Drush command needs to be adapted. Otherwise, when you set options that requires value, it throws an error like this:
The "--preserve-languages" option requires a value.
After doing this changes the module works as usual in D11. Those changes should be compatible with earlier Drupal releases, but if someone could test it in a previous version it would be appreciated.
omarlopesino → created an issue.
omarlopesino → made their first commit to this issue’s fork.
The change is working and tests are passing. May somebody review the latest change, so we can move it back to RTBC? Thanks!