Allow null results in graphql entity results

Created on 3 April 2025, 5 days ago

Problem/Motivation

After creating a view that uses contextual filters, which shows no results when certain conditions aren't meet, I get this error:

For error #0: TypeError: Drupal\Core\Cache\CacheableMetadata::createFromRenderArray(): Argument #1 ($build) must be of type array, null given, called in /var/www/html/web/modules/contrib/graphql_compose/modules/graphql_compose_views/src/Plugin/GraphQL/DataProducer/ViewsEntityResults.php on line 47

It looks like it does not usually happen. I far as I have debugged, it happened in a view with contextual filters that have empty default arguments.

Steps to reproduce

- Use Graphql compose latest version
- Enable graphql views.
- Create a view with a Graphql display
- Add a contextual filter , setting that if no contextual filters are available, provide a default value that may return an empty value.

When the contextual filter returns an empty value, the error appears.

Proposed resolution

The problem comes from this line.

The method CacheableMetadata::createFromRenderArray expects an array, but $view->render may return null.

So the solution would be, when results come null in GraphqlEntityResults DataProducer, pass an empty array to CacheableMetadata::createFromRenderArray

🐛 Bug report

Status

Active

Version

2.4

Component

Code

Created by

🇪🇸Spain omarlopesino

Live updates comments and jobs are added and updated live.

Merge Requests

!121Allow null results in graphql entity results
Merged
🇪🇸Spain omarlopesino
updated about 4 hours ago

Comments & Activities

Issue created by @omarlopesino
Merge request !121Issue #3517174: Allow null results in graphql entity results → (Merged) created by omarlopesino
Pipeline finished with Success
5 days ago
Total: 245s
#464556
Comment 5 days ago →
🇦🇺Australia almunnings Melbourne, 🇦🇺
Works for me. Is it ?? Or ?: here?
Comment about 14 hours ago →
🇪🇸Spain omarlopesino
?? only works when the returned value is null and ?: accepts any value considered empty (FALSE / 0...). For this case both should be good, but ?: would cover more unexpected returns. Let me know if you want me to do the change.
Comment about 4 hours ago →
🇦🇺Australia almunnings Melbourne, 🇦🇺
Nah you’re right. I just have negative reinforcement to always assume I make the wrong decision with these. lol.
Comment about 4 hours ago →
System Message

almunnings → committed 3fa489de on 2.4.x authored by omarlopesino →
Issue #3517174: Allow null results in graphql entity results

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024