šŸ‡¦šŸ‡ŗAustralia @almunnings

Melbourne, šŸ‡¦šŸ‡ŗ
Account created on 15 August 2012, almost 13 years ago
#

Merge Requests

More

Recent comments

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

Was seeing some issues with the Gin admin theme. Worked on in Claro.

When the entity references render as a table, gin wraps the table in 2 div elements. Removing those divs, it all worked again.
Unsure if this is immediately related, but combining this patch plus:

/**
 * Implements hook_theme_suggestions_HOOK_alter().
 */
function MYMODULE_theme_suggestions_table_alter(array &$suggestions, array $variables): void {
  if (!empty($variables['attributes']['data-entity-browser-entities-list'])) {
    $suggestions[] = 'table__simple';
  }
}

Has restored functionality in the Gin admin theme.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

There is a failing PR up if you wish to continue yourself.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

Hi there,
I tried to get this to return a result on my end, and it always came back null.

Am I missing something?
getEntity isn't on the MenuLinkInterface
Are you trying to get `MenuLinkContent` entity view_mode?
Does this require 3rd party modules?

I'm not aware of that being populated by default in how we access the data.

I'm also shifting my thinking to the opinion that frontend logic to choose what to display to a user, should happen on the imlenmentation, not the data. We have no rendering context in the menu, so it's unknown what view mode it would even display?

Maybe I got this wrong.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

Closing, no further information was provided.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

Closing, no further information was provided.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

Opting to update documentation on this one.

Pending 3.x.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

Merged in 3.x

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

I’ll probably move it into the core module, as it doesn’t introduce new entities or graphql module plugins, and is just a field type/resolver.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

Will get this into 3.x with tests

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

almunnings → created an issue.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

almunnings → created an issue.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

Merged into 3.x-dev

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

almunnings → created an issue.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

almunnings → created an issue.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

Merging into dev to test with patch against latest works

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

Merging into 3.0

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

Merging into 3.0

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

Attaching patch file for point-in-time.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

#46 works as expected.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

Duplicate

https://www.drupal.org/project/graphql_compose/issues/3515405 šŸ“Œ Add GraphQL 5.x support Active

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

This will need to move to a 3.x.x release

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

Nah thats good enough for now, happy for this to re-open if someone finds a way.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

Per your testing requirements

query MyQuery {
  node(id: "f099a6cd-f63b-4f9b-ba26-238cf2271fdc") {
    ... on NodePage {
      tags {
        __typename
        ... on TermTags {
          id
          name
          langcode {
            id
          }
        }
      }
    }
  }
}

Response

{
  "data": {
    "node": {
      "tags": [
        {
          "__typename": "TermTags",
          "id": "1",
          "name": "AAAA",
          "langcode": {
            "id": "en"
          }
        },
        {
          "__typename": "TermTags",
          "id": "2",
          "name": "BBBB",
          "langcode": {
            "id": "en"
          }
        },
        {
          "__typename": "TermTags",
          "id": "3",
          "name": "CCCC",
          "langcode": {
            "id": "bn"
          }
        }
      ]
    }
  }
}
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

Bigger commit here.
Might need to lean on our buddies Wunder and jmolivas to test.

Anywhere we were loading translations i've shifted it off to a trait that has a hook.

If you have custom logic beyond whatever I'm doing here, probably the hook is a good way about it?

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

Citing need for new issue for your issue @marcus.w.
Not that I don't believe you, I just need a way to reproduce it.

It's a similar error, but could be indicative of any breakdown in the creation of the schema.

Please try the MR over at šŸ› GraphQL query stops working - seems cache issue Needs work , and please open a new ticket if you are able to find a set of events that can trigger your issue.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

Dang it. Didn’t see that pid field sneak in. That’ll need to be changed to an entity reference id too.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

Moving this one fwd a bit.

Added schema field type entity_reference_target_id in ✨ Support Comments Active , which this could utilise.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

almunnings → made their first commit to this issue’s fork.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

I'm unable to reproduce this error.

query MyQuery {
  node(id: "777f15be-c72f-4578-a9cb-c297559c9e89") {
    ... on NodePage {
      paras {
        __typename
        ... on ParagraphLinks {
          links {
            title
            url
          }
        }
      }
    }
  }
}
{
  "data": {
    "node": {
      "paras": [
        {
          "__typename": "ParagraphText"
        },
        {
          "__typename": "ParagraphLinks",
          "links": [
            {
              "title": "Para text",
              "url": "https://www.para.com"
            },
            {
              "title": "sdadsasd",
              "url": "https://www.pasra.com"
            }
          ]
        }
      ]
    }
  }
}

Are you able to re-check and revise on how to reproduce?

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

Yep cool
As its identical at this stage, might as well just extend TelephoneItem

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

almunnings → made their first commit to this issue’s fork.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

Attaching static patch of diff.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

almunnings → created an issue.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

Back at you to take a look.
This should add the remaining fields and switch out between uuid and id on the entityId field.

Caveat may be that accessing the entity->uuid() will load that entity - which could be addressed in šŸ’¬ How to return a simple object on dynamic_entity_reference values Active

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

Ok, if unrelated to this issue, please open a new issue if you can reproduce your cache issue.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

almunnings → made their first commit to this issue’s fork.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

Released in 1.1.0

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

So is dev working for you? I’ll push a release if so.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

Compose nukes all GraphQL caches on save. That could be what you’re seeing.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

I’m happy to merge.

2048 is the max for a url. It’s easy enough to revert one day if it proves to be cataclysmic.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

I'm just going to push this into dev, have a play around. if cool, we can let this one be done.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

Can this be back ported to 4.x? - GraphQL Compose is on the AlterableComposableSchema and I'd prefer to jump into line without dropping support for 4.x immediately.

šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ
šŸ‡¦šŸ‡ŗAustralia almunnings Melbourne, šŸ‡¦šŸ‡ŗ

šŸ“Œ Merge AlterableComposableSchema into ComposableSchema Active Means changes required.

Production build 0.71.5 2024