- Issue created by @eduardo morales alberti
- Status changed to Closed: won't fix
about 1 year ago 12:44pm 1 April 2024 - 🇪🇸Spain omarlopesino
Thanks for the contribution! However, that looks a custom solution for a very specific problem. There are better ways to check logs do not appear. For example, doing a manual test reproducing the error and check the error does not happen again. Plus, if the problem is solved, the logs will eventually disappear from db log as db log messages are periodically cleared.
Apologies for not accepting the feature request. I'm open to changing my mind in the case that is strictly necessary in the project.
- 🇪🇸Spain eduardo morales alberti Spain, 🇪🇺
@omarlopesino The module name is "watchdog_statistics", the admin user may need to know the statistics of the last month or the last week.
It is not the same 2000 entries of a log error in the last year than 2000 entries in the last week, with the filter of the date you can measure the log-entries/time.
The error can be tested manually, and you can check that the error is gone, now you can not measure which error appeared more in the last week.
In my opinion, it is an interesting feature and not a custom one.
- 🇪🇸Spain omarlopesino
That argument is completely different from what was said in the description.
However, that is your point of view and I do not share it, sorry. Also, I don't find it useful to argue more.The issue is still closed, sorry.
And please, do not talk to me like it is obvious a feature is needed, it is really uncomfortable. Thanks!
- Status changed to Needs review
10 days ago 9:54am 10 April 2025 - 🇪🇸Spain omarlopesino
After talking with @Gedur, I have understood that filtering by date helps filtering out errors that may have been fixed in the past, and are not needed to be seen. You have tried to explain it to me but I didn't understand well.
Reopening and doing just some minimal adjustments:
- The 'relative dates' placeholder is removed, as the filter will be based on dates.
- The filter is now considering the greater or equal, and less or equal, instead greater and less.
- The labels have been renamed to 'Timestamp (from)' and 'Timestamp (to)'.
- The ids of the exposed filters have been renamed to timestamp_from and timestamp_to.
Thanks both for the contribution, changes will be consolidated and added into a new release.
- 🇪🇸Spain omarlopesino
I have included to the MR a hook update that will update the view , replacing the configuration with the module's one. The module's main feature is the view, so it is needed to automatically refresh the view once is updated in the module.
Please note @eduardo, that the site where you are using this view will be changed. I think it won't suppose a problem, but if it does, let me know and we can think a solution if needed.
-
omarlopesino →
committed ca1d3b85 on 1.0.x authored by
eduardo morales alberti →
Issue #3437358: Allow filter by dates
-
omarlopesino →
committed ca1d3b85 on 1.0.x authored by
eduardo morales alberti →
- 🇪🇸Spain omarlopesino
Released in 1.0.5. Thanks, and apologies again in case rejecting the issue have felt uncomfortable.
- 🇪🇸Spain eduardo morales alberti Spain, 🇪🇺
Thank you, @omarlopesino, for reconsidering the feature