- ๐ง๐ชBelgium Wim Leers Ghent ๐ง๐ช๐ช๐บ
Any takers? I promise reviews :)
- ๐ฎ๐ณIndia Keshav Patel
Keshav Patel โ made their first commit to this issueโs fork.
- Merge request !6986Issue #3083746 by oknate: Editor::getFilterFormat() should throw domain error... โ (Open) created by Keshav Patel
- ๐ฎ๐ณIndia Keshav Patel
Created the MR using the #26 patch and addressed comment #35 as well, but the pipeline failed. keeping it on "Needs work".., please review the changes.
Change as per #35:
/** * Returns the filter format this text editor is associated with. * * @return \Drupal\filter\FilterFormatInterface * * @throws \DomainException - * If called without an associated filter format. + * Thrown if the text editor is called without an associated filter format. */ public function getFilterFormat();
- ๐ง๐ชBelgium Wim Leers Ghent ๐ง๐ช๐ช๐บ
Those are all broken tests. Each of them is creating an
Editor
config entity without a correspondingFilterFormat
already existing. We should fix those tests. - ๐บ๐ธUnited States xjm
Updating the remaining tasks to point to @Wim Leers' feedback. Thanks!