#Needs change record

godotislate

1 small comment on the MR.

Also, @alexpott brought up in 🐛 Maxlength validation counts newlines twice Needs work #27 that normalizing "\r\n" to "\n" will cause values to be stored differently between form and JSON:API submissions when textareas are used in entity form widgets. Should core widgets set their textarea's #normalize_newlines property to FALSE?

in Drupal core » Add Textarea option to normalize newlines to \n

in Drupal core » HTML5 validation is preventing form submit and not fully accessible

needs-review-queue-bot

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

in Drupal core » HTML5 validation is preventing form submit and not fully accessible

🇫🇷France nod_ Lille

Please be careful to not publish the change record if the issue is not fixed.

in Drupal core » HTML5 validation is preventing form submit and not fully accessible

shubham_pareek_19

Added the change record please review!!

🇺🇸United States fathershawn New York

Based on #26 and the description of the tag (A change record needs to be drafted before an issue is committed.) I'm removing the CR tag from this issue as these are sequential dependencies and the tag belongs on final component.

in Drupal core » DX object to manage htmx attributes

🇺🇸United States fathershawn New York

Discussed and agreed in Slack that a single change record and release note will cover:

📌 DX object to manage htmx attributes Active
📌 DX object to manage htmx headers Active
📌 DX object to collect and manage HTMX behaviors Active
📌 Define and process an #htmx render array key Active

in Drupal core » Define and process an #htmx render array key

🇺🇸United States fathershawn New York

Discussed and agreed in Slack that a single change record and release note will cover:

📌 DX object to manage htmx attributes Active
📌 DX object to manage htmx headers Active
📌 DX object to collect and manage HTMX behaviors Active
📌 Define and process an #htmx render array key Active

in Drupal core » DX object to manage htmx attributes

First commit to issue fork.

in Drupal core » Exclude test files from release packages

Comment 4 days ago →

🇺🇸United States fathershawn New York

Tagged \Drupal\Core\Template\HtmlAttributeInterface as @internal as that seems consistent with the policy on Attribute class internals → .

in Drupal core » DX object to manage htmx attributes

🇨🇭Switzerland berdir Switzerland

Lets keep this for now.

We're close to add support for theme hook suggestions. That said, not sure this is worth the trouble. This is discouraged but there are going to be so, so many such templates out there

in Drupal core » Remove current path parts from theme suggestions

🇺🇸United States smustgrave

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

in Drupal core » Remove current path parts from theme suggestions

in Drupal core » "Promoted to front page" for new content types should default to Un-Checked

🇦🇺Australia acbramley

Great to finally get this in, thanks both.

in Drupal core » Admin toolbar and contextual links should always be rendered in the admin language (if set)

🇩🇪Germany sleitner

Rerolled

in Drupal core » ContentEntityStorageBase::loadRevision() should use the static and the persistent entity cache like ContentEntityStorageBase::load()

🇳🇱Netherlands seanB Netherlands

Thanks @tstoeckler! I haven't tried that, the site was still running D10.

in Drupal core » ContentEntityStorageBase::loadRevision() should use the static and the persistent entity cache like ContentEntityStorageBase::load()

🇩🇪Germany tstoeckler Essen, Germany

That's interesting. Do you have 📌 Add an in-memory LRU cache Needs work applied in your project as well? I didn't validate this, but from the looks of it, this should automatically resolve the problem, as well, since the patch here is just using the existing memory cache and since that went in that should have the LRU logic.

in Drupal core » ContentEntityStorageBase::loadRevision() should use the static and the persistent entity cache like ContentEntityStorageBase::load()

🇳🇱Netherlands seanB Netherlands

It might be good to mention I found 🐛 Allowed memory size exhausted when using revisions caching Active while using this patch. There could be contrib/custom code loading lots of revisions. When we suddenly start caching these, the cache could easily go over the memory limit.
I wonder if we could automatically release items from the cache when it starts to reach the memory limit? That might be a different issue though.

sonam_goswami55

Thanks for clarifying, your explanation makes sense. Updating the comment sounds good to me!

in Drupal core » Allow deprecating theme suggestions

in Drupal core » Admin toolbar and contextual links should always be rendered in the admin language (if set)

needs-review-queue-bot

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

in Drupal core » "Promoted to front page" for new content types should default to Un-Checked

🇺🇸United States xjm

Also a potential highlights thing, especially if we end up with other site builder UX tweaks.

in Drupal core » Admin toolbar and contextual links should always be rendered in the admin language (if set)

🇩🇪Germany sleitner

Rerolled and removed not matched ignoreErrors

in Drupal core » "Promoted to front page" for new content types should default to Un-Checked

🇬🇧United Kingdom longwave UK

Managed to crosspost with @xjm while we were both reviewing, committed her comment improvement as a followup.

in Drupal core » "Promoted to front page" for new content types should default to Un-Checked

System Message

longwave → committed e2180650 on 11.x

Issue #987238 followup by xjm: "Promoted to front page" for new content...

in Drupal core » "Promoted to front page" for new content types should default to Un-Checked

🇬🇧United Kingdom longwave UK

@acbramley thanks for the explanation, it did feel like the Umami change was too good to be true here, and it turns out that was correct; glad we did not break that - and technically it is tested here indirectly, because we spotted it via the performance tests!

So, after 14 years and 240 comments by many contributors, I am happy to finally be committing what is really a one line change:

--- a/core/modules/node/src/Entity/Node.php
+++ b/core/modules/node/src/Entity/Node.php
@@ -357,7 +357,7 @@ public static function baseFieldDefinitions(EntityTypeInterface $entity_type) {
       ->setLabel(t('Promoted to front page'))
       ->setRevisionable(TRUE)
       ->setTranslatable(TRUE)
-      ->setDefaultValue(TRUE)
+      ->setDefaultValue(FALSE)

One small step towards (possibly) removing this feature in the future!

Committed 6bfec5b and pushed to 11.x. Thanks!

Also finalised and published the change record.

in Drupal core » "Promoted to front page" for new content types should default to Un-Checked

System Message

longwave → closed merge request !11608

in Drupal core » "Promoted to front page" for new content types should default to Un-Checked

System Message

longwave → committed 6bfec5bc on 11.x

Issue #987238 by acbramley, jenlampton, ajalan065, idebr, nsuit, dcam,...

in Drupal core » "Promoted to front page" for new content types should default to Un-Checked

🇺🇸United States xjm

Saving reviewer credit for @longwave. Also looks like I had missed @smustgrave's changes and nontrivial rebase back in May so saving credit for that too.