- ๐ซ๐ทFrance mefianf
A small patch update for 10.3.x, as it seems they are not the same.
- ๐จ๐ฆCanada b_sharpe
@catch good call, I've moved it to just an extension of the maintenance page which will add the theme suggestion.
- ๐จ๐ฆCanada b_sharpe
b_sharpe โ changed the visibility of the branch 11.x to hidden.
- ๐จ๐ฆCanada b_sharpe
b_sharpe โ changed the visibility of the branch 3306107-create-a-failed to hidden.
- @b_sharpe opened merge request.
- ๐ฎ๐ณIndia amanmansuri72
I have made some necessary changes, Kindly review MR 8926.
Thanks
- @amanmansuri72 opened merge request.
- First commit to issue fork.
- ๐บ๐ธUnited States agentrickard Georgia (US)
The MigrationDeriverTrait only has one method.
Removing the Trait call and moving that method into FileMigrationDependencyManager.php fixes the issue, but I suspect this may affect all uses of the Trait.
It seems to be a race condition regarding how the plugin alter hook gets called.
- ๐บ๐ธUnited States agentrickard Georgia (US)
The latest patch introduces a hard dependency on migrate module inside file.module. That is not really acceptable, as it can cause errors in install from config.
Fatal error: During class fetch: Uncaught ReflectionException: Class "Drupal\migrate\Plugin\MigrationDeriverTrait" not found while loading "Drupal\file\FileMigrationDependencyManager". in /var/www/html/vendor/composer/ClassLoader.php:576 Stack trace: #0 [internal function]: Composer\Autoload\ClassLoader->loadClass('Drupal\\file\\Fil...') #1 /var/www/html/vendor/symfony/config/Resource/ClassExistenceResource.php(76): class_exists('Drupal\\file\\Fil...') #2 /var/www/html/vendor/symfony/dependency-injection/ContainerBuilder.php(361): Symfony\Component\Config\Resource\ClassExistenceResource->isFresh(0) #3 /var/www/html/vendor/symfony/dependency-injection/Compiler/RegisterAutoconfigureAttributesPass.php(32): Symfony\Component\DependencyInjection\ContainerBuilder->getReflectionClass('Drupal\\file\\Fil...', false) #4 /var/www/html/vendor/symfony/dependency-injection/Compiler/Compiler.php(80): Symfony\Component\DependencyInjection\Compiler\RegisterAutoconfigureAttributesPass->process(Object(Drupal\Core\DependencyInjection\ContainerBuilder)) #5 /var/www/html/vendor/symfony/dependency-injection/ContainerBuilder.php(767): Symfony\Component\DependencyInjection\Compiler\Compiler->compile(Object(Drupal\Core\DependencyInjection\ContainerBuilder)) #6 /var/www/html/web/core/lib/Drupal/Core/DrupalKernel.php(1447): Symfony\Component\DependencyInjection\ContainerBuilder->compile() #7 /var/www/html/web/core/lib/Drupal/Core/DrupalKernel.php(971): Drupal\Core\DrupalKernel->compileContainer() #8 /var/www/html/web/core/lib/Drupal/Core/DrupalKernel.php(515): Drupal\Core\DrupalKernel->initializeContainer() #9 /var/www/html/web/core/lib/Drupal/Core/DrupalKernel.php(739): Drupal\Core\DrupalKernel->boot() #10 /var/www/html/web/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request)) #11 {main} in /var/www/html/web/core/modules/file/src/FileMigrationDependencyManager.php on line 18
- ๐ณ๐ฑNetherlands Spokje
Tests are still green.
For the record, just removed the
resolutions
-section and did a$ yarn install
. - ๐ณ๐ฑNetherlands Spokje
I think we can now also drop the
resloutions
section fromcore/package.json
.
These were only needed to keep the dependencies of the old version ofnightwatch
clashing with our other JS-dependencies. - ๐ฌ๐งUnited Kingdom longwave UK
I'm slightly amazed that it was only another call to
execute()
that needed fixing, but the run is green. - ๐ฉ๐ฐDenmark ressa Copenhagen
Thanks for fixing the version @quietone. Sorry that I keep selecting the wrong version. I will try to get it right next time.
Adding possibly related issue.
- Issue created by @ressa
- ๐ฌ๐งUnited Kingdom longwave UK
Last run was looking promising until it appeared to hang after installProfileTest: https://git.drupalcode.org/project/drupal/-/jobs/2214554
- ๐ฌ๐งUnited Kingdom longwave UK
api.execute()
takes the callback as the third argument instead of the second now, it seems. - ๐ฌ๐งUnited Kingdom longwave UK
Locally I bumped to Nightwatch 3.7.0 which works OK with the new Selenium setup and latest Chrome, but tests appear to crash and then the Selenium server no longer responds:
$ yarn test:nightwatch tests/Drupal/Nightwatch/Tests/loginTest.js [Tests/Login Test] Test Suite โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ โน Connected to selenium on port 4444 (505ms). Using: chrome-headless-shell (126.0.6478.114) on LINUX. โน Loaded url http://ddev-drupal8-web in 446ms Running Test login: โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ โน Loaded url http://ddev-drupal8-web/user/reset/1/1721811628/FNZSmygKgxaar4E9AmDAlZ75Q61bU4ew0iwBaov3XUA/login in 440ms โน Loaded url http://ddev-drupal8-web/admin/people/roles/add in 133ms โ Expected element <.user-role-form .machine-name-value> to be visible in 2000ms (36ms) โ Testing if element <[data-drupal-messages]> contains text 'Role xt4aw4gms9 has been added.' (24ms) โน Loaded url http://ddev-drupal8-web/admin/people/permissions in 160ms โ Element <table.permissions> was visible after 34 milliseconds. โ Testing if element <[data-drupal-messages]> contains text 'The changes have been saved.' (22ms) โน Loaded url http://ddev-drupal8-web/user/logout/confirm in 69ms โน Loaded url http://ddev-drupal8-web/user/reset/1/1721811630/RH7RHeQ6JGfOHJ7RGMIXnuu3wYDMoU3KEqDnBTZrHfI/login in 83ms โน Loaded url http://ddev-drupal8-web/admin/people/create in 135ms โ User "user" was created successfully (34ms) โน Loaded url http://ddev-drupal8-web/user/logout/confirm in 47ms โน Loaded url http://ddev-drupal8-web/user/login in 54ms โ Passed [equal]: The user "user" was logged in. โน Loaded url http://ddev-drupal8-web/admin/reports in 76ms โ Element <body> was visible after 30 milliseconds. โ Testing if element <h1> contains text 'Reports' (32ms) $
I was expecting further output here, if I run this on the older version of Nightwatch it ends as follows:
โ Testing if element <h1> contains text 'Reports' (29ms) โ Ensuring no deprecation errors have been triggered (10ms) โจ PASSED. 9 assertions. (3.879s) Wrote HTML report file to: /var/www/html/drupal/core/reports/nightwatch/nightwatch-html-report/index.html $
If I then run the test again it hangs:
$ yarn test:nightwatch tests/Drupal/Nightwatch/Tests/loginTest.js [Tests/Login Test] Test Suite โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ โ ด Connecting to selenium on port 4444...
Restarting the Selenium container fixes it.
Will push this branch up anyway but not sure what's happened here at all.
- ๐ฌ๐งUnited Kingdom longwave UK
๐ Use selenium/standalone-chrome instead of our chromedriver image Needs work landed which gives us a newer Selenium/Chrome to talk to and which may solve the issues we were seeing here.
- ๐ณ๐ฟNew Zealand John Pitcairn
Note
hook_module_implements_alter()
will not work if you need yourhook_preprocess_HOOK()
to run after some other module's preprocess hook. Preprocess hooks are not invoked by the module handler and are not present inhook_module_implements_alter()
.So removing this API will be problematic if you have a soft dependency on another module's preprocess hook, ie the module is not a requirement, but if it is present you need to preprocess something it also preprocesses, after it has done so. You don't want to declare a hard dependency in module .info. Altering module weight is the only way this will work, right?
- ๐ฆ๐บAustralia jannakha Brisbane!
patch #466 applies to D10.3, but selected image styles are not visible in CKEditor 5 while adding/editing image:
Config works as expected:
Selected image styles are not available in CKEditor5:
- ๐ณ๐ฑNetherlands Summit
Hi,
Can I use this patch on Drupal 10.3.1? https://www.drupal.org/files/issues/2024-06-28/3163197-32.patch โThanks for building it! Greetings,
The Needs Review Queue Bot โ tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide โ to find step-by-step guides for working with issues.