- πΊπΈUnited States smustgrave
This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request β as a guide.
This will need a change record as the service may in use by others right?
Shouldn't this be deprecated first before replacing?
- π¬π§United Kingdom longwave UK
I could find no uses of the class or service in contrib, and as per the link in #8 event subscribers are not considered API - extending them usually doesn't make much sense, so I don't think we need to spend the effort deprecating this. We can however write a short change notice just in case, that is a simple task that keeps a record of what has happened here.
- Status changed to Needs review
over 1 year ago 10:43am 3 November 2023 - πΊπ¦Ukraine _shy Ukraine, Lutsk πΊπ¦
Added change notice, please, take a look.
- Status changed to RTBC
over 1 year ago 4:31pm 3 November 2023 - last update
over 1 year ago 28,526 pass - last update
over 1 year ago 28,526 pass 28:11 12:50 Running- last update
over 1 year ago 28,526 pass - Status changed to Needs work
over 1 year ago 12:00am 11 November 2023 The Needs Review Queue Bot β tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request β . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- @_shy opened merge request.
- Status changed to Needs review
over 1 year ago 11:14am 11 November 2023 - πΊπ¦Ukraine _shy Ukraine, Lutsk πΊπ¦
Created MR and all tests are green.
Also, changed the target branch. - Status changed to RTBC
over 1 year ago 6:06pm 11 November 2023 - Status changed to Needs work
over 1 year ago 2:17pm 12 November 2023 - πΊπΈUnited States xjm
A service machine name is public API; therefore, a CR alone is not sufficient for that change. We should deprecate the old service for removal in D11. We should also provide best-effort BC and deprecation for the class name, which is internal API. Thanks!
- Status changed to Postponed
over 1 year ago 2:56pm 12 November 2023 - πΊπΈUnited States xjm
My kneejerk about the core service definition machine names might be wrong here; discussing with the other release managers. Hold on changes for now.
- π³πΏNew Zealand quietone
Changing to the DX special tag defined on Issue tags -- special tags β .