Rename RedirectLeadingSlashesSubscriber

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

This will need a change record as the service may in use by others right?

Shouldn't this be deprecated first before replacing?

I could find no uses of the class or service in contrib, and as per the link in #8 event subscribers are not considered API - extending them usually doesn't make much sense, so I don't think we need to spend the effort deprecating this. We can however write a short change notice just in case, that is a simple task that keeps a record of what has happened here.

Added change notice, please, take a look.

Thanks!

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

Created MR and all tests are green.
Also, changed the target branch.

Reroll to MR seems fine.

A service machine name is public API; therefore, a CR alone is not sufficient for that change. We should deprecate the old service for removal in D11. We should also provide best-effort BC and deprecation for the class name, which is internal API. Thanks!

My kneejerk about the core service definition machine names might be wrong here; discussing with the other release managers. Hold on changes for now.