🇺🇦Ukraine @_shy

Seems like it's not possible to access some links from the mega menu. I tried to open a "Drupal CMS" link from the menu and instead of redirecting just another mega menu item was opened.

Here is an example:

Merged, thanks!

These changes will be added to the next release.

Looks great, thanks.

Merged to the 1.0.x-dev and will be added to the next release.

vieilours, thanks for your notice.

I created an MR with fixes for the given issue. Added a validation to prevent an error for the entities without the Edit form template.

Now, we need some testing for it.

_shy → made their first commit to this issue’s fork.

Changes added to the new release 1.0.1 →

Hi, it's a great idea. I reviewed and merged a PR. Will add these changes to the next release.
Thanks for your contribution.

These changes were released in the 1.1.4 version.

Feel free to use =)

Thank you, sirclickalot, for your time.

I've fixed some coding standards issues and merged these changes to the 1.x-dev branch.
I'll create a new release with these changes soon.

Thank you sirclickalot, for your testing.

It seems like some style issues, but I'm unsure where it comes from. You can add a class .open for the .dropbutton-wrapper .dropbutton-multiple element. It will help to keep the dropdown open all the time.

Also, it's important to check styles for the <ul> element. Because as you mentioned earlier the main problem is the position and the width of each item. Could you please check styles for the whole <ul> element and for the links inside the list?

Sorry, but that didn't help. Could you please provide a list of styles for the dropdown element?
I also use the Select 2 field formatter for that, but can't reproduce it.

It seems like some additional styles are present in the dropdown element, breaking it into two columns.

Hmm, strange, I couldn't reproduce such an issue locally. I installed the Gin theme on the Clear Drupal installation.

Could you please check the styles for this drop down element? Maybe we can find the root of the issue.

Oh, okay, I see. I tested it with the Claro theme and didn't experience such a problem.
Seems like taxonomy terms have long names and that causes an input field to extend to the bottom.

Ok, will check that. Great, that we found this bug now, thanks.

sirclickalot,

I created a PR with changes and also attached a patch for easy testing. Please, take a look, I checked different cases locally, but not sure if I handle all possible cases for that.

Thanks.

Hi sirclickalot,

Thanks for the ping, to be honest, I lost a bit on this topic. But I'll return to that soon, maybe even today =)
Sure, you can help with testing, it would be nice, thank you.

Will prepare changes for that soon.

I updated the patch to be able to apply for the 2.1.0-beta1 module version.

_shy → created an issue.

I fixed cspell and eslint issues.
Also, found that basically, the module is not working properly, when just installing it via composer.

Here is a list of changes:

• Fixed cspell and eslint warnings
• Changed a bit the way of how field formatter render a value. Previously class and data attributes weren't implemented to the #markup
• Fixed bug with attaching library name for the countUp
• Reworked JS code

_shy → created an issue.

Changes for this task were merged, so we can close it.

All of these changes were merged and released in the 1.2.0 version.
I close this task.

I re-opened an MR due to the problem with pushing changes.

I found an issue with the JS code, which triggers an error when rendering or replacing placeholders.

_shy → changed the visibility of the branch 3475743-blocks-are-not-rendered to hidden.

_shy → changed the visibility of the branch 3475743-blocks-are-not-rendered to active.

_shy → changed the visibility of the branch 3475743-blocks-are-not-rendered to hidden.

_shy → made their first commit to this issue’s fork.

_shy → created an issue.

Hi guys.
I just took a quick look at this issue and provided a very short and dirty way how we can skip errors for the case when using 'all' as a contextual filter argument.
This patch shouldn't fix all cases and I created it only just as a workaround to handle specific cases.
Feel free to upgrade it and improve.

_paulrad,

Please, fix the coding standards that we get after pipelines.

phpcs:

FILE: ...ustom/views_extras-3419820/src/Plugin/views/argument_default/TempStore.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 12 | ERROR | [x] Use statements should be sorted alphabetically. The first
    |       |     wrong one is Drupal\Core\TempStore\PrivateTempStoreFactory.
    |       |     (SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.IncorrectlyOrderedUses)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 200ms; Memory: 6MB
PHP CODE SNIFFER REPORT SUMMARY
--------------------------------------------------------------------------------
FILE                                                            ERRORS  WARNINGS
--------------------------------------------------------------------------------
...ras-3419820/src/Plugin/views/argument_default/TempStore.php  1       0
--------------------------------------------------------------------------------
A TOTAL OF 1 ERROR AND 0 WARNINGS WERE FOUND IN 5 FILES
--------------------------------------------------------------------------------
PHPCBF CAN FIX 1 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
PHP CODE SNIFFER VIOLATION SOURCE SUMMARY
--------------------------------------------------------------------------------
    SOURCE                                                                 COUNT
--------------------------------------------------------------------------------
[x] SlevomatCodingStandard.Namespaces.AlphabeticallySortedUses.Incorrectl  1
--------------------------------------------------------------------------------
A TOTAL OF 1 SNIFF VIOLATION WERE FOUND IN 1 SOURCE
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SOURCES AUTOMATICALLY (1 VIOLATIONS IN TOTAL)
--------------------------------------------------------------------------------

phpstan:

 ------ ---------------------------------------------------------------------- 
  Line   src/Plugin/views/area/ExtraResult.php                                 
 ------ ---------------------------------------------------------------------- 
  52     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 
 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/views/argument_default/Cookie.php                                  
 ------ ------------------------------------------------------------------------------ 
  75     Unsafe usage of new static().                                                 
         💡 See:                                                                       
            https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static  
 ------ ------------------------------------------------------------------------------ 
 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/views/argument_default/Session.php                                 
 ------ ------------------------------------------------------------------------------ 
  74     Unsafe usage of new static().                                                 
         💡 See:                                                                       
            https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static  
 ------ ------------------------------------------------------------------------------ 
 ------ ------------------------------------------------------------------------------ 
  Line   src/Plugin/views/argument_default/TempStore.php                               
 ------ ------------------------------------------------------------------------------ 
  84     Unsafe usage of new static().                                                 
         💡 See:                                                                       
            https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static  
 ------ ------------------------------------------------------------------------------ 
 [ERROR] Found 4 errors    

Found some coding standard issue which is not related to the current changes, so you can work with separate issue to fix that - 📌 Fix coding standards Active

_chetan 11, note for the future, please, create PR's according to the drupal.org documentation, because PR title is not correct, missing task ID and link to the issue.

Merged to the 3.x-dev.
Thanks.

_paulrad,

💬 Add composer.libraries.json to support composer workflow Needs review was merged, you can continue with this task.

I noticed some coding standard issues, not related to the provided changes, so I created a separate task for fixing it, if you want, you can work on it as well - 📌 Fix coding standards Active

Merged current changes to the 3.x-dev!
Thanks.

_shY → created an issue.

Has anyone found a solution or at least a workaround for that case?
Any suggestions could be useful.

Released a new module version with these changes.

https://www.drupal.org/project/entity_reference_edit_link/releases/1.1.3 →

Merged, thank you guys!

Updated patch to be able to apply it for the Drupal 10.3.1

Updated the last patch to make it smoother during resizing and fixed width changes during resizing.

_shY → created an issue.

Attached the patch as well.

_shY → created an issue.

Updated patch to work with the latest 8.x-1.x version

Thank you!

Merged to the 1.x-dev branch.

I want to add just a note, of what we need to do here.

To implement that we need:

• go to \Drupal\entity_reference_edit_link\Plugin\Field\FieldWidget\EntityReferenceEditLinkAutocompleteWidget::formElement() and change the type of displaying link if field allows multiple values. We need to change the type from the link to dropbutton and provide according values to this type
• add support dropbutton link types for the \Drupal\entity_reference_edit_link\Plugin\Field\FieldWidget\EntityReferenceEditLinkAutocompleteTagsWidget
• As I see it also has a variable for the button heading, we need to implement that as well to provide 'Edit' heading and list of the nodes in the dropdown

Merged into 1.x-dev! Will be added to the next release.

_shY → created an issue.

Thanks, everyone!

Merged to the 1.0.x branch. Will be added in the next release version!

dstorozhuk, please, don't change the issue status to the Closed (fixed) manually. This status will be changed automatically after 2 weeks.

You can read more here -
https://www.drupal.org/docs/develop/issues/fields-and-other-parts-of-an-... →

dstorozhuk, I fixed coding standards and the issue with WSOD after the latest changes for the dev branch and pushed everything to the 8.x-2.x.

As you mentioned in the previous task, we can continue to work with 1.x branch. You can merge all changes from the 8.x-2.x to the 1.x branch and delete the ol 8.x-2.x branch

Still need to fix some phpstan and cspell issues.

------ ------------------------------------------------------------------------------ 
  Line   src/Form/EditLinkConfigForm.php                                               
 ------ ------------------------------------------------------------------------------ 
  47     Unsafe usage of new static().                                                 
         💡 See:                                                                       
            https://phpstan.org/blog/solving-phpstan-error-unsafe-usage-of-new-static  
 ------ ------------------------------------------------------------------------------ 
 [ERROR] Found 1 error                                                          

./src/Form/EditLinkConfigForm.php:82:32     - Unknown word (entitiess)  -- Section for configuring entitiess.
	 Suggestions: [entities, enmities, entitles, nettie's, entices]
CSpell: Files checked: 9, Issues found: 1 in 1 files

I just got the list of phpstan notices from the last pipeline run.
Here is an example - https://git.drupalcode.org/issue/views_url_alias-3417436/-/jobs/1127931

I think there are missing use statement for the PathAliasInterface in views_url_alias.module file

Merged to the 1.0.x!

In case some people's names were marked as an issue, create a .cspell-project-words.txt file and add it to this file as an exception.
Example here.

Also, it would be great to fix coding standard issues:

 ------ ----------------------------------------------------------------------- 
  Line   views_url_alias.module                                                 
 ------ ----------------------------------------------------------------------- 
  44     Parameter $path_alias of function views_url_alias_path_alias_insert()  
         has invalid type PathAliasInterface.                                   
  56     Parameter $path_alias of function views_url_alias_path_alias_update()  
         has invalid type PathAliasInterface.                                   
  72     Parameter $path of function views_url_alias_path_alias_delete() has    
         invalid type PathAliasInterface.                                       
 ------ ----------------------------------------------------------------------- 
 [ERROR] Found 3 errors 

Merged to the 8.x-2.x.
I'll create a separate task for the coding standard issue and CSpell issues.
Thanks, everyone!

_shY → created an issue.

Thank you, apaderno
Merged to the 1.0.x!

_shY → created an issue.

Rerolled patch. Also added test fixes.

_shY → created an issue.

Hi SirClickalot
I fixed an issue with the Gin theme, changes are available in the last module release. Feel free to use =)

Now it should work with the Gin theme as well.
Changes available in the new release - 1.0.5!

Gauravvvv, thanks for the patch, it works well.
I did some testing and found that if add some more timeout, then resize looks slightly.

Updated patch, increased timeout.

For now, I stack with ESlint check. We have .eslintrc.json file which is has the following line: "extends": "drupal"
This causes the following error on the ESlint job:

ESLint couldn't find the config "drupal" to extend from. Please check that the name of the config is correct.
The config "drupal" was referenced from the config file in "/builds/project/cookies_addons/web/modules/custom/cookies_addons/.eslintrc.json".

This file does not strictly need to exist in contrib, because eslint config files placed further up in the directory structure will be merged and inherited. The top-level .eslintrc.json extends ./core/.eslintrc.json.

Basically, I designed this for edit pages only, but probably in the future, it will make sense to extend functionality as you described.
Anyway, I would like to start with editing pages for now, so I like your suggestion with the "EDIT" button and dropdown of nodes.

I'll proceed with this way.

Still experienced some coding standard issues. I'll take a look at it.

Thanks, merged to 8.x-2.x!

Thanks everyone.
Merged to the 8.x-2.x!

Yeah, you are right, I also noticed that for multiple field values. But not sure enough, the best way how to display the button here.
Maybe something like here, where we'll have a button group with all links for all nodes, and display the short title of the node, to know which one we want to edit?

Hi, thanks for your notice.
I've created a new issue for this case because the current one doesn't fit this case =)
🐛 Content type edit link does not show with Gin theme Active

_shY → created an issue.

_shY → created an issue.

_shY → created an issue.