Ukraine, Lutsk 🇺🇦
Account created on 5 April 2021, almost 4 years ago
#

Merge Requests

More

Recent comments

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

I just updated the patch from comment #6 🐛 Layout builder fails after cloned page delete Needs work to be available for the last module version.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Added changes to the new release .

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

_motti,

Thanks, merged to the 1.0.x!

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

_shy made their first commit to this issue’s fork.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Merged to the 2.0.x-dev.
Thanks

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Looks nice for me.
Merged to the 8.x-1.x branch.
Thank you, guys.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

_shy created an issue.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Merged to the 3.x-dev!

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

I'll be happy to help with releasing Drupal 10 and higher compatible versions and help maintain this module. Also, I can opt for projects into security advisory coverage.
Please, add me as a maintainer.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Merged to the 8.x-1.x-dev.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Merged to the 8.x-1.x-dev.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Merged to the 8.x-1.x-dev.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Merged to the 8.x-1.x-dev.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

_shy created an issue.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

_shy created an issue.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Merged to the 2.0.x-dev!

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

_shy created an issue.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

_shy created an issue.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Merged to the 3.x-dev!

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

_shy created an issue.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Merged to the 3.x-dev branch. Thanks.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Merged to the 8.x-1.x-dev, thanks!

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

_shy created an issue.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

_shy created an issue.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

_shy created an issue. See original summary .

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

_shy created an issue.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

_shy created an issue.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

_shy created an issue.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

_shy created an issue.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Module doesn't support Drupal 11 now.
Make the module compatible with D11

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

_shy created an issue.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

_shy created an issue.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

_shy created an issue.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

_shy created an issue.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Seems like it's not possible to access some links from the mega menu. I tried to open a "Drupal CMS" link from the menu and instead of redirecting just another mega menu item was opened.

Here is an example:

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Merged, thanks!

These changes will be added to the next release.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Looks great, thanks.

Merged to the 1.0.x-dev and will be added to the next release.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

vieilours, thanks for your notice.

I created an MR with fixes for the given issue. Added a validation to prevent an error for the entities without the Edit form template.

Now, we need some testing for it.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Changes added to the new release 1.0.1

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Hi, it's a great idea. I reviewed and merged a PR. Will add these changes to the next release.
Thanks for your contribution.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

These changes were released in the 1.1.4 version.

Feel free to use =)

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Thank you, sirclickalot, for your time.

I've fixed some coding standards issues and merged these changes to the 1.x-dev branch.
I'll create a new release with these changes soon.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Thank you sirclickalot, for your testing.

It seems like some style issues, but I'm unsure where it comes from. You can add a class .open for the .dropbutton-wrapper .dropbutton-multiple element. It will help to keep the dropdown open all the time.

Also, it's important to check styles for the <ul> element. Because as you mentioned earlier the main problem is the position and the width of each item. Could you please check styles for the whole <ul> element and for the links inside the list?

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Sorry, but that didn't help. Could you please provide a list of styles for the dropdown element?
I also use the Select 2 field formatter for that, but can't reproduce it.

It seems like some additional styles are present in the dropdown element, breaking it into two columns.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Hmm, strange, I couldn't reproduce such an issue locally. I installed the Gin theme on the Clear Drupal installation.

Could you please check the styles for this drop down element? Maybe we can find the root of the issue.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Oh, okay, I see. I tested it with the Claro theme and didn't experience such a problem.
Seems like taxonomy terms have long names and that causes an input field to extend to the bottom.

Ok, will check that. Great, that we found this bug now, thanks.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

sirclickalot,

I created a PR with changes and also attached a patch for easy testing. Please, take a look, I checked different cases locally, but not sure if I handle all possible cases for that.

Thanks.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Hi sirclickalot,

Thanks for the ping, to be honest, I lost a bit on this topic. But I'll return to that soon, maybe even today =)
Sure, you can help with testing, it would be nice, thank you.

Will prepare changes for that soon.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

I updated the patch to be able to apply for the 2.1.0-beta1 module version.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

_shy created an issue.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

I fixed cspell and eslint issues.
Also, found that basically, the module is not working properly, when just installing it via composer.

Here is a list of changes:

  • Fixed cspell and eslint warnings
  • Changed a bit the way of how field formatter render a value. Previously class and data attributes weren't implemented to the #markup
  • Fixed bug with attaching library name for the countUp
  • Reworked JS code
🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

_shy created an issue.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

Changes for this task were merged, so we can close it.

🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

All of these changes were merged and released in the 1.2.0 version.
I close this task.

Production build 0.71.5 2024