Remove BlockContentController::Add

I'm not sure if the function \Drupal\Core\Entity\Controller\EntityController::addPage() fits for that because this function has an argument $entity_type_id that should be passed from the route.

Or, I just missed something important here.

There is no need to deprecate - core controllers aren't part of the api unless marked as such.

Pushed up some attempts. But currently have an issue where

Create 2 block types
Create a test editor and assign permissions for just 1 block type
Login and try and create a block
Button doesn't do anything.

smustgrave → credited larowlan → .

For the slack help.

I think we'll need to make sure we keep the same route name for BC sake so if we move to a route provider, overriding the default name of entity.block_content.add_page to be the same as now will be required.

block_content.add_form: '/block/add/{block_content_type}'
block_content.add_page: /block/add
block_content.type_add: /admin/structure/block-content/add
block_content.type_add.bc: /admin/structure/block/block-content/types/add

block_content.add_form: '/block/add/{block_content_type}'
block_content.add_page: /block/add
block_content.type_add: /admin/structure/block-content/add
block_content.type_add.bc: /admin/structure/block/block-content/types/add

So routes end up staying the same, so we are good.

For #11 I removed the line adding the destination parameter to the "Add content block" button. Adding a block still redirect

Will pick back up tomorrow

smustgrave → credited AaronMcHale → .

Closed 📌 [PP-1] Provide a "add" link template for the block_content_type entity type Closed: duplicate as a duplicate

Think need approval on the removal of the destination parameter.

The failures I currently have no clue about. Clearly missing a route setting