BlockContentType should implement EntityDescriptionInterface

Assume the test-only changes should of failed?

Would a simple unit test provide test coverage?

Added skeleton unit test (needs work).

Re #4 - no since this wasn't a bug fix. I've added test coverage for setDescription now though which would fail since setDescription didn't exist before.

@oily I'm not sure what the unit test was but I've removed it, we can just use a kernel test.

@acbramley Okay with the test. Perhaps pedantically I thought implementing a new interface would mean a unit test. I support a kernel test if ticks the box.

Changes look good, match the IS and have test coverage. I think this is ready for RTBC.

Adding credit.

larowlan → credited joachim → .

Committed to 11.x, nice one

larowlan → closed merge request !12396

Automatically closed - issue fixed for 2 weeks with no activity.