Contrib.social

Add typehints to ImageInterface and adjust the tests

Open on Drupal.org →
Created on 2 March 2023, almost 2 years ago
Updated 27 October 2023, about 1 year ago

Problem/Motivation

core/lib/Drupal/Core/Image/Image.php and core/lib/Drupal/Core/Image/ImageInterface.php are missing return typehints.

Steps to reproduce

If return type hint is added to any of existing actions like apply(), convert(), crop(), desaturate(), ... the unit tests will fail with error message:

    1) Drupal\Tests\Core\Image\ImageTest::testRotate
    TypeError: Drupal\Core\Image\Image::rotate(): Return value must be of type
    bool, array returned

Proposed resolution

Add return type hints, adjust the tests.

📌 Task
Status

Needs work

Version

11.0 🔥

Component
Image system  →

Last updated 1 day ago

Created by

🇫🇮Finland sokru

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Issue created by @sokru
  • First commit to issue fork.
  • @_shy opened merge request.
  • Status changed to Needs review about 1 year ago
  • Comment about 1 year ago →
    🇺🇦Ukraine _shy Ukraine, Lutsk 🇺🇦

    Seems like all tests are passed.

  • Status changed to RTBC about 1 year ago
  • Comment about 1 year ago →
    🇺🇸United States smustgrave

    This looks good but my concern is for backwards compatibility. But may not be an issue.

  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    🇬🇧United Kingdom longwave UK

    Yeah, there are definitely BC concerns here - if someone else has implemented ImageInterface without return types, adding the return types here will break their code. We don't have a good plan for solving this at present except by perhaps using Symfony's debug class loader to notify downstream users of our code.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024