- Issue created by @maithri shetty
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 2:41pm 7 February 2024 - First commit to issue fork.
- Status changed to Needs work
over 1 year ago 1:32pm 23 April 2024 - 🇦🇺Australia VladimirAus Brisbane, Australia
Task upgraded from "Drupal calls should be avoided in classes, use dependency injection instead" to "PHPCS compatibility"
- First commit to issue fork.
- Status changed to Needs review
about 1 year ago 11:59am 9 August 2024 - 🇫🇮Finland sokru
The PHPCS job is now green. I tried to keep changes minimal so it would be easy to review (so no constructor property promotion).
I fully ignored ExportTermsForm since the functionality is not working at the moment. I would recommend fixing the CS issues on same issues as where the export functionality will be done.
- Status changed to RTBC
about 1 year ago 2:57pm 9 August 2024 - 🇫🇮Finland jhuhta
The changes look good and the touched functionalities still work, given that ExportTermsForm is ignored as @sokru said.
Phpstan and the likes will be addressed separately I assume.
-
VladimirAus →
committed 0ae613a3 on 2.0.x
Issue #3419791: PHPCS compatibility
-
VladimirAus →
committed 0ae613a3 on 2.0.x
- Status changed to Fixed
about 1 year ago 5:15am 12 August 2024 - 🇦🇺Australia VladimirAus Brisbane, Australia
Thanks! Committed! 🥂
Automatically closed - issue fixed for 2 weeks with no activity.