It is easy to create a Media entity with a non-existent type (see "Steps to reproduce" below). But saving the entity causes a PHP fatal error.
I came across this when defining a migration, when I used the incorrect bundle name.
The error is caused because Media::prepareSave() calls Media::getSource(), which is simply
public function getSource() {
return $this->bundle->entity->getSource();
}
If the bundle is not valid, then $this->bundle->entity is NULL, which leads to an error something like this:
Call to a member function getSource() on null in Drupal\media\Entity\Media->getSource() (line 137 of /var/www/html/web/core/modules/media/src/Entity/Media.php)
$entity = \Drupal::entityTypeManager()
->getStorage('media')
->create(['name' => 'foo', 'bundle' => 'does_not_exist']);
$entity->save();
Check that the bundle value is one of the configured Media types in Media::doCreate(). If not, then throw an exception.
We already throw an exception, in ContentEntityBase::doCreate(), if no bundle value is provided.
None.
None.
None.
N/A
Needs work
10.1 ✨
Last updated
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
A change record needs to be drafted before an issue is committed. Note: Change records used to be called change notifications.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
I tested on Drupal 10.1.x, standard install using the steps in the Issue Summary. I was able to reproduce the error.
back to need work for tests.
I'm aware that the previous consensus was to only fix this for the Media entity type because of the perception that it would be too much work for all entities. But I really wanted to see for myself what would happen.