Contrib.social

Form radios Twig file CSS class is not consistent with form checkboxes

Open on Drupal.org →
Created on 6 January 2020, almost 5 years ago
Updated 6 February 2023, almost 2 years ago

Problem/Motivation

Files core/modules/system/templates/checkboxes.html.twig and core/modules/system/templates/radios.html.twig are inconsistent which is inconvenient for themers. The checkboxes.html.twig file adds a 'form-checkboxes' class, but the radios.html.twig file does not add a 'form-radios' class as would be expected.

Proposed resolution

Add 'form-radios' class for consistency.

✨ Feature request
Status

Needs work

Version

10.1 ✨

Component
System  →

Last updated 3 days ago

No maintainer
Created by

🇺🇸United States daniel korte Brooklyn, NY

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

  • Needs change record

    A change record needs to be drafted before an issue is committed. Note: Change records used to be called change notifications.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago →
    🇺🇸United States smustgrave

    This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

    Tagging for needs work as this may be the same for other themes inside Drupal10, stable is actually be replaced by stable9 for example
    Tagging for tests to check the appearance of the class
    Tagging for a change record to let people know of the template change

    Thanks!

  • Comment almost 2 years ago →
    🇮🇳India _utsavsharma

    Patch for 10.1.x.

  • Status changed to Needs review almost 2 years ago
  • Comment almost 2 years ago →
    🇮🇳India Shubham Sharma 77

    Applied patch #10 applied successfully in drupal-10.1.x-dev
    For ref sharing screenshots...
    RTBC+1

  • Status changed to RTBC almost 2 years ago
  • Comment almost 2 years ago →
    🇮🇳India ameymudras

    Tested on 10.1.x and this seems to be a good improvement. Issue summary is clear and screenshots have been provided above. Im marking this as RTBC

  • Status changed to Needs work almost 2 years ago
  • Comment almost 2 years ago →
    🇺🇸United States smustgrave

    No tests or change record please take a look at the tags also.
    Thanks

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024