🇺🇸United States @Daniel Korte

daniel korte → made their first commit to this issue’s fork.

Noting here that I’m seeing a JS console error in D10.2.6 (with either patch #126 or the merge request since they are virtually the same) when attempting to embed media in ckeditor5 using a newly uploaded image and clicking the "Save and insert" button with the Media Library advanced UI enabled:

ajax.js?v=10.2.6:1143
An error occurred during the execution of the Ajax response: TypeError: Cannot read properties of undefined (reading 'options')

Using Drupal\content_moderation\ModerationInformationInterface instead of Drupal\content_moderation\ModerationInformation and cleaned up the patch a bit

Thanks!

Reroll

Thanks @drumm!

Daniel Korte → created an issue.

Daniel Korte → made their first commit to this issue’s fork.

@bircher I think the added value here is being able to run the core/scripts/run-tests.sh script without errors caused by this module. Testing is not limited to just drupal ci. This fix is essential to other CI pipelines where the Drupal core test script is being used.

Same as #26. This commit breaks sites with only options_show_only_used set. I opened #3439538 to figure out a solution.

Daniel Korte → created an issue.

Try again...

I’m changing this to a Bug Report since I would expect this behavior from the view own unpublished media permission, but let me know if I’m wrong here.

I cleaned things up and addressed comment #12 concerns. Also, I noticed the existing patches don’t apply to the Media Library Grid/Table Widget which also has this issue. I updated the Views config to mirror what is being used on the Media Library admin page with the media_status plugin. Everything appears to be working with the view own unpublished media permission now.

Confirmed. This fixes the issue.

This appears to be an issue with the editor_advanced_link module not supporting the editor_file module so changing this to a Feature request. The editor_advanced_link CKeditor 5 plugin only has support for the ckeditor5-link plugin. JavaScript needs to be added to this module to respond/listen for the editor_file ckeditor5 plugin execution.

Daniel Korte → created an issue.

Daniel Korte → created an issue.

Fix PHP deprecated notice: Deprecated function: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in url()

Daniel Korte → created an issue.

Daniel Korte → created an issue.

Applying the patch from 🐛 Logic error in Html::transformRootRelativeUrlsToAbsolute() Fixed to our custom transformRootRelativeUrlsToAbsolute() function...

@jeffschuler Yeah, sorry, I wasn’t sure if I should have created a new issue or posted on that issue since the process function is completely different now. Also, though I finally figured out the tests. The test string wasn’t correct and the configuration wasn’t set.

I had to update the tests so the Filter is actually loaded with the settings. The code is mostly mirrored from core/modules/filter/tests/src/Kernel/FilterKernelTest.php

Fix tests.

Ready to review!

@jeffschuler Got it. Sounds good. I think I can knock that out in the next day or so.

@jeffschuler Maybe I’m missing something, but why isn’t Html::transformRootRelativeUrlsToAbsolute() used in the process() function instead of the current regex?

Backwards compatibility patch for 8.x-1.5

I think this module should more closely match what is happening in https://www.drupal.org/project/media_entity_audio → in the 8.x-3.x version (minus the audio streaming stuff). My only intention here for 8.x-3.x is to update from 8.x-2.x and then be uninstalled. Therefore the Entity Browser widget should be removed like in media_entity_audio 8.x-3.x version, right? Also, this would mean the module should work with Drupal: ^9 || ^10 instead of only ^9.3 || ^10

Seems like a duplicate of #3175411: createCollectionDataFromEntities overrides language versions →

Daniel Korte → created an issue.

For anyone else needing help with this, I’m using this drush command for now:
drush sqlq "ALTER TABLE media__field_media_lottiefile ADD COLUMN field_media_lottiefile_addclass VARCHAR(32) default ''; ALTER TABLE media_revision__field_media_lottiefile ADD COLUMN field_media_lottiefile_addclass VARCHAR(32) default '';"

Previous patch is for 2.x and this one is for 3.x

better_exposed_filters needs to be required as ^6.0 for D10 support

@Eduardo Morales Alberti I think so. That is the issue I am having. I added a check to the merge request. Please review, thanks.

Daniel Korte → made their first commit to this issue’s fork.

Daniel Korte → created an issue.

Thanks, looks good. I removed the permission part and used the regular 'administer site configuration' permission here.

Daniel Korte → made their first commit to this issue’s fork.

I don’t think it makes sense to make the 8.x-2.x branch D10 compatible (and thus remove D8 compatibility). That branch is only intended to work with D8/9. I recommend that all users upgrade to Drupal core media with the 8.x-3.x branch of this module, run Drupal updates, and then uninstall/delete this module.

Daniel Korte → created an issue.

Allow 'json' too

Daniel Korte → created an issue.

@andreic Try jsonapi/node?filter[type][condition][path]=type.meta.drupal_internal__target_id&filter[type][condition][operator]=IN&filter[type][condition][value][]=event_card&filter[type][condition][value][]=podcast

Okay, it worked for me if I defined my computed field in code only (i.e. not adding the computed field to an entity bundle via the Field UI):

/**
 * Computed field string.
 *
 * @ComputedField(
 *   id = "computed_field_attached",
 *   label = @Translation("Computed field"),
 *   field_type = "string",
 *   no_ui = TRUE,
 *   attach = {
 *     "scope" = "base",
 *     "field_name" = "computed_field",
 *     "entity_types" = {
 *       "node" = {
 *         "article",
 *       },
 *     },
 *   },
 * )
 */

I’m experiencing the same issue. The field shows up everywhere except the JSON output.

This patch fixed a similar problem for me where the bundle was set to "menu_link_content" on migrated menu items from a Drupal 7 website. Using this patch fixed the bundles and the menu fields work again.

This fixed an issue that I was having where the JS code was called twice after clicking show more.

Yup, disregard #219. It was a configuration issue on my end.

Daniel Korte → created an issue.

That was it! Thank you so much!

Daniel Korte → created an issue.

Patch #218 not working for 9.5.4

Re-roll for the 1.4 version

Same issue here. Reverting back to 7.x-1.0-beta2

Daniel Korte → created an issue.

Restoring the empty() function fixes things for me.

Daniel Korte → created an issue.

Daniel Korte → created an issue.

Daniel Korte → created an issue.

Here is a 8.x-1.x patch