Logic error in Html::transformRootRelativeUrlsToAbsolute()

Can we add tests to prove the bug exists and that this fixes it?

@borisson_: I understand why you're requesting this but I don't believe it's a bug that deserves tests and it doesn't result in incorrect output. It's just a logical error that results in unnecessary over-processing.

This:

foreach (static::$uriAttributes as $attr) {

loops over each of the attributes in this array:

protected static $uriAttributes = ['href', 'poster', 'src', 'cite', 'data', 'action', 'formaction', 'srcset', 'about'];

For each of these attributes the current code is looking for all instances of that attribute, and then also looking for all instances of srcset, and operating on the value of each srcset it finds.

So ... for every attribute ... we'll parse and operate on every srcset needlessly. We should only parse for and operate on each srcset once.

Refactor makes sense. This could probably be considered a task as it's an improvement over a bug. Will see what the committers think!

The last submitted patch, 2: core-transform_rel_to_absolute_srcset-3360220-2.patch, failed testing. View results →

Looks like that is a random fail, back to rtbc per #6. I'm convinced by #4 that we don't need tests for this particular one.

The last submitted patch, 2: core-transform_rel_to_absolute_srcset-3360220-2.patch, failed testing. View results →

Think another random failure

The last submitted patch, 2: core-transform_rel_to_absolute_srcset-3360220-2.patch, failed testing. View results →

Another random fail

The last submitted patch, 2: core-transform_rel_to_absolute_srcset-3360220-2.patch, failed testing. View results →

back to rtbc, another random fail.

Committed 98df2c9 and pushed to 11.x. Thanks!

Oops! I introduced this bug ~7 years ago in #88183: Relative URLs in feeds should be converted to absolute ones → 😇 Thanks, @jeffschuler!

@Wim Leers your amount of productive output deserves a few mistakes. At least it wasn't causing any problems!

Thanks all for seeing this through.

Automatically closed - issue fixed for 2 weeks with no activity.