Add Cacheability to the toolbar items

Created on 8 February 2021, over 3 years ago

Updated 14 September 2023, 10 months ago

Problem/Motivation

Cacheable Metadata is missing for toolbar items:

If tabs are not shown in admin theme then the toolbar item should have theme context.
Local task manager Cacheability is not added to the toolbar item.
Primary and secondary tabs Cacheability is not added to the toolbar item.

Steps to reproduce

Enable the module via drush and then visit any admin page. Once you go back to the active theme the toolbar item will not be rendered because theme context is missing on the toolbar item.

Proposed resolution

Merge all the Cacheable Metadata and add it to the toolbar item.

Remaining tasks

Review.

User interface changes

Fixed the issue described in STR.

🐛 Bug report

Status

Fixed

Version

1.0

Component

Code

Created by

🇵🇰Pakistan jibran Sydney, Australia

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 10 months ago →
🇺🇸United States Daniel Korte Brooklyn, NY
Daniel Korte → made their first commit to this issue’s fork.
Comment 10 months ago →
System Message

Daniel Korte → committed f76aeb40 on 8.x-1.x authored by JamieP →
Issue #3197197: Add Cacheability to the toolbar items
Status changed to Fixed 10 months ago2:22pm 14 September 2023
Comment 10 months ago →
🇺🇸United States Daniel Korte Brooklyn, NY
Comment 9 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024