Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 18 July 2022, over 2 years ago
Updated 15 November 2023, about 1 year ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Needs work

Version

3.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • @dydave opened merge request.
  • First commit to issue fork.
  • Comment over 1 year ago →
    🇩🇪Germany vistree

    Hi, would be great to have a D10 compatible version. Any release plans?

  • Comment over 1 year ago →
    🇨🇭Switzerland Lukas von Blarer

    Since EOL of Drupal 9 is coming closer: Could we please get this committed?

  • Status changed to Needs work over 1 year ago
  • Comment over 1 year ago →
    🇺🇸United States daniel korte Brooklyn, NY

    I don’t think it makes sense to make the 8.x-2.x branch D10 compatible (and thus remove D8 compatibility). That branch is only intended to work with D8/9. I recommend that all users upgrade to Drupal core media with the 8.x-3.x branch of this module, run Drupal updates, and then uninstall/delete this module.

  • Status changed to Needs review over 1 year ago
  • Comment over 1 year ago →
    🇫🇷France dydave

    Thanks a lot Daniel!

    The MR !2 was updated accordingly to target branch 8.x-3.x and rebased.

    Back to Needs review to get more feedback and comments on the changes.

    Any suggestions, feedback, objections or comments, would definitely be greatly appreciated.
    Thanks in advance !

  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    🇮🇳India arisen Goa

    Reviewed the MR. The changes look good.
    Applied the MR patch on branch 8.x-3.x. The patch applies cleanly.

    Checking patch media_entity_video.info.yml...
Checking patch media_entity_video.install...
Checking patch media_entity_video.module...
Applied patch media_entity_video.info.yml cleanly.
Applied patch media_entity_video.install cleanly.
Applied patch media_entity_video.module cleanly.

    The module gets installed successfully on Drupal 10.
    Reviewed the features.

    • The Media source plugin works fine.(attached screenshot)
    • The Video File Formatter works as expected.(attached screenshot)
    • The entity browser doesn't work due to the dependence on contributed Media Entity module.
      Drupal\Component\Plugin\Exception\PluginNotFoundException: The "media_bundle" entity type does not exist. in Drupal\Core\Entity\EntityTypeManager->getDefinition() (line 139 of /var/www/html/web/core/lib/Drupal/Core/Entity/EntityTypeManager.php).

      Symfony\Component\Routing\Exception\RouteNotFoundException: Route "media.bundle_add" does not exist. in Drupal\Core\Routing\RouteProvider->getRouteByName() (line 206 of /var/www/html/web/core/lib/Drupal/Core/Routing/RouteProvider.php).

  • Status changed to Needs review about 1 year ago
  • Comment about 1 year ago →
    🇮🇳India arisen Goa

    Updated the MR with fixes to the Entity Browser widget.
    Please review.

  • Status changed to Needs work about 1 year ago
  • Comment about 1 year ago →
    🇺🇸United States daniel korte Brooklyn, NY

    I think this module should more closely match what is happening in https://www.drupal.org/project/media_entity_audio → in the 8.x-3.x version (minus the audio streaming stuff). My only intention here for 8.x-3.x is to update from 8.x-2.x and then be uninstalled. Therefore the Entity Browser widget should be removed like in media_entity_audio 8.x-3.x version, right? Also, this would mean the module should work with Drupal: ^9 || ^10 instead of only ^9.3 || ^10

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024