Ok, that makes sense. No, I have no idea how to approach this.
Do you know a workaround for the issue I described though?
Lukas von Blarer → created an issue.
Ok, this works as designed. This is the solution to this problem: 🐛 Views - Anonymous User Fixed
I was able to make the code a bit more generic:
/**
* Implements hook_ENTITY_TYPE_access().
*/
function HOOK_view_access(View $view, $operation, $account) {
$route_name = \Drupal::routeMatch()->getRouteName();
if ($operation === 'view' && str_starts_with($route_name, 'graphql.query')) {
return AccessResult::allowedIf($view->getExecutable()->access('default', $account));
}
return AccessResult::neutral();
}Maybe that should be documented in the docs here? https://graphql-core-schema.netlify.app/schema-extensions/views.html That's at least where I was looking for why this isn't working.
I'm having this issue as well. @Siegrist have you found a solution to this?
I have the same issue. @kaszarobert did you come up with a solution for this?
Lukas von Blarer → created an issue.
I think this doesn't solve the issue entirely. If I understand your approach correctly, this solves the incorrect order for non-company addresses. But the issue where the order is mixed up compared to the user input persists for company addresses. Is there a way to solve that too?
Lukas von Blarer → created an issue.
Oh, I just realized that using prefixes is the way the blacklist of purge_queuer_coretags works already. I don't think that that is optimal, since that gives us less flexibility, but I guess that's is another issue. Please ignore the patch in #13.
This one only checks for exact matches. But I didn't fix anything else. So just ignore this patch in case you don't need that.
Attached you can find a re-roll.
In my case I need exact matches. I want to blacklist node_list, but that would also match node_list:article, which is not what I want.
Lukas von Blarer → created an issue.
Lukas von Blarer → created an issue.
Lukas von Blarer → created an issue.
Lukas von Blarer → created an issue.
Lukas von Blarer → created an issue.
Lukas von Blarer → created an issue.
Lukas von Blarer → created an issue.
Right now I can't do a full review of the MR. Is there a way to get a diff of my module? That way I could reply to changes.
Hi there! Thank you for reaching out to me!
All fine for me that you ported my code here. Please make sure that I receive commit authorship for it. And I'd like to declare the sponsorship for it on the project page.
Lukas von Blarer → created an issue.
The current MR worked perfectly for a field formatter in a view. Thank you!
Sorry, probably that needs a better review ;)
This works like a charm! Thank you!
I think that for the specific use case of having an array with values this is the simpler and better solution than the approach of ✨ Add wrapper process plugin to wrap/unwrap values in arrays Needs review .
Sorry, I forgot to add the new files.
Ok, here is a re-roll.
This needs a re-roll.
I fixed an issue where the duration is wrong in case the entries don't lass full hours, but fractions such as 1 hour and 30 minutes.
I just had another failing webhook for a different order with the same error.
I don't allow users to set a timezone for their account. Insystem.date the timezone.user.configurable is set to false.
I'm having trouble finding out which order the failing webhook belongs to in the wallee backend. Because of that I can't provide more information about the failing order. Do you know how to associate a webhook with a payment transaction in wallee?
I'm currently testing this patch. One thing that would be really nice is handling of overlapping items in the calendar. Currently they simply sit on top of each other and can completely cover each other.
Lukas von Blarer → created an issue.
This doens't work for me yet. Exception days still have no effect on the 'Current day' formatter.
Ok, thnak you! This works now.
On current dev exception days are completely broken. They basically have no effect on the 'Next day' formatter.
On current dev at least exception days are completely broken. They basically have no effect on the 'Current day' formatter.
Ok there is another issue with a patch: ✨ Media items translate items in modal Postponed Marking this one as a duplicate.
I decided to create a new branch and MR based on the existing MR. I didn't make any changes.
Lukas von Blarer → made their first commit to this issue’s fork.
The patch in #10 works for me.
Ok, great. I'm happy to test MRs or patches.
Ok, let me know if I can support you.
Lukas von Blarer → created an issue.
Thank you, this works for me!
The patch contains a call to dpm().
Lukas von Blarer → created an issue.
Lukas von Blarer → created an issue.
@sourabhjain Nope, no luck sadly.
I'm facing this issue as well. And I can reproduce this consistently.
Here is one finding: This issue only appears if the promotion affecting the product price is set to Only show the discount on the order total summary. Setting it to Include the discount in the displayed amount fixes the issue for me. But since I want the first of the two settings, this is not a viable workaround for me.
I needed that for AVIF to work with imagemagick, but probably that is needed for GD as well: 📌 ExtensionMimeTypeGuesser doesn't support .avif Active
@Berdir Probably, yes.
Lukas von Blarer → created an issue.
This stopped working in a recent update I installed.
What is missing to get this committed?
There is already an issue regarding D10 compatibility: 📌 Automated Drupal 10 compatibility fixes Needs review
Could we get a release with this? The module is basically unusable with Drupal 10 without this fix.
I improved the approach in #60 a bit:
function MODULE_update_9501() {
$fields = [
[
'entity_type' => 'node',
'bundle' => 'bundle_name',
'field_name' => 'field_name',
],
];
foreach($fields as $field){
/** @var \Drupal\Core\KeyValueStore\KeyValueFactoryInterface $key_value_factory */
$key_value_factory = \Drupal::service('keyvalue');
$field_map_kv_store = $key_value_factory->get('entity.definitions.bundle_field_map');
$map = $field_map_kv_store->get($field['entity_type']);
// Remove the field_fpimage field from the bundle gallery_assist for the page bundle.
unset($map[$field['field_name']]['bundles'][$field['bundle']]);
$field_map_kv_store->set($field['entity_type'], $map);
}
}Lukas von Blarer → created an issue.
Reverting version
Just ran into this issue once again. It would be great to fix this, since it can be pretty annoying such as breaking CI pipelines when installing modules.
Could we move this issue forward? I guess the comments in #25 are still valid?
Attached is a first patch to make the sandbox https://www.drupal.org/sandbox/tstoeckler/2962081 → Drupal 10 compatible created using rector.
Could we get this committed?
The MR is using jQuery.once resulting in errors like this:
Uncaught TypeError: $(...).find(...).once is not a function
Lukas von Blarer → created an issue.
Or just add me to the maintainers so I can do it on my own. I'm gonna work on D10 compatibility now as well.
Would you mind committing this patch, please? I've been using it since more than two years now.
This MR fixes the error for me.
I'm already working on this.
Lukas von Blarer → created an issue.
Lukas von Blarer → created an issue.
That MR fixes the issue for me.
Lukas von Blarer → made their first commit to this issue’s fork.
The patch in #3 works for me. The indentation inside the new if statement could be improved though.
The patch in #88 works for me.
This needs a re-roll at least.
Ok, this is also broken with symfony_mailer.
Lukas von Blarer → made their first commit to this issue’s fork.
Lukas von Blarer → created an issue.
Lukas von Blarer → created an issue.
Lukas von Blarer → created an issue.
Since EOL of Drupal 9 is coming closer: Could we please get this committed?
Since EOL of Drupal 9 is coming closer: Could we please get this committed?
Since EOL of Drupal 9 is coming closer: Could we please get this committed?
Since EOL of Drupal 9 is coming closer: Could we please get this committed?
Ok, thank you for your feedback!