Verification of anonymous users is not being respected with Simplenews 4.0

Lukas von Blarer → made their first commit to this issue’s fork.

I was quite confused by this. I think the simplenews 4.x release took the wrong path here... This is a very unintuitive API. And in my opinion very prone to errors. Take a look at this:

<?php
  /**
   * Checks if subscriber confirmation should be skipped.
   *
   * @return bool
   *   TRUE if confirmation should be skipped.
   */
  public static function skipConfirmation() {
    // Skip if logged in or if configured to skip.
    return \Drupal::currentUser()->id() || \Drupal::config('simplenews.settings')->get('subscription.skip_verification');
  }
?>

Any logged in user can skip confirmation to subscribe any email address. And this is on an API level.

Here is a first draft to fix this issue.

Lukas von Blarer → closed merge request !7

The MR is a hacky fix for this.