Product attribute translation doesn't work unless permission "Translate configuration" is given to the user role

I have the same issue. @kaszarobert did you come up with a solution for this?

Not really. Frankly, we didn't mess around with that and we simply gave that permission to the shop owners and told them, that they should edit only product, order, content, taxonomy forms and leave the rest of the settings pages alone, and they did that.

Patch with changes from MR. To add access for users to translate product attributes add the "Translate product attribute" permission

1. +++ b/modules/product/commerce_product.module
   @@ -377,3 +377,27 @@ function commerce_product_field_group_content_element_keys_alter(&$keys) {
   +function commerce_product_entity_operation_alter(array &$operations, EntityInterface $entity): void {
   

   Do we really need this? Isn't the access automatically checked for the route?

2. +++ b/modules/product/commerce_product.module
   @@ -377,3 +377,27 @@ function commerce_product_field_group_content_element_keys_alter(&$keys) {
   +  // operation is not exist we need to check if the user has access to manage
   

   is not exist -> does not exist.

3. +++ b/modules/product/commerce_product.permissions.yml
   @@ -2,3 +2,8 @@
   +'translate product attribute':
   

   perhaps we should make this:
   translate "commerce_product_attribute"
   to match "administer commerce_product_attribute".

   I don't really see places where we just drop the prefix.

4. +++ b/modules/product/src/ConfigTranslation/ProductAttributeMapper.php
   @@ -24,7 +26,42 @@ class ProductAttributeMapper extends ConfigEntityMapper {
   +  private function addTranslationFormAccessCheck(Route &$route): void {
   

   In general, we prefer protected methods to allow for overrides in commerce core / contrib... I know it's tempting to add private methods, but... that isn't what we usually do :).

@jsacksick

1. We need to check access to the URL before adding it to the operation list, in another case users without access to this page would see the link but the page will return an access denied exception
2. Fixed
3. Permission renamed to "translate commerce_product_attribute"
4. Fixed

Committed, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.