New patch for the 1.16 version
@rszrama
Here are some screenshots before/after the patch
Before:
After:
Also, I have a small objection to the patch
It has a structure like:
if ($payment_gateway->getPlugin() instanceof OffsitePaymentGatewayInterface) {
///
}
else {
if ($payment_method_type_counts[$payment_method_type_id] > 1 && !$payment_gateway->getPlugin() instanceof OffsitePaymentGatewayInterface) {
///
}
}
The second condition !$payment_gateway->getPlugin() instanceof OffsitePaymentGatewayInterface is not necessary as it will always TRUE in this case
@jsacksick I've tried to get rid of the "value" key but it seems that it is not possible without rewriting a lot of staff or removing the denormalization process in the test (it would fail in this case)
The main thing is that JSON:API uses the field property definition as a foundation to generate the structure if we change it as a result all other things related to this field would be broken such as getAdjustments() etc. as those methods use "value" and I guess many other contrib/custom solutions may use this field like that.
Another thing that can help is to define more properties with their own data types to set values for Label, Type, Amount, etc. I do not think it is the best way to resolve this.
One more solution is to disable access to the main "adjustment" field for JSON:API as it is done in the "commerce_api" module and define a new computed field for it to show adjustment without the "value" key.
@jsacksick icon now changing if the copy process was successful together with the title attribute. After 2 seconds everything is turning back to the previous state.
Patch with the latest changes in MR
It should applied together with the patch for advancedqueue in
✨
Add support for unique jobs
Fixed
Updated patch for 1.0 version instead of 1.x-dev branch
Patch with the latest changes from MR to be used in 🐛 multiple recurring orders get created if cron is badly configured Needs work
tBKoT → made their first commit to this issue’s fork.
Hi @lalustine,
Based on the error log you provided, a couple of the contrib modules are used. Unfortunately, we cannot reproduce this issue as we do not have the same site setup as yours, especially for the webform_product where actual "magic" for creating an order with a billing profile happens.
@jsacksick
MR updated. The changed date will be the greatest value between the "created" and "renewed" dates.
MR is ready to be checked
The failed test is not related to the made changes it can be fixed by replacing
$values = [
'payment_method[target_id]' => 2,
];
with
$values = [
'payment_method[target_id]' => '2',
];
the number should be a string.
Attaching a patch, just in case
@ggautam
Could you recheck it? Unfortunately, I cannot reproduce it locally. Could you add some more details about the version of the module you used
Here is the screenshot
We could create a new field and theme for the views because I do not think 'operations' is a good way to add this logic as we do not do anything with variation.
@jsacksick
As we implemented OAuth requests in #3387353, so this issue is not relevant anymore. It already has the Account number as one of the API credentials. We need to check the negotiated rates there and fix them if needed
Here is the patch, while waiting for merging changes
tBKoT → changed the visibility of the branch 8.x-1.x to hidden.
@jsacksick
1. We need to check access to the URL before adding it to the operation list, in another case users without access to this page would see the link but the page will return an access denied exception
2. Fixed
3. Permission renamed to "translate commerce_product_attribute"
4. Fixed
Patch with changes from MR. To add access for users to translate product attributes add the "Translate product attribute" permission
tBKoT → made their first commit to this issue’s fork.
Patch with the latest changes from MR
For Open Social 12.2+
Updated patch from #45 and removed changes related to deprecation fix as it was resolved in #3319388
@lindsaywils
Could you try the latest patch from #45? I've made some changes to the form_alter because custom submit from there also was triggered when the user added a new card which should not happen. As a result, the stored CVV code is overridden to NULL.
tBKoT → made their first commit to this issue’s fork.
Hi @morbus-iff
Could you describe a bit more how I can reproduce the issue? I've tried a bunch of manipulations to catch the issue you faced with. Is it possible to add step by step on all your way to add "Similar products" on the product page? Especially the display configuration for product and variation as you use "Rendered entity" display
@jsacksick
We need to create a new order instead of a cart, as the main idea in this issue is to avoid cart creation and go to the checkout step directly
There is a new patch with a check if the user already has the "draft" order for the selected item to avoid duplicates and use existing order for checkout.
Moved parent::postDelete() to the separate issue ->
#3423660
🐛
Invalidate cache on price list delete
Needs review
@jsacksick I've added some small changes in this patch.
- Call
parent::postDelete()for proper cache invalidation - Add "commerce_pricelist_list" cache tag. Even though we invalidate the cached list of the "pricelist" IDs every minute, it is still a minute, and the pricelist could be deleted or dates can be changed
Updated patch to check static cache first
This patch adds results caching for one minute. To enable it add
$settings['commerce_pricelist_query_caching_enabled'] = TRUE;
to your settings.php
Patch with the latest changes in MR 83
Patch based on changes in MR
Here is the patch from the MR changes
This patch changes the "Organization" label to "Company" only for the address field in a Customer profile.
Add fixes to coding style and tests
This patch adds only one setting to the field formatter - "redirect_destination".
The "Destination" field uses #states and will be shown when the "redirect" checkbox is checked.
The default value for the "redirect" checkbox depends on the "redirect_destination" value.
Also, there is a custom validation method to clear "redirect_destination" when the "redirect" checkbox is unchecked.
Here is the patch that provides redirect to cart|checkout in the "Add to cart" field formatter settings.
@jsacksick
I've made changes to rename "Organization" back to "Company" by adding the "#after_build" callback.
jsacksick → credited tBKoT → .
This is the patch without altering the event subscriber. It adds changes to the "Add to cart" form in form_alter. The custom submit handler adds a redirect to the checkout step
Closing it, as still cannot reproduce on clear installation or with Opigno distribution
Patch with test-only changes
Closing it, as still cannot reproduce
Closing this issue as cannot reproduce it.
If there are more details about other contrib modules that were used that may have caused the issue, we can check it again
@patryk-padus
Could you please check if the patch from issue #3173426 helps you? If not please add more details about how we can reproduce this issue
This issue is caused by the incorrect "target_bundles" settings in the attribute field configuration.
The attached patch provides updates for the attribute field manager and adds updates "target_bundles" for already existing fields