- Issue created by @rszrama
- First commit to issue fork.
- last update
6 months ago 786 pass, 2 fail - last update
6 months ago 793 pass - last update
6 months ago 786 pass, 2 fail - last update
6 months ago 793 pass - last update
6 months ago 793 pass - last update
6 months ago 793 pass - 🇮🇱Israel jsacksick
Can you attach a screenshot? Also wondering about Views? No idea if some people override the default list by a view.
- 🇺🇦Ukraine tbkot
Here is the screenshot
We could create a new field and theme for the views because I do not think 'operations' is a good way to add this logic as we do not do anything with variation.
- last update
6 months ago 794 pass - last update
6 months ago 794 pass - 🇷🇸Serbia majmunbog
@tBKoT I think we should not reference variation in CSS, libraries, or data attributes. That way we can reuse this link and styles elsewhere.
- last update
6 months ago 787 pass, 2 fail - last update
6 months ago 794 pass - last update
6 months ago 794 pass - last update
6 months ago 794 pass - last update
6 months ago 794 pass - last update
6 months ago 794 pass - last update
6 months ago 794 pass - Status changed to Needs review
5 months ago 10:40am 10 June 2024 - last update
5 months ago 794 pass - Status changed to Needs work
5 months ago 1:59pm 10 June 2024 - 🇮🇱Israel jsacksick
Works great, 2 comments though: navigator.clipboard.writeText is async, it returns a promise so technically:
The following try catch isn't going to work.
try { const successful = navigator.clipboard.writeText(link); if (!successful) { console.log('Failed to copy link'); } } catch (err) { console.log('Failed to copy link'); }
So we either need to convert the code to look like this:
navigator.clipboard.writeText("This is the text to be copied").then(() => { console.log('Content copied to clipboard'); /* Resolved - text copied to clipboard successfully */ },() => { console.error('Failed to copy'); /* Rejected - text failed to copy to the clipboard */ });
Or create a function and make it async:
async function copyContent() { try { await navigator.clipboard.writeText('This is the text to be copied'); console.log('Content copied to clipboard'); /* Resolved - text copied to clipboard successfully */ } catch (err) { console.error('Failed to copy: ', err); /* Rejected - text failed to copy to the clipboard */ } }
Additionally, there is no visual feedback after successfully copying the text, like on Github (See the attached screenshot):
Let's use the following icon for this: https://icons.getbootstrap.com/icons/check-lg/.
- last update
5 months ago 787 pass, 2 fail - last update
5 months ago 794 pass - last update
5 months ago 794 pass - Status changed to Needs review
5 months ago 5:14pm 10 June 2024 - 🇺🇦Ukraine tbkot
@jsacksick icon now changing if the copy process was successful together with the title attribute. After 2 seconds everything is turning back to the previous state.
- Status changed to Fixed
5 months ago 5:54am 11 June 2024 -
jsacksick →
committed a25e3edd on 3.0.x authored by
tBKoT →
Issue #3444403: Add the 'copy link' icon
-
jsacksick →
committed a25e3edd on 3.0.x authored by
tBKoT →
Automatically closed - issue fixed for 2 weeks with no activity.