This is ready for review, many theme settings have been added.
The merge request at !45 fixes the issue.
Thanks @zaporylie.
This feature will be included in the upcoming release. Theme settings are added.
This is ready for review.
majmunbog → created an issue.
The code has been merged. This issue is now resolved. Thanks everyone for the help and testing!
Code is merged. All seems to work well.
The fix for this issue is now included in
#3542564
✨
Implement blog/article theming with new card type and layout options
Active
.
Please move any testing/review efforts there so we can track everything in one place.
Once that MR is merged, this issue will be closed as a duplicate.
The fix for this issue is now included in
#3542564
✨
Implement blog/article theming with new card type and layout options
Active
.
Please move any testing/review efforts there so we can track everything in one place.
Once that MR is merged, this issue will be closed as a duplicate.
The fix for this issue is now included in
#3542564
✨
Implement blog/article theming with new card type and layout options
Active
.
Please move any testing/review efforts there so we can track everything in one place.
Once that MR is merged, this issue will be closed as a duplicate.
The fix for this issue is now included in
#3542564
✨
Implement blog/article theming with new card type and layout options
Active
.
Please move any testing/review efforts there so we can track everything in one place.
Once that MR is merged, this issue will be closed as a duplicate.
The fix for this issue is now included in
#3542564
✨
Implement blog/article theming with new card type and layout options
Active
.
Please move any testing/review efforts there so we can track everything in one place.
Once that MR is merged, this issue will be closed as a duplicate.
This is ready for review.
- - Created a library for basic pages,
page.basic, where basic body elements and blockquotes are styled. This library can be used to update or override styles for all body or content-driven pages. - - Comments now have a dedicated library definition and are fully themed and styled.
- - Article pages are styled with two new container sizes—very narrow and narrow—to better display content. Both pages are styled to match the designs.
- - Added a reusable date badge class with full styling.
- - Applied badge classes to article tag fields.
- - Created a new card type,
card--basic, themed and styled according to the designs, and applied it to article teasers. - - Added new bust-out mixin to display full-width background color outside the section container.
- - Added CSS variable for footer margin with defaults.
We’ve opened #3542564 ✨ Implement blog/article theming with new card type and layout options Active to implement a full blog listing and article page theming update. This will introduce a change that will address this issue.
The footer will use a CSS variable for margin-top, with a fallback to 5rem.
margin-top: var(--footer-margin-top, 5rem);
Pages like frontpage, layout builder pages and others that do not need spacing between the footer and the content will need to set that variable to zero.
:root {
--footer-margin-top: 0;
}We’ve opened #3542564 ✨ Implement blog/article theming with new card type and layout options Active to implement a full blog listing and article page theming update. Once that’s in place, it should address or replace the need for changes discussed here.
We’ve opened #3542564 ✨ Implement blog/article theming with new card type and layout options Active to implement a full blog listing and article page theming update. This will introduce a new card type and layout options based on the provided designs. Once that’s in place, it should address or replace the need for changes discussed here.
Just a note that #3542564 ✨ Implement blog/article theming with new card type and layout options Active will handle blog/article page theming. Any CKEditor-specific styling (like blockquotes) that fits into those templates can be aligned with that work or followed up separately if needed.
majmunbog → created an issue.
This issue is not relevant in Belgrade 2.x, marking as Outdated.
Since the Tour module is deprecated (see change record) → , marking this as Won’t Fix. No reason for the theme to be updated for compatibility with deprecated modules.
@anirudhsingh19 The warning color is part of our global brand palette, so we shouldn’t change it globally just to meet contrast for this one element. And why change the font weight?
@rkoller We can keep the dot orange, since it’s decorative and not the only indicator (we have bolder text).
For accessibility, we can change the unread text color to black.
Yes, we use the same color as core, but I've switched from loading the background image SVG to an inline SVG encoded as a data URL.
majmunbog → made their first commit to this issue’s fork.
This change works for me. Merging in. Thank you all.
majmunbog → made their first commit to this issue’s fork.
This change makes sense to me. Merging in. Thank you all.
majmunbog → made their first commit to this issue’s fork.
This issue might be a duplicate of #3517847 🐛 TypeError: Drupal\Core\File\FileUrlGenerator::generateString() Active
The button is now consistently styled across all admin themes.
majmunbog → made their first commit to this issue’s fork.
Changing the status to fixed, thanks. I just missed it.
Works perfectly. Thanks for your effort.
I’ve tested the patch, and it works as expected.
The checkout completion page displays the updated UX elements correctly, and I didn’t encounter any issues during testing.
majmunbog → made their first commit to this issue’s fork.
majmunbog → made their first commit to this issue’s fork.
@niki v the code is updated, I've added a utility class to "bold" the labels.
majmunbog → created an issue.
Thanks for testing, @niki v! The issue is currently in review, so the fix isn’t available in the latest release yet. You can test this by cloning git@git.drupal.org:issue/belgrade-3357294.git.
@docevl I’ve opened up an MR to address this issue. Let me know if it works.
majmunbog → made their first commit to this issue’s fork.