majmunbog â made their first commit to this issueâs fork.
I've improved the theme build system by fixing source maps preservation through PostCSS, added a clean script, and split builds into fast dev mode (no linting) and production mode (with linting) for better developer experience.
majmunbog â made their first commit to this issueâs fork.
majmunbog â made their first commit to this issueâs fork.
The template has been adjusted to accommodate the recent changes. Needs review.
majmunbog â made their first commit to this issueâs fork.
No review needed, this issue is already fixed in the 3.x branch in the same way.
Thanks for your work on it!
This is ready for review, many theme settings have been added.
The merge request at !45 fixes the issue.
Thanks @zaporylie.
This feature will be included in the upcoming release. Theme settings are added.
This is ready for review.
majmunbog â created an issue.
The code has been merged. This issue is now resolved. Thanks everyone for the help and testing!
Code is merged. All seems to work well.
The fix for this issue is now included in
#3542564
â¨
Implement blog/article theming with new card type and layout options
Active
.
Please move any testing/review efforts there so we can track everything in one place.
Once that MR is merged, this issue will be closed as a duplicate.
The fix for this issue is now included in
#3542564
â¨
Implement blog/article theming with new card type and layout options
Active
.
Please move any testing/review efforts there so we can track everything in one place.
Once that MR is merged, this issue will be closed as a duplicate.
The fix for this issue is now included in
#3542564
â¨
Implement blog/article theming with new card type and layout options
Active
.
Please move any testing/review efforts there so we can track everything in one place.
Once that MR is merged, this issue will be closed as a duplicate.
The fix for this issue is now included in
#3542564
â¨
Implement blog/article theming with new card type and layout options
Active
.
Please move any testing/review efforts there so we can track everything in one place.
Once that MR is merged, this issue will be closed as a duplicate.
The fix for this issue is now included in
#3542564
â¨
Implement blog/article theming with new card type and layout options
Active
.
Please move any testing/review efforts there so we can track everything in one place.
Once that MR is merged, this issue will be closed as a duplicate.
This is ready for review.
- - Created a library for basic pages,
page.basic, where basic body elements and blockquotes are styled. This library can be used to update or override styles for all body or content-driven pages. - - Comments now have a dedicated library definition and are fully themed and styled.
- - Article pages are styled with two new container sizesâvery narrow and narrowâto better display content. Both pages are styled to match the designs.
- - Added a reusable date badge class with full styling.
- - Applied badge classes to article tag fields.
- - Created a new card type,
card--basic, themed and styled according to the designs, and applied it to article teasers. - - Added new bust-out mixin to display full-width background color outside the section container.
- - Added CSS variable for footer margin with defaults.
Weâve opened #3542564 ⨠Implement blog/article theming with new card type and layout options Active to implement a full blog listing and article page theming update. This will introduce a change that will address this issue.
The footer will use a CSS variable for margin-top, with a fallback to 5rem.
margin-top: var(--footer-margin-top, 5rem);
Pages like frontpage, layout builder pages and others that do not need spacing between the footer and the content will need to set that variable to zero.
:root {
--footer-margin-top: 0;
}Weâve opened #3542564 ⨠Implement blog/article theming with new card type and layout options Active to implement a full blog listing and article page theming update. Once thatâs in place, it should address or replace the need for changes discussed here.
Weâve opened #3542564 ⨠Implement blog/article theming with new card type and layout options Active to implement a full blog listing and article page theming update. This will introduce a new card type and layout options based on the provided designs. Once thatâs in place, it should address or replace the need for changes discussed here.
Just a note that #3542564 ⨠Implement blog/article theming with new card type and layout options Active will handle blog/article page theming. Any CKEditor-specific styling (like blockquotes) that fits into those templates can be aligned with that work or followed up separately if needed.
majmunbog â created an issue.
This issue is not relevant in Belgrade 2.x, marking as Outdated.
Since the Tour module is deprecated (see change record) â , marking this as Wonât Fix. No reason for the theme to be updated for compatibility with deprecated modules.
@anirudhsingh19 The warning color is part of our global brand palette, so we shouldnât change it globally just to meet contrast for this one element. And why change the font weight?
@rkoller We can keep the dot orange, since itâs decorative and not the only indicator (we have bolder text).
For accessibility, we can change the unread text color to black.
Yes, we use the same color as core, but I've switched from loading the background image SVG to an inline SVG encoded as a data URL.
majmunbog â made their first commit to this issueâs fork.
This change works for me. Merging in. Thank you all.
majmunbog â made their first commit to this issueâs fork.