- 🇮🇪Ireland frankdesign
Thanks for the patch. Problem for me though is that I am using a sub-theme of Claro, so my class names with your patch are "claro-sub-details" rather than "claro-details" etc... Is there any way to use the Claro theme name as per classes on all other ?
F
- Assigned to nicolasgraph
- Status changed to Needs work
10 months ago 3:46pm 5 February 2024 - 🇫🇷France nicolasgraph Strasbourg
It is missing some more markup and the current theme name is not passed to commerce-order--admin.html.twig.
- Issue was unassigned.
- Status changed to Needs review
10 months ago 3:57pm 5 February 2024 - last update
10 months ago 791 pass - last update
10 months ago 784 pass, 2 fail - 🇫🇷France nicolasgraph Strasbourg
Using the current theme is actually not a good idea as Gin use the claro classes.
- 🇫🇷France nicolasgraph Strasbourg
Here are some screenshots without the patch using, and with the patch using Claro and Gin.
- last update
10 months ago 791 pass - 🇫🇷France nicolasgraph Strasbourg
Here is a try to get some more enhancements to the order layout.
- Status changed to Needs work
6 months ago 12:30pm 23 May 2024 - 🇮🇱Israel jsacksick
The patch should be updated following the layout changes introduced in 2.39 and subsequently in dev.
So I wonder if we should be hardcoding Claro, and then experience the same issue later, or hardcode claro + another class name that includes the current theme name... - First commit to issue fork.
- Merge request !264Issue #3204355: Commerce order admin template <details> broken styling → (Merged) created by majmunbog
- last update
6 months ago 794 pass -
jsacksick →
committed cfc56af6 on 8.x-2.x authored by
majmunbog →
Issue #3204355: Commerce order admin template <details> broken styling
-
jsacksick →
committed cfc56af6 on 8.x-2.x authored by
majmunbog →
-
jsacksick →
committed bf5f77dd on 3.0.x authored by
majmunbog →
Issue #3204355: Commerce order admin template <details> broken styling
-
jsacksick →
committed bf5f77dd on 3.0.x authored by
majmunbog →
- Status changed to Fixed
6 months ago 11:44am 27 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.