nicolasgraph → created an issue.
Error described in #17 may be caused by a server error we fixed ; last orders were placed with no error.
I keep an eye on this to fix or merge asap.
We get the following error on return:
Drupal\commerce_payment\Exception\PaymentGatewayException: Request body is not valid JSON. in Drupal\commerce_payplug\Plugin\Commerce\PaymentGateway\OffsitePayPlug->onReturn() (line 173 of /home/ernestpr/web/www/web/modules/contrib/commerce_payplug/src/Plugin/Commerce/PaymentGateway/OffsitePayPlug.php).
Indeed, the payload was empty for this payment return.
I guess we need to retrieve the remote payment to truly validate its status on return, as done in the Magento module.
This mean we need to create the payment entity early, from the remote payment creation response, to store the remote ID to request later on.
nicolasgraph → created an issue.
Let's merge this to go forward.
Opening a dedicated issue for the last tricky phpstan error.
The current MR still requires attention for this last phpstan error:
------ --------------------------------------------------------------------------
Line tests/modules/commerce_payplug_tests/src/Services/PayPlugTestService.php
------ --------------------------------------------------------------------------
94 \Drupal calls should be avoided in classes, use dependency
injection instead
------ --------------------------------------------------------------------------
I just rerolled the MR into a new branch.
It still requires attention for this last phpstan error:
------ --------------------------------------------------------------------------
Line tests/modules/commerce_payplug_tests/src/Services/PayPlugTestService.php
------ --------------------------------------------------------------------------
94 \Drupal calls should be avoided in classes, use dependency
injection instead
------ --------------------------------------------------------------------------
nicolasgraph → changed the visibility of the branch 3519229-fix-coding-standards to hidden.
nicolasgraph → changed the visibility of the branch 3345993-add-refund-tests to hidden.
Adding refund tests.
nicolasgraph → changed the visibility of the branch 1.x to hidden.
Ok, I guess it is related to the way PaymentGatewayBase is now instanciated in Commerce 3, using create() with no constructor.
Not sure we should support Commerce 2 AND 3.
This does not ensure a full Commerce 3 compatibility.
See
Tests failing with Drupal 11 /Commerce 3
🐛
Tests failing with Drupal 11 /Commerce 3
Active
.
nicolasgraph → created an issue.
nicolasgraph → created an issue.
Weird, upgrade_status does not complain; the module should be D11 ready.
Let's merge this tiny enhancement anyway.
nicolasgraph → made their first commit to this issue’s fork.
nicolasgraph → created an issue.
nicolasgraph → created an issue.
nicolasgraph → created an issue.
nicolasgraph → created an issue.
This should be enough.
nicolasgraph → created an issue. See original summary → .
nicolasgraph → created an issue. See original summary → .
Tests in progress in #3345993 📌 Add tests Active do not complain anymore, let's merge this.
My mistake : this issue is not part of the branch 1.x. It was introduced and will be resolved in #3345993 📌 Add tests Active .
nicolasgraph → created an issue.
nicolasgraph → created an issue.
CronTest.php tests that payments to update are enqueued ; the queue processing still needs to be tested.
This is now tested in #3345993 📌 Add tests Active .
nicolasgraph → created an issue.
Tests in #3345993 📌 Add tests Active validates this.
This is tested in #3345993 📌 Add tests Active .
Needs #3524943 🐛 Missing schema key Active to land.
nicolasgraph → created an issue.
Needs #3524911 🐛 Catch remote payment fetching exception Active + #3524908 🐛 Fixes OffsitePaymentGatewayInterface implementation Active to land.
nicolasgraph → created an issue.
nicolasgraph → created an issue.