nicolasgraph → created an issue.
nicolasgraph → created an issue.
Extends OrderItemSkuKernelTestBase in test once
#3503345
📌
Explore different ways/moments to set the SKU
Active
is merged.
I reopen this issue to add a setting allowing to use a custom storing strategy.
nicolasgraph → created an issue.
Let's add tests later on and continue with #3505136 ✨ Sync order item SKU on purchased entity update Active .
nicolasgraph → created an issue.
On purchasable entity deletion the SKU storage should be managed via a queue.
I made a mistake in attributes ; fixing that…
This issue try to fix the Commerce 3 compatibility only.
Some more work may be needed to support D11.
nicolasgraph → created an issue.
nicolasgraph → created an issue.
I just created a light contrib module for this feature here → . I would just like to ensure that using "sku" as the trait field is ok ? I wouldn't like to conflict with a future implementation of this field.
An approach to this issue could be to introduce an entity trait for order items to choose to store the SKU if needed + a dedicated order processor. It is what I use for now ; I can help with a patch or a light contrib module.
Commited, thanks!
The balance is not related to the placed order status, it is related to the amount actually defined as paid by Alma. If no payment have already been processed for an order, the balance is 0. However, a queue worker should update the payments balance/status during the cron. Please check your logs and remote payments status or provide more informations to help me reproduce the bug.
Committed, thanks!
Patch #5 won't apply, it is an interdiff.
I created a MR from patch #4 including the suggested change of the interdiff.
@grevil, not sure which of your MR is the one you're woking on but I think you should keep the change I made to ReportsListBuilder.php in the MR#18. See #3342975 📌 Deprecate Url::toRenderArray() and Url::renderAccess() Fixed + #3406432 📌 Remove calls of deprecated toRenderArray() method Fixed .
Thank you all!
Thank you @guillaume-samtmann ; I think we could add an information message to the settings form if key is not installed to suggest its use.
Thanks @valthebald for this MR!
I pushed and revert a commit in favour of this comments:
- In ai_translate.install, is
ai_translate_requirements()still required? I guess not. - In ai_translate.module,
_ai_translate_check_default_provider_and_model()seems also outdated to me. - In AiTranslateForm.php, line 114,
$default_model = $this->providerManager->getSimpleDefaultProviderOptions('chat');should not use the chat provider type anymore.
nicolasgraph → made their first commit to this issue’s fork.
Closing in favour of #3478721 📌 Discuss: Unify translate operations over ai Active which does fix this issue and adds many other improvements.
nicolasgraph → created an issue.
\Drupal call removed, local tests succeeded.
By pass review for this task.
nicolasgraph → created an issue.
The \Drupal call in the Cron class is documented as required. Tests are needed before to correct it.
nicolasgraph → created an issue.
nicolasgraph → created an issue.
nicolasgraph → created an issue.
Unwanted changes reverted and names added for width, length and height.
It's ok for me, I'll implement this hook ; we can revert my changes and explore manipulating the generated JSON-LD to extract the value from 'size' in the more specific properties later if needed.
Your approach makes sense. However, in the Commerce Shipping → case, a shippable product variation will have a dimension field, AND it could also have an attribute field for the size which could be XL for example. Do your think that this particular case should be handled by schemadotorg_commerce → ?
nicolasgraph → created an issue.
Change merged, not sure if you want to change the issue status back to needs review or needs work to add a few more tests.
nicolasgraph → changed the visibility of the branch 3479145-adds-physical-support-dimensions-extended to hidden.
Just in case @jrockowitz, I've created a new branch with one addtional commit to allow physical_dimensions to populate depth, height and width properties. It still need tests and can be added to a new dedicated MR. What do you think?
Review process succeeded; thanks for your additional improvements!
Thanks for restablishing the D10 support @Valic!
What is the point of not supporting D10 anymore?
What is the upgrade path if there is no version supporting D10 and D11?
We need to composer rem and then composer req, or tweak the composer.json to accept both version?
It seems not ideal.
I'll check my EditorConfig @jrockowitz ; thanks !
I took a look at tests but I wasn't able to fix them for now.
I need to switch to another project for now ; I'll be back asap !
While schemadotorg_physical seems to work on my install with the Person node type, tests still need work.
nicolasgraph → created an issue.
nicolasgraph → created an issue.
nicolasgraph → created an issue. See original summary → .
Let's post Commerce related issues in the Schema.org Blueprints Commerce → issue queue now.
I'll try to help make it → happen.
I can't see how this was tested; commerce_coupon_conditions requires Commerce ^2.28 but Commerce introduced D11 support from 3.0 only. I guess this should be updated to the needs work status.
After pulling 3.2.x in the MR ; there is not much to change !
upgrade_status is already happy
nicolasgraph → changed the visibility of the branch renderInIsolation to hidden.
nicolasgraph → made their first commit to this issue’s fork.
Adding #3173773 💬 Error: Call to a member function isNew() on null in Drupal\Core\Entity\Plugin\Validation\Constraint\ValidReferenceConstraintValidator->validate() Closed: outdated as related issue.
3455209-manual-drupal-11 branch should be ready to go ; needs review.
nicolasgraph → made their first commit to this issue’s fork.
The test failure seems not related to the current issue ; updating the status to needs review for branch 3428485-manual-drupal-11.
nicolasgraph → made their first commit to this issue’s fork.
Updating the issue to clarify the actual work in progress.
nicolasgraph → created an issue.
A new setting was added to the handler to set an optional callerid request parameter from a webform element value. The buildRequestParams method was introduced to easily compute request parameters.
nicolasgraph → created an issue.