- Issue created by @nicolasgraph
- Status changed to Needs work
28 days ago 1:37pm 16 June 2025 - 🇫🇷France nicolasgraph Strasbourg
nicolasgraph → changed the visibility of the branch 3519229-fix-coding-standards to hidden.
- 🇫🇷France nicolasgraph Strasbourg
I just rerolled the MR into a new branch.
It still requires attention for this last phpstan error:------ -------------------------------------------------------------------------- Line tests/modules/commerce_payplug_tests/src/Services/PayPlugTestService.php ------ -------------------------------------------------------------------------- 94 \Drupal calls should be avoided in classes, use dependency injection instead ------ --------------------------------------------------------------------------
- 🇫🇷France nicolasgraph Strasbourg
The current MR still requires attention for this last phpstan error:
------ -------------------------------------------------------------------------- Line tests/modules/commerce_payplug_tests/src/Services/PayPlugTestService.php ------ -------------------------------------------------------------------------- 94 \Drupal calls should be avoided in classes, use dependency injection instead ------ --------------------------------------------------------------------------
-
nicolasgraph →
committed c7a204c4 on 5.x
Issue #3519229 by nicolasgraph: Fix coding standards
-
nicolasgraph →
committed c7a204c4 on 5.x
- 🇫🇷France nicolasgraph Strasbourg
Let's merge this to go forward.
Opening a dedicated issue for the last tricky phpstan error.