Order placed on payment failure

This would need tests.
Waiting #3515036 📌 Fix tests Active to be fixed.

Manual tests failed. The order is still placed.

nicolasgraph → changed the visibility of the branch 4.x to hidden.

Ok, I get it, in my failing manual test case, onNotify() is not called, the payment is managed through onReturn() which do... nothing.
While the payment entity creation can be managed onNotify() only, the remote payment validation must be processed onReturn() too to throw the DeclineException in case of failure.

nicolasgraph → closed merge request !3

I confirm the current MR state do fix my issue in live mode.
Still needs attention and ideally, some tests.

I have added a 5.x branch with Commerce 3.x support on Drupal 11 and also updating the underneath Payplug library to the latest (3.6.0). There may be something fixed on there side for this.

I created a brand new Commerce Kickstart env with Commerce Payplug on Commerce 3.x and tried the basics: anonymous cart payment both with a valid Visa card and a failing DS MasterCard and both scenarios worked as expected (I was blocked at offsite payment gate using the mastercard)

Test cards available here: https://docs.payplug.com/api/apiref.html#api-testing

Could you have a new try with those updates and let me know how to reproduce otherwise ?

Thanks for your reply @dom.
Unfortunatly I was not able to reproduce the bug in test mode.
In test mode, I'm not redirected to the site on payment failure, while in live mode I am.
The 5.x branch do not fix the issue bescause onReturn() is still empty and that's the method called when Payplug redirect to the site in my case.
Also I didn't try the v3 but I suspect #3295358 💬 Payments which are not completed, still complete the order. Closed: cannot reproduce to be a duplicate.

Merging 5.x introduced errors ; waiting #3428466 📌 Automated Drupal 11 compatibility fixes for commerce_payplug Needs review to land before to continue.