Account created on 7 May 2010, over 14 years ago
  • Freelance Drupal Dev at ACINO 
#

Recent comments

🇫🇷France Dom.

I have mixed feeling with that one.
On the first place, having DOMPurify a hard requirement is a good thing from security purpose, on the other end, it is not strictly required.
I will unblock a user with no DOMPurify at the moment, but still expect it in the library loading so it pops as an error in console.

🇫🇷France Dom.

Correct !
As a follow-up for D10.3+ I will however move from Annotation to Attributes:
https://www.drupal.org/node/3229001

🇫🇷France Dom.

Thanks a lot for help and contribution.
I have not been able to reproduce a non-working scenario that would be fixed with the suggested change. Could you please expand on how to test this ?

🇫🇷France Dom.

Metatag was not supported on 8.x, please refer to #2501637: [META] D8 port: Roadmap and Feature Request

The point is that metatag is now a field on the entity that can display many other sub-configurations.
I added minimal support for metatag (although i don't see the point). Now it could be made better by hide/show individually each metatag configuration I suppose, but that is another story.

🇫🇷France Dom.

I had a bit of trouble with merging due to conflicts, but should be done properly with appropriate credits to you.
Thanks a lot for help

🇫🇷France Dom.

I added support for removing the thin unbreakable that might be within the content (just as  ) and add narrow unbreakable space before/after a list of configurable characters.

🇫🇷France Dom.

Thanks a lot for your contribution, fix and test

🇫🇷France Dom.

Oh, totally down to my fault.

I received an automatic email from drupal.org with a list of modules of mine that still have releases for deprecated Drupal version.
So... I clean it out. Everything below Drupal 9 (did I thought) since the rest is EOL right ? Well.. not D7 that got extended lately.

But because of the ticket issue I mentioned, once a branch for D7 is removed from support list, you cannot undo it anymore (since August 1st apparently ).
This used to be a reversible operation so I did minded too much and so there is no warning message.

(Now that I mention it, actually that could be worth addressing on that parent issue that a confirmation message could be added)

🇫🇷France Dom.

I had to create a whole new branch because of this:
[D7EOL] - Do not allow Drupal 7 branches of projects to be re-supported after Aug 1st Fixed

That might be confusing now to users though since due to the release date it will sound like 7.x is still supported which is not the case.

🇫🇷France Dom.

@agoradesign yes I have upgraded to Drupal 10.1, hence use this module 6.x branch.
The issue you are pointing at seems to indicate that this module has became useless with Drupal 10.1, is that right ?

🇫🇷France Dom.

I had multiple issues with JS aggregation after upgrading my website from 9.5 to 10.1.
Changing advagg minification method from JSqueeze to another just solves them all.

🇫🇷France Dom.

Masonry is indeed a hard library to get working properly, so encapsulate it in a Drupal module above is even harder.
Please feel free to help make that easier, any idea is welcomed.
maybe related: 📌 Improve easyness of configurations Active

🇫🇷France Dom.

That is definitely something worth supporting indeed :)
Anyone up for creating a patch ?

🇫🇷France Dom.

RTBC for patch at #6.
Also, to get this to work, don't forget to activate the "-coalesce" option in the advanced settings (not really sure why this is not activated by default in the module?)

🇫🇷France Dom.

If you run /update.php, you should have got a warning telling to check your configuration.
On after1.jpg I can see the sizes for columns does not follow the "description" below.
If you save those settings, it should triger an "error" on the setting form because "250" on the column width do not have a unit.

🇫🇷France Dom.

Version 7.x is no more really supported. Just provided as is until end-of-life.
Feel free to reopen and update if there are reason we should still invest work on this.

🇫🇷France Dom.

Version 7.x is no more really supported. Just provided as is until end-of-life.
Feel free to reopen and update if there are reason we should still invest work on this.

🇫🇷France Dom.

Version 7.x is no more really supported. Just provided as is until end-of-life.
Feel free to reopen and update if there are reason we should still invest work on this.

🇫🇷France Dom.

Version 7.x is no more really supported. Just provided as is until end-of-life.
Feel free to reopen and update if there are reason we should still invest work on this.

🇫🇷France Dom.

Version 7.x is no more really supported. Just provided as is until end-of-life.
Feel free to reopen and update if there are reason we should still invest work on this.

🇫🇷France Dom.

Version 7.x is no more really supported. Just provided as is until end-of-life.
Feel free to reopen and update if there are reason we should still invest work on this.

🇫🇷France Dom.

Version 7.x is no more really supported. Just provided as is until end-of-life.
Feel free to reopen and update if there are reason we should still invest work on this.

🇫🇷France Dom.

Version 7.x is no more really supported. Just provided as is until end-of-life.
Feel free to reopen and update if there are reason we should still invest work on this.

🇫🇷France Dom.

Version 7.x is no more really supported. Just provided as is until end-of-life.
Feel free to reopen and update if there are reason we should still invest work on this.

🇫🇷France Dom.

Version 7.x is no more really supported. Just provided as is until end-of-life.
Feel free to reopen and update if there are reason we should still invest work on this.

🇫🇷France Dom.

Version 7.x is no more really supported. Just provided as is until end-of-life.
Feel free to reopen and update if there are reason we should still invest work on this.

🇫🇷France Dom.

Version 7.x is no more really supported. Just provided as is until end-of-life.
Feel free to reopen and update if there are reason we should still invest work on this.

🇫🇷France Dom.

Version 7.x is no more really supported. Just provided as is until end-of-life.
Feel free to reopen and update if there are reason we should still invest work on this.

🇫🇷France Dom.

Version 7.x is no more really supported. Just provided as is until end-of-life.
Feel free to reopen and update if there are reason we should still invest work on this.

🇫🇷France Dom.

Version 7.x is no more really supported. Just provided as is until end-of-life.
Feel free to reopen and update if there are reason we should still invest work on this.

🇫🇷France Dom.

Version 7.x is no more really supported. Just provided as is until end-of-life.
Feel free to reopen and update if there are reason we should still invest work on this.

🇫🇷France Dom.

Version 7.x is no more really supported. Just provided as is until end-of-life.
Feel free to reopen and update if there are reason we should still invest work on this.

🇫🇷France Dom.

Could you eventually get me a screenshot of your view settings and of the result, since I don't really figure out the result you have here.

The configurations now requires explicitely the unit for columns for instance.
Also by default, there is a new option (not the last one, just before) to force elements widh to column size.

🇫🇷France Dom.

Actually you can:
Anywhere you want, just add the syntax needed:
Here is a [rotate]simple|easy|cute[/rotate] way to rotate text

Could be on a page, could be on a view, anywhere.

Then, you will need to add the library and configuration to that specific page using hook_page_attachments():

function mymodule_page_attachments(array &$attachments) {
     // Check if the page if the one you need from the $request
     [...]
  
     // Attach the library.
     $attachments['#attached']['library'][] = 'text_rotator_filter/text_rotator_filter';
     // Add the configurations.
     $attachments['#attached']['drupalSettings']['text_rotator_filter'] => [
          'animation' => 'dissolve',
          'speed' => 350,
     ];
}
🇫🇷France Dom.

Sorry, you where right about compatibility because of jquery/once library change.

🇫🇷France Dom.

Dom. made their first commit to this issue’s fork.

🇫🇷France Dom.

commited to 2.x with you credited
Thanks for help, 2.0.0 release is coming up.

🇫🇷France Dom.
+++ b/composer.json
@@ -5,6 +5,7 @@
+        "drupal/core": "^9.2.0 || ^10",

drupal/core should not be a dependency here as it is not made to be used externaly. The "type" is already defined to drupal-module.
see https://www.drupal.org/docs/develop/creating-modules/add-a-composerjson-...
Also the dependency is here 9.2+ while the module is declared to support D8+ according to info.yml file.

+++ b/w3c_validator.info.yml
@@ -1,7 +1,6 @@
+core_version_requirement: ^9 || ^10

why is this twice in the patch file ?
also why removing the support of D8?

+++ b/composer.json
@@ -5,6 +5,7 @@
         "rexxars/html-validator": "^2.2.0"

Let's also update this to the latest 2.3.0

🇫🇷France Dom.

Stupid me, I forget to actually create the 4.0 release on drupal.org !!
Let me do this at the moment... et voilà ! That should be good now :)
Could you have a try and let me know ?
I'm so sorry, to much party at #DrupalDevDays Vienna !

🇫🇷France Dom.

Should be fixed by the usage of 4.x, which should therefore simplify that.

🇫🇷France Dom.

Crediting. Thanks for patch :)

🇫🇷France Dom.

After I updated masonry API to 4.x (configuration change), the purpose is now to make this module compatible with the newest version.

🇫🇷France Dom.

Somehow, I think this is already fixed in the latest 2.x version. Won't release a new 8.x-1.x version.

🇫🇷France Dom.

Somehow, I think this is already fixed in the latest 2.x version. Won't release a new 8.x-1.x version.

🇫🇷France Dom.

Perfect, thanks a lot for this correction :)

🇫🇷France Dom.

Add a fix for standard autocompletion when no 'group' are provided.

Production build 0.71.5 2024