- Issue created by @ptmkenny
- @ptmkenny opened merge request.
- Status changed to Needs review
over 1 year ago 9:59am 17 February 2023 - 🇯🇵Japan ptmkenny
It seems that this is as simple as adding 10 to the compatible version list. I scanned the module with Coder on a Drupal 10 site and there are some PHPstan fixes for Drupal 11, but nothing flagged for D10 compatibility.
I also verified that the basic functionality is working with the MR.
- 🇯🇵Japan ptmkenny
Actually, jquery/once also needed to be replaced with core/once. I now have the module successfully working on D10.
- 🇯🇵Japan ptmkenny
Because jquery once was removed in 9.2 → , if this module updates the script, it will need to require 9.2/10 instead of allowing for use with 8/9/10.
- 🇧🇷Brazil murilohp
Uploading an static patch here since we cannot pin the MR and be able to use it.
- 🇫🇷France Dom.
+++ b/composer.json @@ -5,6 +5,7 @@ + "drupal/core": "^9.2.0 || ^10",
drupal/core should not be a dependency here as it is not made to be used externaly. The "type" is already defined to drupal-module.
see https://www.drupal.org/docs/develop/creating-modules/add-a-composerjson-... →
Also the dependency is here 9.2+ while the module is declared to support D8+ according to info.yml file.+++ b/w3c_validator.info.yml @@ -1,7 +1,6 @@ +core_version_requirement: ^9 || ^10
why is this twice in the patch file ?
also why removing the support of D8?+++ b/composer.json @@ -5,6 +5,7 @@ "rexxars/html-validator": "^2.2.0"
Let's also update this to the latest 2.3.0
- Status changed to Fixed
over 1 year ago 9:58am 22 July 2023 - 🇫🇷France Dom.
commited to 2.x with you credited
Thanks for help, 2.0.0 release is coming up. - 🇫🇷France Dom.
Sorry, you where right about compatibility because of jquery/once library change.
Automatically closed - issue fixed for 2 weeks with no activity.