- 🇫🇷France Dom.
RTBC for patch at #6.
Also, to get this to work, don't forget to activate the "-coalesce" option in the advanced settings (not really sure why this is not activated by default in the module?) - Status changed to Needs work
over 1 year ago 9:44am 30 July 2023 - 🇮🇹Italy mondrake 🇮🇹
I do not think this is the right way to address this. It would introduce a behaviour change vs current state where only the first frame is converted for animated GIFs. We might argue whether the current state is the right one or not, but no matter what we cannot simply change the behaviour like this.
I'd rather go a path similar to #2786435: Support '-coalesce' of Animated GIF image files → where a configuration setting was introduced for the purpose. So each site owner to decide.
We also need tests.
- Status changed to Needs review
over 1 year ago 12:36am 29 August 2023 - last update
over 1 year ago 30 pass - 🇺🇦Ukraine vredko
thanks @internetter but patch#6 doesn't work for me.
i've created new patch. also checking "-coalesce" option which can be apply to gif and webp destination format. - First commit to issue fork.
- Merge request !49Draft: Close #3295470 Enable advanced.coalesce setting for webp as well. → (Open) created by trackleft2
- Merge request !50Close #3295470 Enable advanced.coalesce setting for webp as well. → (Open) created by trackleft2
- 🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
trackleft2 → changed the visibility of the branch 3295470-convert-image-style-cannot to hidden.
- 🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
The patch from #10 works for me, I've create a merge request with the patch so we can continue work on this.
Changing to Needs work, because the maintainer said this needs tests. - 🇺🇸United States joegraduate Arizona, USA
Manually triggered the "tests only" pipeline on the MR and saw that the new test added passes even without the other MR changes which I don't think is the expected result.
Spoke to @trackleft2 about this on Slack and he mentioned that he thinks he needs to add something to the test that verifies the generated file is still actually a multiframe image.