- Issue created by @jannakha
- Assigned to shailja179
- Status changed to Needs work
over 1 year ago 7:21am 19 June 2023 - Status changed to Needs review
over 1 year ago 9:29am 19 June 2023 - Issue was unassigned.
- Status changed to Needs work
over 1 year ago 1:59pm 26 June 2023 - 🇦🇺Australia jannakha Brisbane!
The patch worked as expected.
Please fix coding standards (whitespace issues):
Install phpcs: https://www.drupal.org/node/1419988 →
Issues:
FILE: /Users/xxx/work/yyy/web/modules/contrib/simplify/simplify.module ------------------------------------------------------------------------------------------------------ FOUND 3 ERRORS AFFECTING 3 LINES ------------------------------------------------------------------------------------------------------ 577 | ERROR | [x] Whitespace found at end of line 581 | ERROR | [x] Whitespace found at end of line 671 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, | | found "_is_user_admin" but expected "simplify__is_user_admin" ------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------
- Status changed to Needs review
over 1 year ago 6:03am 27 June 2023 - Status changed to RTBC
over 1 year ago 10:47am 27 June 2023 - 🇦🇺Australia jannakha Brisbane!
it works! and passes phpcs!
great job! thanks for the patch! - Status changed to Fixed
over 1 year ago 12:15pm 22 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.