Drupal 10.3 compatibility

Created on 9 July 2024, 9 months ago

Problem/Motivation

Up to Drupal 10.2.7 all is fine with nbsp_filter module.
Starting with 10.3.0, any text format using CKEditor 5 can't be saved if the nbsp_filter module is enabled.

The following errors are triggered when trying to save the text format:

  • 'clean_all' is not a supported key.
  • 'insert_before' is not a supported key.
  • 'insert_after' is not a supported key.

Steps to reproduce

There no need for the filter itself to be enabled in the text format, just install and enable the module and try to save any text format using CKEditor 5.

πŸ› Bug report
Status

Active

Version

1.0

Component

Code

Created by

πŸ‡«πŸ‡·France PhilY πŸ‡ͺπŸ‡ΊπŸ‡«πŸ‡· Paris, France

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @PhilY
  • πŸ‡«πŸ‡·France Jejddx

    Same problem. Because of missing schema.

    Apply the patch, clear the caches and use filter as usual.

  • πŸ‡«πŸ‡·France steveoriol Grenoble πŸ‡«πŸ‡·

    even if the patch corrects the errors,
    it doesn't apply without error for me and it creates extra useless folders and files, weird.

    ❯ tree web/modules/contrib/nbsp_filter/
     web/modules/contrib/nbsp_filter/
     β”œβ”€β”€ b
     β”‚   └── config
     β”‚       └── schema
     β”‚           └── nbsp_filter.schema.yml
     β”œβ”€β”€ config
     β”‚   └── schema
     β”‚       └── nbsp_filter.schema.yml
     β”œβ”€β”€ LICENSE.txt
     β”œβ”€β”€ nbsp_filter.info.yml
     β”œβ”€β”€ nbsp_filter.module
     β”œβ”€β”€ README.txt
     β”œβ”€β”€ schema
     β”‚   └── nbsp_filter.schema.yml
     └── src
         └── Plugin
             └── Filter
                 β”œβ”€β”€ NbspFilter.php
                 └── NbspFilter.php.rej
    
  • πŸ‡«πŸ‡·France PhilY πŸ‡ͺπŸ‡ΊπŸ‡«πŸ‡· Paris, France

    Patch at #2 has 2 actions: fixing the missing schema.yml file and modifing the NbspFilter.php file.
    The weird extra folders might come from that second part of the patch where deleted commented lines are replaced by non commented lines.
    Anyway, it might better to split these fixes in two issues and keep the missing schema fix in this one.
    So, here is an updated patch fixing the missing file only, credits go to Jejddx.

  • πŸ‡«πŸ‡·France PhilY πŸ‡ͺπŸ‡ΊπŸ‡«πŸ‡· Paris, France

    Renamed patch file for naming consistency.

  • πŸ‡«πŸ‡·France PhilY πŸ‡ͺπŸ‡ΊπŸ‡«πŸ‡· Paris, France
  • Status changed to RTBC 9 months ago
  • πŸ‡«πŸ‡·France steveoriol Grenoble πŸ‡«πŸ‡·

    "nbsp_filter-10.3_incompatibility-3460328-5.patch" works well, Thanks :-)

  • πŸ‡«πŸ‡·France Quentin Harelle

    "nbsp_filter-10.3_incompatibility-3460328-5.patch" tested as well and fixes the issue !

    Thanks :)

  • Status changed to Fixed 6 months ago
  • πŸ‡«πŸ‡·France Dom.
    • dom. β†’ committed da0343e8 on 1.0.x
      Issue #3460328 by phily, jejddx, steveoriol, sillot: Drupal 10.3...
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024