🇫🇷France @Quentin Harelle

I saw the installing lines and thank you for providing it. But I am sorry I am still having issues installing your suite of modules ...

After the ddev composer require drupal/layout_options drupal/ui_styles drupal/ui_suite_uswds; I have this issue :
Unable to install modules: module 'ui_icons_patterns'. Its dependency module 'ui_icons' is incompatible with this version of Drupal core.

I'm using minimal alpha version in composer requirements and I am with Drupal 10.3.11 as you said in you first comment. I also tried other stuff to make it work but ui_icons is still the issue.

I'm missing something in your dependencies here.

I could only install drupal/ui_suite_uswds:^3.0@alpha with a fresh D10 install.
Once this ok I had this issue : Unable to install modules layout_options, ui_icons_patterns due to missing modules ui_icons_patterns.

Can you provide all the dependencies needed to make this work please ?

Will be shipped with the 1.0.9 fix version.

I made a patch that seems to fix this issue.

The issue was that some component.yml files might not have examples, which I use in $this->versions and $currentVersion. In that case I just needed to send an empty array to display the component without adding examples values in it.

Can you tell me if it's okay for you ?

In this context $version is an array with the props recovered from the component.yml file.

I'm investigating this bug, I'll get back to you.

Great ! Thank you for the report and the test afterward !

I tag the issue as fixed.

Hi elgandoz,

Sorry for the very long response time ...

I looked into it, and I was not working with the slots at all ...

If you still have the issue you can test it with the patch that I provide you and this working example to put in a component.yml file :

slots:
  test:
    description: 'The title content.'
    examples:
      - '<p>Title content</p>'
      - '<p>Another title <span>content</span></p><ul><li>Item 1</li><li>Item 2</li></ul>'

And in a twig file :

  {% block test %}
    {{ test }}
  {% endblock %}

Theses examples will be converted into Markup and can then be printed into the twig template.

Hi jcandan,
Sorry for the response time, and thank you for reporting this.

I made a fix and a new release with the fix (1.0.7).

I took your suggestion using the Html utility class but with getId(), I thought it was better suited.

Tell me if it solves the bug.

I added the provider validation in the MR.
Here is the patch as well.

I made the fix in a merge request, but here is the patch for those that would need this.

sillot → created an issue.

Hi @vishal.kadam,

Thanks for your review ! I made the changes your requested.

Hi @avpaderno and thanks for the review !

I fixed what you listed in your comment on 1.x branch.

sillot → created an issue.

Hi,

I made a patch because I ran into the same issue.

I added a fallback thumbnail path to the audio.png file.

Tell me if it solve your issue.

"nbsp_filter-10.3_incompatibility-3460328-5.patch" tested as well and fixes the issue !

Thanks :)

sillot → created an issue.

At the moment I did not try to use slots in the .components.yml for the moment, but you should be able to access the data in your component anyway in theory.

I'll try to look into it when I'll have the time.

Ok I understand, I had a use case for this: I reuse a specific node and need to have it's publication date updated, so the reset to 0 is necessary.

What would you advise for this use case ?

sillot → created an issue.

Rate your excitement about SDC in core: 1 ... 10 | N/A

10. It is finally a viable option for atomic design building in the Drupal way. The fact that SDC discovers alone JS & CSS files allows front end devs to directly develop without too much in mind.

Rate your excitement about potential contrib extending SDC: 1 ... 10 | N/A

10. I contributed a module based on SDC, I could possibly not good under 10 :D

Rate our documentation: 1 ... 10 | N/A

8. It is solid ! But I think the recent development have not been integrated in it (still metadata.json in the first line of doc ...)

Did you 1️⃣ refactor existing template into a component, or did you 2️⃣ write a component from scratch? 1 | 2

For now I only make my own components from scratch, but I am at this moment preparing a migration from older custom components to SDC components.

Rate the helpfulness of error messages encountered: 1 ... 10 | N/A

10. They are very clear to me.

Have you tried the Storybook integration? Yes | No

No but I will in a short future. You can test DAB → for a Drupal tool for integrators 😬

Any thoughts you would like to share? The sky is the limit

This project is a very good addition in the Drupal world in my opinion, thank you for the work put it it <3

Added Drupal Atomic builder into the list of modules using SDC as Mike asked :)

I also have the issue at the moment, but only when enabling SDC, otherwise it was working well.

I'm going to test more.