Hi @vishal.kadam,
Thanks for your review ! I made the changes your requested.
Hi @avpaderno and thanks for the review !
I fixed what you listed in your comment on 1.x branch.
sillot → created an issue.
Hi,
I made a patch because I ran into the same issue.
I added a fallback thumbnail path to the audio.png file.
Tell me if it solve your issue.
"nbsp_filter-10.3_incompatibility-3460328-5.patch" tested as well and fixes the issue !
Thanks :)
sillot → created an issue.
At the moment I did not try to use slots in the .components.yml for the moment, but you should be able to access the data in your component anyway in theory.
I'll try to look into it when I'll have the time.
Ok I understand, I had a use case for this: I reuse a specific node and need to have it's publication date updated, so the reset to 0 is necessary.
What would you advise for this use case ?
sillot → created an issue.
Rate your excitement about SDC in core: 1 ... 10 | N/A
10. It is finally a viable option for atomic design building in the Drupal way. The fact that SDC discovers alone JS & CSS files allows front end devs to directly develop without too much in mind.
Rate your excitement about potential contrib extending SDC: 1 ... 10 | N/A
10. I contributed a module based on SDC, I could possibly not good under 10 :D
Rate our documentation: 1 ... 10 | N/A
8. It is solid ! But I think the recent development have not been integrated in it (still metadata.json in the first line of doc ...)
Did you 1️⃣ refactor existing template into a component, or did you 2️⃣ write a component from scratch? 1 | 2
For now I only make my own components from scratch, but I am at this moment preparing a migration from older custom components to SDC components.
Rate the helpfulness of error messages encountered: 1 ... 10 | N/A
10. They are very clear to me.
Have you tried the Storybook integration? Yes | No
No but I will in a short future. You can test DAB → for a Drupal tool for integrators 😬
Any thoughts you would like to share? The sky is the limit
This project is a very good addition in the Drupal world in my opinion, thank you for the work put it it <3
Added Drupal Atomic builder into the list of modules using SDC as Mike asked :)
I also have the issue at the moment, but only when enabling SDC, otherwise it was working well.
I'm going to test more.