- Issue created by @jcandan
- πΊπΈUnited States jcandan
The Annotated example component.yml β docs give no expectation of format on the
group
key. This module's use of the group as a URL parameter with no URL encoding may be part of the issue. Perhaps some manipulation of the group value to be URL friendly would be necessary. - πΊπΈUnited States jcandan
Core doesn't have a canonical solution for this need to convert strings to URL friendly paths.
There's a couple options to deal with this. Either we...
- Follow the community's attempt via the Html::getClass() method.
- Add Pathauto as a dependency to gain access to its AliasCleaner::cleanAlias() method.
- πΊπΈUnited States jcandan
I've opened π Rename erroneous Alert Banner grouping Active to address the incompatibility.
- πΊπΈUnited States jcandan
While a patch π Rename erroneous Alert Banner grouping Active is now available to fix this module incompatibility, this really should be addressed, since there is no sanitization on the group usage in URL generation.
Any other suggestions than the 2 noted above?
- π«π·France Quentin Harelle
Hi jcandan,
Sorry for the response time, and thank you for reporting this.I made a fix and a new release with the fix (1.0.7).
I took your suggestion using the Html utility class but with getId(), I thought it was better suited.
Tell me if it solves the bug.
-
sillot β
committed f29c6db6 on 1.x
fix(#3497652): sanitize group for url to avoid error with special...
-
sillot β
committed f29c6db6 on 1.x
- π«π·France Quentin Harelle
Great ! Thank you for the report and the test afterward !
I tag the issue as fixed.