- Issue created by @jcandan
- πΊπΈUnited States jcandan
The Annotated example component.yml docs β give no expectation of format on the group key. This seems like a shortcoming in the Drupal documentation. Perhaps a core issue should be opened.
This fix would have the added benefit of addressing a problem with π Fix InvalidParameterException on component_type URL generation Active
- πΊπΈUnited States jcandan
jcandan β changed the visibility of the branch 3499479-rename-erroneous-alert to hidden.
- πΊπΈUnited States smustgrave
Yes they are separate components under USWDS and still separate components under the theme but to me grouping them together under a category makes sense.
- πΊπΈUnited States jcandan
MR !100 opened.
@smustgrave, any thoughts then about π Fix InvalidParameterException on component_type URL generation Active ?
- πΊπΈUnited States jcandan
Also, not to be rude, but how does grouping them make any sense?
An alert keeps users informed of important and sometimes time-sensitive changes.
Banners identify official websites of government organizations in the United States. They also help visitors understand whether a website is official and secure.
- πΊπΈUnited States jcandan
Agreed; that is the issue with that module. And, yes, it would fix the incompatibility. But surely you can see this is a fair proposal considering the quotes in #8 π Rename erroneous Alert Banner grouping Active .
I hope you'll reconsider.
Immutable patch provided for Composer.
- πΊπΈUnited States smustgrave
Iβm not not denying it. But if going to do it Iβm going to revisit all groups. And been thinking of putting components into folders