🇫🇷France @steveoriol

OK, but with this new version I can't see any goup option in the formatter settings or the phtoswipe settings page (/admin/config/media/photoswipe)?

After updating the photoswipe module from version (4.0.1 => 5.0.5) ( maj DB, new composer require, clean cache).
Clicking on the photos works again, but the gallery (arrows in photoswipe mode to go to the next photo in the group) no longer work on several websites.
It's strange, but I have the impression that the ‘.photoswipe-gallery’ is added to each photo displayed with the photoswipe formatter? so maybe the system sees each photo as a group of 1 photo (so no arrows).

steveoriol → created an issue.

In fact, this MR works really well, it's great.
Do you think it would be easy to modify to be able to select several files in the list, for example a pdf of the order and another from the store?

By adding the create method inside the EmailSender class, this works:

public static function create(ContainerInterface $container) {
  return new static(
    $container->get('commerce_email.mail_handler'),
    $container->get('token'),
    $container->get('database'),
    $container->get('entity_type.manager'),
    $container->get('event_dispatcher')
  );
}

steveoriol → created an issue.

OK, thank you penyaskito.

I create the following module:
Store Visibility Condition →
If it helps

And how do you attach JS to a specific variant?
Should a “{{ attach_library(‘mytheme/xxxxxx--variant’) }}” be added to the “xxxxxx--variant-teaser.twig” file, which is currently included in “xxxxxx.twig” with a condition on the variant, or is there a naming convention like “xxxxxx--variant-teaser.js” or “libraryOverrides” per variant in the xxxxxx.component.yml?

A get an error on "/admin/commerce/config/emails" page after add MR!25 :

ArgumentCountError: Too few arguments to function Drupal\commerce_email\EmailSender::__construct(), 4 passed in /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 261 and exactly 5 expected in Drupal\commerce_email\EmailSender->__construct() (line 77 of modules/contrib/commerce_email/src/EmailSender.php).

Thank you @marioki, Patch #33 💬 CKEditor stops loading on existing content after Drupal update to 10.4 Active works great !

Oops... I got the wrong version of Daisyui !
Using version 4, it works much better

for this to work, you need to add the class ‘input-bordered flex items-center gap-2’ to the label tag

I'll have to think about upgrading to version 5 ;-)

steveoriol → created an issue.

+1 (I agree)

A little trick until we find something better:

  settings:
    size:
      title: Size
      type: "integer"
      minimum: 12
      maximum: 128
      multipleOf: 4
      default: 32
    color:
      title: Couleur
      type: "string"
      format: "color"
      default: "#000001"
  template: >
    <svg xmlns="http://www.w3.org/2000/svg"
      class="lokaicone"
      viewBox="0 0 24 24"
      height="{{ size|default(32) }}"
      width="{{ size|default(32) }}"
      fill="{{ color|replace({'#000001': "currentColor"}) }}"
    >
      {{ content }} 
    </svg>

Basically, you set the default colour that is not used in the site and replace it with ‘currentColor’.

steveoriol → created an issue.

OK, It's work for me.
[R]

g4mbini → credited steveoriol → .

Yes, the changes correct the problem I have on 2.0.0-rc2
Great, thanks!

Info info, when you use a sub-theme with ui_suite_daisyui has base theme :
in xxxxx.info.yml
base theme: ui_suite_daisyui
you can use you own DaisyUI local package by adding in the xxxxx.info.yml

[...]
libraries:
  - xxxxx/global
  - xxxxx/daisyui

libraries-override:
  ui_suite_daisyui/daisyui_cdn:
    css:
      theme:
         'https://cdn.jsdelivr.net/npm/daisyui@4.12.23/dist/full.min.css': false
    js:
        'https://cdn.tailwindcss.com?plugins=typography': false

  ui_suite_daisyui/custom_css:
    css:
      theme:
        'dist/css/custom/custom.css': false

and add in "xxxxx.libraries.yml" :

global:
  js:
    js/xxxxx.js: {}
  css:
    theme:
      css/custom.css: {}

daisyui:
  css:
    theme:
      /libraries/daisyui/daisyui.css: { minified: true }

But it's true that it would be great to be able to choose which packet to use by simple configuration!

steveoriol → created an issue.

steveoriol → created an issue.

g4mbini → credited steveoriol → .

Yes, everything works fine now :-)
I use :

1. UI Patterns 2.0.0-beta6
2. UI Suite DaisyUI 4.0.0-alpha7

It works :-)
Thanks @just_like_good_vibes

With UI Suite DaisyUI, UI Patterns 2.0.x and Drupal Commerce (on user/1/address-book) ou Webform (on user/1/submissions) ...
Same error as grimreaper

steveoriol → created an issue.

Hi @mogtofu33, OK I upgraded to “1.0.x-dev”, no more fatal error,
and the icon in the menus now works :-)

I still get a fatal error on pages like “/user/1/address-book” (comerce 2 module),
but I think it's a problem with the “ ui_suite_daisyui ” theme,
because the other themes work fine...
Merci.

By switching from “1.0.0-beta2” to “1.0.x-dev”, I now have another error when I rebuild caches (drush cr), here it is:

In CheckExceptionOnInvalidReferenceBehaviorPass.php line 119:                                                                                                                                      
                                                                                                                                                                                                   
  The service "ui_icons.search" has a dependency on a non-existent service "plugin.manager.icon_pack". Did you mean one of these: "plugin.manager.block", "plugin.manager.action", "plugin.manag   
  er.menu.link", "plugin.manager.mail", "plugin.manager.condition", "plugin.manager.sdc", "plugin.manager.help_topic", "plugin.manager.hook_event", "plugin.manager.workflow", "plugin.manager.v   
  iews.cache", "plugin.manager.views.pager"?

I'm back with the “1.0.0-beta2” version...

yes, in fact,
if you activate the “Automatic submission on store selection” option in the “Commerce Store Switch” block configuration,
the block submission button is no longer displayed and the page is immediately reloaded with the store selected in the selection list.

Ok This version works for me

steveoriol → changed the visibility of the branch revert-db033bbb to hidden.

steveoriol → created an issue.

Too good, it'll be super mega cool! thanks

steveoriol → created an issue.

I have another error that probably has nothing to do with “ui_icons” but looks similar (with the “Array” in the railroad...)

But here I have a “Warning”, if that helps:

Warning: Array to string conversion in Drupal\ui_patterns\Plugin\UiPatterns\PropType\LinksPropType::normalizeLink() (line 127 of modules/contrib/ui_patterns/src/Plugin/UiPatterns/PropType/LinksPropType.php).

Normally, it has the account name instead of “Array”.
Just install commerce 2 to get the “address-book” (Carnet d'adresses) tab : /user/1/address-book

steveoriol → created an issue.

What speed!
Thanks, it works like a charm :-)

I use the “UI Suite DaisyUI” theme with the icon pack:

• Hero outline 24
• Hero solid 16
• Hero solid 20
• Hero solid 24

And in fact, the icons in the “Hero outline 24” pack work well (the icon sizes apply well).

For the “Hero solid 20” and “Hero solid 24” packs, the icons are displayed but not in the size chosen.

And for the “Hero solid 16” pack, nothing is displayed...

So the bug may come from the packs or from the integration in ui_icons.

In fact, the ‘working Icon’ isn't displayed as it should be, it's just that I've modified the HTML directly via the inspector (Ctrl+Shift+i).
Here is the source code extract of the page received (Ctrl+u):

[...]<span class="drupal-icon"><svg height="100" width="100" fill="currentColor" stroke-width="2">  viewBox="0 0 20 20" <path fill-rule="evenodd" d="M18 10a8 8 0 1 1-16 0 8 8 0 0 1 16 0Zm-5.5-2.5a2.5 2.5 0 1 1-5 0 2.5 2.5 0 0 1 5 0ZM10 12a5.99 5.99 0 0 0-4.793 2.39A6.483 6.483 0 0 0 10 16.5a6.483 6.483 0 0 0 4.793-2.11A5.99 5.99 0 0 0 10 12Z" clip-rule="evenodd" />  </svg>
</span>[...]

I simply moved the ‘>’ from before to after the viewBox property:

[...]stroke-width="2"> viewBox="0 0 20 20" <path[...]
to
[...]stroke-width="2" viewBox="0 0 20 20"><path[...]

not so simple, in fact there is no ‘viewBox’ in the source but a ‘size’ :

steveoriol → created an issue.

In fact I've just seen that with patterns 2.x, there's no longer any need for this module to use components directly with a display mode.

It's just that with ‘ui_patterns_settings’ it was prettier and easier to configure.

g4mbini → credited steveoriol → .

sorry @prudloff, I can't remember where I had the problem

steveoriol → created an issue.

steveoriol → created an issue.

I can confirm that the MR works well

A template like this :

<div class="grid-x grid-margin-x">
    <div class="cell small-12 medium-6">
        <div class="zonetemplate">
            <p>colonne 1</p>
        </div>
    </div>
    <div class="cell small-12 medium-6">
        <div class="zonetemplate">
            <p>colonne 2</p>
        </div>
    </div>
</div>

Gives this render :

<section class="ckeditor-template-wrapper">
    <div class="ckeditor-template-content">
        <div class="grid-x grid-margin-x">
            <div class="cell small-12 medium-6">
                <div class="zonetemplate"><p>colonne 1</p></div>
            </div>
            <div class="cell small-12 medium-6">
                <div class="zonetemplate"><p>colonne 2</p></div>
            </div>
        </div>
    </div>
</section>

But, it could be a little better if there was a way to do something like this:

<section class="ckeditor-template-wrapper">
        <div class="grid-x grid-margin-x">
            <div class="cell small-12 medium-6">
                <div class="ckeditor-template-content"><p>colonne 1</p></div>
            </div>
            <div class="cell small-12 medium-6">
                <div class="ckeditor-template-content"><p>colonne 2</p></div>
            </div>
        </div>
</section>

I can confirm that the patch corrected the problem.

The https://www.drupal.org/project/ckeditor_templates/issues/3462157 ✨ Add widgettypearound integration Needs work patch works well for me

Patch #2 works very well for me, thank you.

#151 works fine on D10.3.3 for me too, thanks

Patchs does not works for D10.3.3...

Hi @ananya.k the patch "Error_in_mail_login_module-3462452.patch" does not apply

"nbsp_filter-10.3_incompatibility-3460328-5.patch" works well, Thanks :-)

patch #3 works for me too :-)
Thanks

even if the patch corrects the errors,
it doesn't apply without error for me and it creates extra useless folders and files, weird.

❯ tree web/modules/contrib/nbsp_filter/
 web/modules/contrib/nbsp_filter/
 ├── b
 │   └── config
 │       └── schema
 │           └── nbsp_filter.schema.yml
 ├── config
 │   └── schema
 │       └── nbsp_filter.schema.yml
 ├── LICENSE.txt
 ├── nbsp_filter.info.yml
 ├── nbsp_filter.module
 ├── README.txt
 ├── schema
 │   └── nbsp_filter.schema.yml
 └── src
     └── Plugin
         └── Filter
             ├── NbspFilter.php
             └── NbspFilter.php.rej

I tried a quick trick with “typedjs_filter-3462501”, but it didn't seem to work...

steveoriol → created an issue.

the patch does not apply to the latest versions of the module

steveoriol → created an issue.

Patch #13 is working

The patch is applied and the deactivated format appears in the list, but there's no button to reactivate deactivated formats.
I tried with versions D10.2.7 and D10.3.0 but no "enable" button is displayed.

steveoriol → changed the visibility of the branch 11.x to active.

steveoriol → created an issue.

The patches aren't applying for me on D10.3.0.

I've had the same problem for myself for a few days now...

G4MBINI → credited steveoriol → .

Okay, thanks kishan@kk

I have the same problem with D10.2.4 - PHP8.2.15 and Avatar Kit v8.x-1.3

G4MBINI → credited steveoriol → .

You guessed right, it still doesn't work using references. (dev-1.2.x a5445a0)

steveoriol → created an issue.

steveoriol → changed the visibility of the branch 3427914-just-a-small to hidden.

Sorry about that, it's actually an old patch that's failing, so it's all good.

https://www.drupal.org/files/issues/2018-04-23/2672656-31.patch → ([2672656] Remove HTML Debug Comments from a particular field in debug mode)

steveoriol → created an issue.

Here is the configuration file : https://pastebin.com/GcHQ5412

steveoriol → created an issue.