- Issue created by @aitala
- Assigned to sourav_paul
- Issue was unassigned.
- Status changed to Postponed: needs info
5 months ago 9:02am 24 June 2024 - 🇮🇳India sourav_paul Kolkata
I've checked the issue, & Followed mentioned steps
But Can't reproduce the issue... - 🇫🇷France steveoriol Grenoble 🇫🇷
I've had the same problem for myself for a few days now...
- 🇦🇺Australia realityloop
This issue just caused me nearly a day of lost time with tests failing and trying to figure out why, have removed the module from the project now.
- 🇩🇪Germany hexabinaer Berlin, Germany
We're using this module in the OpenCulturas distribution. Oddly enough some site owners report exactly that issue while others get no message at all any more (neither on unsaved-leave nor on save button). I can reproduce both phenomenons with my setup (Firefox, no adblockers + co). Testing with several roles.
We're still analyzing reproduceability, just to let folks know.
- 🇺🇸United States aitala
I'm clueless... I will get the false message sometimes, but now I've also had the message not appear when it should.
I'm seeing nothing in watchdog no error message...
Weird...
E
- 🇺🇸United States Steve Hanson
I also am now seeing this for at least a week. I have uninstalled the module because people are finding it annoying.
- 🇺🇸United States aitala
I'm trying to think is there are any other modules that I've updated that I have updated that could affect node edit protection...
I do recall a number of jQueryUI modules that I updated and maybe Content Locking...?
E
- 🇮🇳India narendra.rajwar27 India
We are also facing the same issue. Getting warning popup on node add and save.
I found for me this is happening because of gin theme release: https://www.drupal.org/project/gin/releases/8.x-3.0-rc11 →
where the action buttons are moved out of. the form and placed in sticky section: https://www.drupal.org/project/gin/issues/3356717 ✨ Move Action buttons to sticky header FixedDue to this change node protection script is not able to applied on action buttons.
Adding patch for the same.
- Status changed to Needs review
5 months ago 4:25am 3 July 2024 - 🇮🇳India Kanchan Bhogade
Hi
I've reproduced the issue on Drupal 10 with the Gin theme (Gin 8.x-3.0-rc12); For claro issue is not reproduced.
The Patch "3455823-warning-on-node-add-and-edit" is applied cleanly...Testing Steps:
- Install Gin them and set as default
- Install and enable the Node Edit Protection module
- Create a new node, and hit save.
- A warning message pops up.
- Pop up the "Leave" Button saving the node
- Apply the patch check for the same
Test Result:
When hitting the Save button of the node, the node gets saved and does not get a warning pop-up.
Attaching Screen recording
RTBC+1 - 🇮🇳India narendra.rajwar27 India
Attaching the updated patch since the previous patch is missing out some operations on node protection within the site.
- 🇺🇸United States aitala
I have applied the patch in #13 but it seems to only work when creating a new node and not while editing an existing node and navigating away.
Thanks,
Eric - Status changed to RTBC
5 months ago 1:07pm 7 July 2024 - 🇺🇸United States jumpsuitgreen
Patch #13 worked for me as well, both for editing and creating nodes.
Thanks! - 🇨🇦Canada mahde Vancouver
Unfortunately patch #13 didn't work with me when I follow the steps shown in the attached video.
- First commit to issue fork.
- Merge request !10Issue #3455823: Fix the warning issue that occurs when pressing the save submit button in the Gin Admin theme → (Open) created by tobiasb