I thought I should let you know that all of these issues disappeared after I updated to the latest Varbase releases. It is no longer trying to apply these patches that do not work. So feel free to close this.
I did delete composer.lock but it gets rebuilt again during the composer update and re-inserts the patches that will not apply.
Ah - it comes from the composer.json in the varbase_core module -- but I'm not real clear on the best way to deal with this. I finally set composer-exit-on-patch-failure to false --- Updates now complete but 3 patches fail -
(Issue #3272629: Media Library widget display doesn't return to first page on applying filters)
Could not apply patch! Skipping. The error was: Cannot apply patch
https://www.drupal.org/files/issues/2022-03-30/media_library_pager_fix.p... →
https://www.drupal.org/files/issues/2024-01-04/drupal-10-2-0--2023-12-26... →
(Issue #3412378: Fix vertical tabs and media library styling issues within Dialog and Media Library Modal by Claro after the Drupal 10.2.0 Release)
Could not apply patch! Skipping. The error was: Cannot apply patch
https://www.drupal.org/files/issues/2024-01-04/drupal-10-2-0--2023-12-26... →
Applying patches for drupal/security_review
https://raw.githubusercontent.com/Vardot/varbase-patches/patches/securit... (Issue #3463712: Fix fatal error when pressing Run checklist button)
Could not apply patch! Skipping. The error was: Cannot apply patch https://raw.githubusercontent.com/Vardot/varbase-patches/patches/securit...
It seems to go wrong like this -- with composer update -vvv
patching file modules/layout_builder/tests/src/FunctionalJavascript/MoveSectionsFormTest.php
patching file themes/stable9/css/layout_builder/layout-builder.css
https://www.drupal.org/files/issues/2022-03-30/media_library_pager_fix.patch (Issue #3272629: Media Library widget display doesn't return to first page on applying filters)
Downloading https://www.drupal.org/files/issues/2022-03-30/media_library_pager_fix.patch
patch '-p2' --no-backup-if-mismatch -d '/home/wis/domains/dev.wis.community/public_html/docroot/core' < '/tmp/66ad2fef8579a.patch'
Executing command (CWD): patch '-p2' --no-backup-if-mismatch -d '/home/wis/domains/dev.wis.community/public_html/docroot/core' < '/tmp/66ad2fef8579a.patch'
patching file modules/media_library/media_library.module
Hunk #1 FAILED at 216.
1 out of 1 hunk FAILED -- saving rejects to file modules/media_library/media_library.module.rej
Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2022-03-30/media_library_pager_fix.patch
Downloading https://packagist.org/downloads/
Downloading https://packages.drupal.org/8/downloads
[200] https://packages.drupal.org/8/downloads
[201] https://packagist.org/downloads/
In Patches.php line 331:
[Exception]
Cannot apply patch Issue #3272629: Media Library widget display doesn't ret
urn to first page on applying filters (https://www.drupal.org/files/issues/
2022-03-30/media_library_pager_fix.patch)!
Exception trace:
at /home/wis/domains/dev.wis.community/public_html/vendor/cweagans/composer-patches/src/Patches.php:331
cweagans\Composer\Patches->postInstall() at /home/wis/domains/dev.wis.community/public_html/vendor/composer/composer/src/Composer/EventDispatcher/EventDispatcher.php:215
Even weirder - it is trying to patch a Drupal 7 module which does not exist (which would explain the failure). This must be some sort of leftover from the migration from Drupal 7 but I cannot see where it is getting put in.
My current issue with the upgrade that I just do not understand is that composer keeps trying to apply a patch that fails.
Issue #3272629: Media Library widget display doesn't return to first page on applying filters": " https://www.drupal.org/files/issues/2022-03-30/media_library_pager_fix.p... → ",
I have tried to NOT apply that patch by removing it from the composer.lock file but it keeps getting put back in and I do not see where that is coming from.
What I am confused about is what is supposed to update the composer files in the upgrade process. Once I changed drupal/core and drupal/core-recommended drupal would upgrade, and all the rest of the upgrades happened that depended on 10.3 drupal - but now I am getting a few patches that are in composer.lock that will not apply to the new version of the modules.
Steve Hanson → created an issue.
Apparently this was a temporary issue --- it works again.
I also am now seeing this for at least a week. I have uninstalled the module because people are finding it annoying.
Steve Hanson → created an issue.
Steve Hanson → created an issue.
Oh, I think I understand. The odd behavior is because I am using the Varbase distribution and the Varbase layout builder landing page is apparently what is letting me disable the custom layouts. If I turn that module off I can no longer disable the custom layouts, which at least makes sense. I will go bother the Varbase folks. Thanks.
Thank you for the script. All I had to do to turn off the custom setting was to turn it off in the display page. I'm a little surprised by all of this since as far as I can remember I never actually MADE any custom layouts, though I may have accidentally made one that was identical to the default.
So is the implication here that if I revert any custom ones and then turn off the ability to make custom ones that the automatic redirect will stop?
Well, there IS a certain amount of database cruft on this site left over from the recent migration from Drupal 7, so I will try to dig down on this a little more and try it out on a cleaner site. Thanks. It may take a few days for me to get back on this.
At least on my own site this has completely broken my ability to do page layout work at all - it seems to have broken all of the management liks on the layout page. This is using the gin theme on management pages. This only happens MOST of the time for some reason. And I think only on the pages where I have put in a limitation on the responsive display. I'm still trying to exercise this and pin it down It LOOKS like it is now refusing to find some CSS files.
Sorry I did not get back to this for a while. There is an example page at https://www.wis.community/dunn-county-infohub
- there is a block at the bottom of the page that should only be visible to larger screens.
There is a slug of console errors along the lines of
js_ix73XmeryiMX94PUb…zRAGYfQi_AVLk9J1:21 Uncaught TypeError: $(...).once is not a function
at Object.attach (js_W7rbNMr8sQ-UQVJlm…fQi_AVLk9J1:17:1339)
at js_ix73XmeryiMX94PUb…YfQi_AVLk9J1:21:427
at Array.forEach ()
at Drupal.attachBehaviors (js_ix73XmeryiMX94PUb…YfQi_AVLk9J1:21:353)
at HTMLAnchorElement. (js_ix73XmeryiMX94PUb…i_AVLk9J1:289:15049)
at Function.each (js_ix73XmeryiMX94PUb…YfQi_AVLk9J1:3:3129)
at ce.fn.init.each (js_ix73XmeryiMX94PUb…YfQi_AVLk9J1:3:1594)
at Drupal.AjaxCommands.insert (js_ix73XmeryiMX94PUb…i_AVLk9J1:289:14979)
at js_ix73XmeryiMX94PUb…i_AVLk9J1:289:11213
attach @ js_W7rbNMr8sQ-UQVJlm…zRAGYfQi_AVLk9J1:17
(anonymous) @ js_ix73XmeryiMX94PUb…zRAGYfQi_AVLk9J1:21
Drupal.attachBehaviors @ js_ix73XmeryiMX94PUb…zRAGYfQi_AVLk9J1:21
(anonymous) @ js_ix73XmeryiMX94PUb…RAGYfQi_AVLk9J1:289
each @ js_ix73XmeryiMX94PUb…0zRAGYfQi_AVLk9J1:3
each @ js_ix73XmeryiMX94PUb…0zRAGYfQi_AVLk9J1:3
insert @ js_ix73XmeryiMX94PUb…RAGYfQi_AVLk9J1:289
(anonymous) @ js_ix73XmeryiMX94PUb…RAGYfQi_AVLk9J1:289
setTimeout (async)
Drupal.throwError @ js_ix73XmeryiMX94PUb…zRAGYfQi_AVLk9J1:21
(anonymous) @ js_ix73XmeryiMX94PUb…zRAGYfQi_AVLk9J1:21
Drupal.attachBehaviors @ js_ix73XmeryiMX94PUb…zRAGYfQi_AVLk9J1:21
(anonymous) @ js_ix73XmeryiMX94PUb…RAGYfQi_AVLk9J1:289
each @ js_ix73XmeryiMX94PUb…0zRAGYfQi_AVLk9J1:3
each @ js_ix73XmeryiMX94PUb…0zRAGYfQi_AVLk9J1:3
insert @ js_ix73XmeryiMX94PUb…RAGYfQi_AVLk9J1:289
(anonymous) @ js_ix73XmeryiMX94PUb…RAGYfQi_AVLk9J1:289
Promise.then (async)
(anonymous) @ js_ix73XmeryiMX94PUb…RAGYfQi_AVLk9J1:289
Drupal.Ajax.commandExecutionQueue @ js_ix73XmeryiMX94PUb…RAGYfQi_AVLk9J1:289
Drupal.Ajax.success @ js_ix73XmeryiMX94PUb…RAGYfQi_AVLk9J1:289
t.success @ js_W7rbNMr8sQ-UQVJlm…zRAGYfQi_AVLk9J1:18
processReplacement @ js_W7rbNMr8sQ-UQVJlm…zRAGYfQi_AVLk9J1:76
checkMutationAndProcess @ js_W7rbNMr8sQ-UQVJlm…zRAGYfQi_AVLk9J1:76
(anonymous) @ js_W7rbNMr8sQ-UQVJlm…zRAGYfQi_AVLk9J1:76
processMutations @ js_W7rbNMr8sQ-UQVJlm…zRAGYfQi_AVLk9J1:76
Steve Hanson → created an issue.
Steve Hanson → created an issue.
Steve Hanson → created an issue.
I have applied patch 29 but am still seeing the path being built incorrectly by concatenating the public and private paths together after also applying the patch for https://www.drupal.org/project/migrate_upgrade/issues/2921617#comment-15... ✨ Provide --legacy-private-path command-line option Needs work so that the private path can be applied while setting up a drush migration. I'm somewhat bewildered that I cannot determine a way to make this work properly considering how long it has been broken.
Sorry to not comment on this for so long -- I have applied this patch and it does make the option available and apparently accepts it and uses the variable - but I continue to have problems with the path being formed incorrectly as discussed in https://www.drupal.org/project/drupal/issues/3123350 → - I have also applied this patch and the path is still being formed incorrectly by concatenating the public and private paths together.
Steve Hanson → created an issue.
Thank you, that fixed it.
Steve Hanson → created an issue.