🇮🇳India @Sourav_Paul

I've tried to reproduce the issue but can't.
Please provide proper reproducing steps..

Needs more info..

I've recreated the issue & fixed that..

please review it.

Thanks...

SS:
before:

after:

sourav_paul → made their first commit to this issue’s fork.

I've tried to recreate the issue by using the following steps but can't replicate it.

I've installed enabled storybook: "1.0.0-beta2" & themed_fast_404: "1.0.6" on d10.3

Please provide proper reproduce steps.

Need More Info...

I've modified the code but when trying to push the code getting this error

SS:

I've recreate the issue & debugged on that.

Noticed that in the civic theme, there is a structural issue as the span for help text isn't there but in other themes its have.
Hence theme maintainer need to modify the code to include help text with icon.

Attaching SS:

for claro:

for civic:

@geoanders please review it, As it is causing an error to this: https://www.drupal.org/project/node_weight/issues/3448536 ✨ Only allows ordering up to 201 nodes Needs review

From a non-developer perspective, it's a bug as it feels no purpose to put the prefix before the description but, if we put the prefix below the description, it looks quite meaningful as the prefix is mostly used to indicate what value the user needs to enter.

I do appreciate with #13

Yeah, MR !1090 works for me as well.
It attached a configure link to the module on the extend page.

RTBC+1

As it got fixed in the newer version, hence closing it as outdated.

I've tested the MR!444...

Its fixed the sticky header issue for the devices under 959px.

Attaching screen recording link: https://www.awesomescreenshot.com/video/31139234?key=a191b06395bb096ae03...

Hence moving it to RTBC.

Hi, @agentrickard & @strykaizer

please check the MR.

If anyone facing this issue on upgrading the module, can use this MR as a patch..
It will fix the issue..

@bhaveshdas please review it..

@mwebaze are you still working on that?

I've tested the MR!15 on D10.3, the feature is working as described.

but, IMO: it would be more secure, if we create & download a file for user's OTP link...

Hence moving it to RTBC...

I've tested the MR!459.
It fixed the dropdown menu left aligned issue.

Attaching SS:

before:

after:

I've tested MR !7.
It sorts terms by label & gives the label a taxonomy link in parentheses.

But When I clicked on Merge it gave me a fatal error with WSOD on D11

Attaching SS:

hence moving it to "Needs Work"

Testing of this MR was passed successfully.

hence, moving it to RTBC

I've checked & applied the MR !3 in entity_copy_reference 1.0.x-dev
it's applied with no error.

& the copied content author name getting replaced by the user who copy the content.

Attaching SS:

I've checked & tested the gitlab-ci.
Pipeline passed successfully: https://git.drupalcode.org/issue/link_allowed_hosts-3453237/-/pipelines/...

hence moving it to RTBC.

I've applied MR !9, it applied with no errors.
But there is still some issue reported by phpcs

Attaching SS:

Hence moving it to "Needs Work"

Please fix the remaining issue...

I've applied the MR !14 & it's applied successfully..

Attaching SS & message:

sourav@sourav-Mi-Notebook-Pro:~/projects/my_site/web/modules/contrib/varbase_components$ curl https://git.drupalcode.org/project/varbase_components/-/merge_requests/14.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  266k    0  266k    0     0   340k      0 --:--:-- --:--:-- --:--:--  340k
<stdin>:521: trailing whitespace.
{% include 'varbase_components:icon' with 
<stdin>:527: trailing whitespace.
{% include 'varbase_components:icon' with 
<stdin>:536: trailing whitespace.
{% include 'varbase_components:icon' with 
<stdin>:2427: trailing whitespace.
* `media_position`: Choose the location of the media from 
<stdin>:2429: trailing whitespace.
* `id`: Set a unique id on the heroslider for optional controls, especially 
Checking patch .gitlab-ci.yml...
Checking patch components/atoms/README.md...
Checking patch components/atoms/accordion-item/README.md...
Checking patch components/atoms/accordion-item/accordion-item.css...
Checking patch components/atoms/accordion-item/accordion-item.twig...
Checking patch components/atoms/badge/README.md...
Checking patch components/atoms/button/README.md...
Checking patch components/atoms/close-button/README.md...
Checking patch components/atoms/close-button/close-button.twig...
Checking patch components/atoms/column/column.twig...
Checking patch components/atoms/container/README.md...
Checking patch components/atoms/heading/README.md...
Checking patch components/atoms/icon/README.md...
Checking patch components/atoms/image/README.md...
Checking patch components/atoms/input/README.md...
Checking patch components/atoms/link/README.md...
Checking patch components/atoms/progress-bar/README.md...
Checking patch components/atoms/progress-bar/progress-bar.css...
Checking patch components/atoms/progress-bar/progress-bar.twig...
Checking patch components/atoms/spinner/README.md...
Checking patch components/atoms/taxonomy/taxonomy.css...
Checking patch components/atoms/text/text.twig...
Checking patch components/atoms/textarea/README.md...
Checking patch components/molecules/README.md...
Checking patch components/molecules/accordion/README.md...
Checking patch components/molecules/accordion/accordion.js...
Checking patch components/molecules/alert/README.md...
Checking patch components/molecules/alert/alert.css...
Checking patch components/molecules/breadcrumb/README.md...
Checking patch components/molecules/breadcrumb/breadcrumb.css...
Checking patch components/molecules/dynamic-responsive-image/README.md...
Checking patch components/molecules/field-tags/README.md...
Checking patch components/molecules/field-tags/field-tags.css...
Checking patch components/molecules/input-checkbox/README.md...
Checking patch components/molecules/input-checkbox/input-checkbox.component.yml...
Checking patch components/molecules/input-color/README.md...
Checking patch components/molecules/navbar-brand/navbar-brand.css...
Checking patch components/molecules/navbar-brand/navbar-brand.twig...
Checking patch components/molecules/page-title/README.md...
Checking patch components/molecules/pagination/README.md...
Checking patch components/molecules/pagination/pagination.css...
Checking patch components/molecules/tabs/tabs.css...
Checking patch components/organisms/README.md...
Checking patch components/organisms/block-cta/block-cta.css...
Checking patch components/organisms/block-cta/block-cta.twig...
Checking patch components/organisms/block-heading/README.md...
Checking patch components/organisms/block-local-video/block-local-video.css...
Checking patch components/organisms/block-local-video/block-local-video.twig...
Checking patch components/organisms/block-remote-video/block-remote-video.css...
Checking patch components/organisms/block-remote-video/block-remote-video.twig...
Checking patch components/organisms/block-rich-text/block-rich-text.twig...
Checking patch components/organisms/card-featured/README.md...
Checking patch components/organisms/card-featured/card-featured.css...
Checking patch components/organisms/card-hero/README.md...
Checking patch components/organisms/card-hero/card-hero.css...
Checking patch components/organisms/card-hero/card-hero.twig...
Checking patch components/organisms/card-impressed/README.md...
Checking patch components/organisms/card-impressed/card-impressed.css...
Checking patch components/organisms/card-overlay/README.md...
Checking patch components/organisms/card-overlay/card-overlay.css...
Checking patch components/organisms/card-text/README.md...
Checking patch components/organisms/card-text/card-text.css...
Checking patch components/organisms/carousel/README.md...
Checking patch components/organisms/form-element-radiocheckbox/README.md...
Checking patch components/organisms/form-element/README.md...
Checking patch components/organisms/form/README.md...
Checking patch components/organisms/heroslider/README.md...
Checking patch components/organisms/heroslider/heroslider.css...
Checking patch components/organisms/heroslider/heroslider.js...
Checking patch components/organisms/heroslider/heroslider.twig...
Checking patch components/organisms/heroslider/js/oembed-frame.heroslider.vimeo.js...
Checking patch components/organisms/heroslider/js/oembed-frame.heroslider.youtube.js...
Checking patch components/organisms/heroslider/js/video.heroslider.local.js...
Checking patch components/organisms/heroslider/js/video.heroslider.vimeo.js...
Checking patch components/organisms/heroslider/js/video.heroslider.youtube.js...
Checking patch components/organisms/links-dropbutton/README.md...
Checking patch components/organisms/media-header/README.md...
Checking patch components/organisms/media-header/media-header.css...
Checking patch components/organisms/media-header/media-header.twig...
Checking patch components/organisms/media-hero-slide/README.md...
Checking patch components/organisms/media-hero-slide/media-hero-slide.css...
Checking patch components/organisms/media-hero-slider/README.md...
Checking patch components/organisms/media-hero-slider/media-hero-slider.css...
Checking patch components/organisms/media-hero-slider/media-hero-slider.twig...
Checking patch components/organisms/media/README.md...
Checking patch components/organisms/nav/nav.css...
Checking patch components/organisms/navbar/README.md...
Checking patch components/organisms/navbar/navbar.css...
Checking patch components/organisms/node/README.md...
Checking patch components/organisms/page-better-login/page-better-login.css...
Checking patch components/organisms/page-better-login/page-better-login.twig...
Checking patch components/organisms/page-footer/README.md...
Checking patch components/organisms/page-footer/page-footer.css...
Checking patch components/organisms/page-footer/page-footer.twig...
Checking patch components/organisms/page-header/README.md...
Checking patch components/organisms/page-header/page-header.twig...
Checking patch components/organisms/region/README.md...
Checking patch components/organisms/social-auth/social-auth.css...
Checking patch components/organisms/social-auth/social-auth.twig...
Checking patch components/organisms/table/README.md...
Checking patch components/organisms/table/table.twig...
Checking patch components/organisms/user/user.twig...
Checking patch components/organisms/views-view-table/README.md...
Checking patch components/organisms/views-view-unformatted/README.md...
Checking patch components/organisms/views-view/README.md...
Checking patch components/pages/page/page.css...
Checking patch components/templates/README.md...
Checking patch js/bootstrap/alert.js...
Checking patch js/bootstrap/base-component.js...
Checking patch js/bootstrap/button.js...
Checking patch js/bootstrap/carousel.js...
Checking patch js/bootstrap/collapse.js...
Checking patch js/bootstrap/dom/data.js...
Checking patch js/bootstrap/dom/event-handler.js...
Checking patch js/bootstrap/dom/manipulator.js...
Checking patch js/bootstrap/dom/selector-engine.js...
Checking patch js/bootstrap/dropdown.js...
Checking patch js/bootstrap/modal.js...
Checking patch js/bootstrap/offcanvas.js...
Checking patch js/bootstrap/popover.js...
Checking patch js/bootstrap/scrollspy.js...
Checking patch js/bootstrap/tab.js...
Checking patch js/bootstrap/toast.js...
Checking patch js/bootstrap/tooltip.js...
Checking patch js/bootstrap/util/backdrop.js...
Checking patch js/bootstrap/util/component-functions.js...
Checking patch js/bootstrap/util/config.js...
Checking patch js/bootstrap/util/focustrap.js...
Checking patch js/bootstrap/util/index.js...
Checking patch js/bootstrap/util/sanitizer.js...
Checking patch js/bootstrap/util/scrollbar.js...
Checking patch js/bootstrap/util/swipe.js...
Checking patch js/bootstrap/util/template-factory.js...
Checking patch js/popperjs/popper.js...
Checking patch varbase_components.install...
Checking patch webpack.config.build.js...
Checking patch webpack.config.init.js...
Checking patch webpack.config.js...
Hunk #1 succeeded at 42 (offset 2 lines).
Hunk #2 succeeded at 59 (offset 2 lines).
Hunk #3 succeeded at 91 (offset 2 lines).
Hunk #4 succeeded at 109 (offset 2 lines).
Hunk #5 succeeded at 133 (offset 2 lines).
Hunk #6 succeeded at 177 (offset 2 lines).
Applied patch .gitlab-ci.yml cleanly.
Applied patch components/atoms/README.md cleanly.
Applied patch components/atoms/accordion-item/README.md cleanly.
Applied patch components/atoms/accordion-item/accordion-item.css cleanly.
Applied patch components/atoms/accordion-item/accordion-item.twig cleanly.
Applied patch components/atoms/badge/README.md cleanly.
Applied patch components/atoms/button/README.md cleanly.
Applied patch components/atoms/close-button/README.md cleanly.
Applied patch components/atoms/close-button/close-button.twig cleanly.
Applied patch components/atoms/column/column.twig cleanly.
Applied patch components/atoms/container/README.md cleanly.
Applied patch components/atoms/heading/README.md cleanly.
Applied patch components/atoms/icon/README.md cleanly.
Applied patch components/atoms/image/README.md cleanly.
Applied patch components/atoms/input/README.md cleanly.
Applied patch components/atoms/link/README.md cleanly.
Applied patch components/atoms/progress-bar/README.md cleanly.
Applied patch components/atoms/progress-bar/progress-bar.css cleanly.
Applied patch components/atoms/progress-bar/progress-bar.twig cleanly.
Applied patch components/atoms/spinner/README.md cleanly.
Applied patch components/atoms/taxonomy/taxonomy.css cleanly.
Applied patch components/atoms/text/text.twig cleanly.
Applied patch components/atoms/textarea/README.md cleanly.
Applied patch components/molecules/README.md cleanly.
Applied patch components/molecules/accordion/README.md cleanly.
Applied patch components/molecules/accordion/accordion.js cleanly.
Applied patch components/molecules/alert/README.md cleanly.
Applied patch components/molecules/alert/alert.css cleanly.
Applied patch components/molecules/breadcrumb/README.md cleanly.
Applied patch components/molecules/breadcrumb/breadcrumb.css cleanly.
Applied patch components/molecules/dynamic-responsive-image/README.md cleanly.
Applied patch components/molecules/field-tags/README.md cleanly.
Applied patch components/molecules/field-tags/field-tags.css cleanly.
Applied patch components/molecules/input-checkbox/README.md cleanly.
Applied patch components/molecules/input-checkbox/input-checkbox.component.yml cleanly.
Applied patch components/molecules/input-color/README.md cleanly.
Applied patch components/molecules/navbar-brand/navbar-brand.css cleanly.
Applied patch components/molecules/navbar-brand/navbar-brand.twig cleanly.
Applied patch components/molecules/page-title/README.md cleanly.
Applied patch components/molecules/pagination/README.md cleanly.
Applied patch components/molecules/pagination/pagination.css cleanly.
Applied patch components/molecules/tabs/tabs.css cleanly.
Applied patch components/organisms/README.md cleanly.
Applied patch components/organisms/block-cta/block-cta.css cleanly.
Applied patch components/organisms/block-cta/block-cta.twig cleanly.
Applied patch components/organisms/block-heading/README.md cleanly.
Applied patch components/organisms/block-local-video/block-local-video.css cleanly.
Applied patch components/organisms/block-local-video/block-local-video.twig cleanly.
Applied patch components/organisms/block-remote-video/block-remote-video.css cleanly.
Applied patch components/organisms/block-remote-video/block-remote-video.twig cleanly.
Applied patch components/organisms/block-rich-text/block-rich-text.twig cleanly.
Applied patch components/organisms/card-featured/README.md cleanly.
Applied patch components/organisms/card-featured/card-featured.css cleanly.
Applied patch components/organisms/card-hero/README.md cleanly.
Applied patch components/organisms/card-hero/card-hero.css cleanly.
Applied patch components/organisms/card-hero/card-hero.twig cleanly.
Applied patch components/organisms/card-impressed/README.md cleanly.
Applied patch components/organisms/card-impressed/card-impressed.css cleanly.
Applied patch components/organisms/card-overlay/README.md cleanly.
Applied patch components/organisms/card-overlay/card-overlay.css cleanly.
Applied patch components/organisms/card-text/README.md cleanly.
Applied patch components/organisms/card-text/card-text.css cleanly.
Applied patch components/organisms/carousel/README.md cleanly.
Applied patch components/organisms/form-element-radiocheckbox/README.md cleanly.
Applied patch components/organisms/form-element/README.md cleanly.
Applied patch components/organisms/form/README.md cleanly.
Applied patch components/organisms/heroslider/README.md cleanly.
Applied patch components/organisms/heroslider/heroslider.css cleanly.
Applied patch components/organisms/heroslider/heroslider.js cleanly.
Applied patch components/organisms/heroslider/heroslider.twig cleanly.
Applied patch components/organisms/heroslider/js/oembed-frame.heroslider.vimeo.js cleanly.
Applied patch components/organisms/heroslider/js/oembed-frame.heroslider.youtube.js cleanly.
Applied patch components/organisms/heroslider/js/video.heroslider.local.js cleanly.
Applied patch components/organisms/heroslider/js/video.heroslider.vimeo.js cleanly.
Applied patch components/organisms/heroslider/js/video.heroslider.youtube.js cleanly.
Applied patch components/organisms/links-dropbutton/README.md cleanly.
Applied patch components/organisms/media-header/README.md cleanly.
Applied patch components/organisms/media-header/media-header.css cleanly.
Applied patch components/organisms/media-header/media-header.twig cleanly.
Applied patch components/organisms/media-hero-slide/README.md cleanly.
Applied patch components/organisms/media-hero-slide/media-hero-slide.css cleanly.
Applied patch components/organisms/media-hero-slider/README.md cleanly.
Applied patch components/organisms/media-hero-slider/media-hero-slider.css cleanly.
Applied patch components/organisms/media-hero-slider/media-hero-slider.twig cleanly.
Applied patch components/organisms/media/README.md cleanly.
Applied patch components/organisms/nav/nav.css cleanly.
Applied patch components/organisms/navbar/README.md cleanly.
Applied patch components/organisms/navbar/navbar.css cleanly.
Applied patch components/organisms/node/README.md cleanly.
Applied patch components/organisms/page-better-login/page-better-login.css cleanly.
Applied patch components/organisms/page-better-login/page-better-login.twig cleanly.
Applied patch components/organisms/page-footer/README.md cleanly.
Applied patch components/organisms/page-footer/page-footer.css cleanly.
Applied patch components/organisms/page-footer/page-footer.twig cleanly.
Applied patch components/organisms/page-header/README.md cleanly.
Applied patch components/organisms/page-header/page-header.twig cleanly.
Applied patch components/organisms/region/README.md cleanly.
Applied patch components/organisms/social-auth/social-auth.css cleanly.
Applied patch components/organisms/social-auth/social-auth.twig cleanly.
Applied patch components/organisms/table/README.md cleanly.
Applied patch components/organisms/table/table.twig cleanly.
Applied patch components/organisms/user/user.twig cleanly.
Applied patch components/organisms/views-view-table/README.md cleanly.
Applied patch components/organisms/views-view-unformatted/README.md cleanly.
Applied patch components/organisms/views-view/README.md cleanly.
Applied patch components/pages/page/page.css cleanly.
Applied patch components/templates/README.md cleanly.
Applied patch js/bootstrap/alert.js cleanly.
Applied patch js/bootstrap/base-component.js cleanly.
Applied patch js/bootstrap/button.js cleanly.
Applied patch js/bootstrap/carousel.js cleanly.
Applied patch js/bootstrap/collapse.js cleanly.
Applied patch js/bootstrap/dom/data.js cleanly.
Applied patch js/bootstrap/dom/event-handler.js cleanly.
Applied patch js/bootstrap/dom/manipulator.js cleanly.
Applied patch js/bootstrap/dom/selector-engine.js cleanly.
Applied patch js/bootstrap/dropdown.js cleanly.
Applied patch js/bootstrap/modal.js cleanly.
Applied patch js/bootstrap/offcanvas.js cleanly.
Applied patch js/bootstrap/popover.js cleanly.
Applied patch js/bootstrap/scrollspy.js cleanly.
Applied patch js/bootstrap/tab.js cleanly.
Applied patch js/bootstrap/toast.js cleanly.
Applied patch js/bootstrap/tooltip.js cleanly.
Applied patch js/bootstrap/util/backdrop.js cleanly.
Applied patch js/bootstrap/util/component-functions.js cleanly.
Applied patch js/bootstrap/util/config.js cleanly.
Applied patch js/bootstrap/util/focustrap.js cleanly.
Applied patch js/bootstrap/util/index.js cleanly.
Applied patch js/bootstrap/util/sanitizer.js cleanly.
Applied patch js/bootstrap/util/scrollbar.js cleanly.
Applied patch js/bootstrap/util/swipe.js cleanly.
Applied patch js/bootstrap/util/template-factory.js cleanly.
Applied patch js/popperjs/popper.js cleanly.
Applied patch varbase_components.install cleanly.
Applied patch webpack.config.build.js cleanly.
Applied patch webpack.config.init.js cleanly.
Applied patch webpack.config.js cleanly.
warning: squelched 2 whitespace errors
warning: 7 lines add whitespace errors.

Even after applying MR there are some warnings reported by PHPCS

sourav@sourav-Mi-Notebook-Pro:~/projects/my_site/web/modules/contrib$ ../../../vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig varbase_components/

FILE: /home/sourav/projects/my_site/web/modules/contrib/varbase_components/components/base/root/README.md
---------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
---------------------------------------------------------------------------------------------------------
  6 | WARNING | Line exceeds 80 characters; contains 208 characters
 15 | WARNING | Line exceeds 80 characters; contains 293 characters
 18 | WARNING | Line exceeds 80 characters; contains 151 characters
 20 | WARNING | Line exceeds 80 characters; contains 109 characters
---------------------------------------------------------------------------------------------------------


FILE: /home/sourav/projects/my_site/web/modules/contrib/varbase_components/components/base/root/root.css
--------------------------------------------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 12 LINES
--------------------------------------------------------------------------------------------------------
  17 | ERROR | [ ] Style definitions must end with a semicolon
  18 | ERROR | [ ] Style definitions must end with a semicolon
  19 | ERROR | [ ] Style definitions must end with a semicolon
  20 | ERROR | [ ] Style definitions must end with a semicolon
  21 | ERROR | [ ] Style definitions must end with a semicolon
  22 | ERROR | [ ] Style definitions must end with a semicolon
  23 | ERROR | [ ] Style definitions must end with a semicolon
  24 | ERROR | [ ] Style definitions must end with a semicolon
  25 | ERROR | [ ] Style definitions must end with a semicolon
 108 | ERROR | [ ] Style definitions must end with a semicolon
 177 | ERROR | [x] Expected 1 newline at end of file; 2 found
 178 | ERROR | [x] Additional whitespace found at end of file
--------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------


FILE: /home/sourav/projects/my_site/web/modules/contrib/varbase_components/components/molecules/callout/README.md
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
-----------------------------------------------------------------------------------------------------------------
  3 | WARNING | Line exceeds 80 characters; contains 100 characters
  9 | WARNING | Line exceeds 80 characters; contains 130 characters
 10 | WARNING | Line exceeds 80 characters; contains 138 characters
 24 | WARNING | Line exceeds 80 characters; contains 81 characters
 32 | WARNING | Line exceeds 80 characters; contains 89 characters
 40 | WARNING | Line exceeds 80 characters; contains 91 characters
 48 | WARNING | Line exceeds 80 characters; contains 90 characters
-----------------------------------------------------------------------------------------------------------------


FILE: /home/sourav/projects/my_site/web/modules/contrib/varbase_components/components/molecules/callout/callout.css
-------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------
 71 | ERROR | [x] Expected 1 newline at end of file; 2 found
 72 | ERROR | [x] Additional whitespace found at end of file
-------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------


FILE: /home/sourav/projects/my_site/web/modules/contrib/varbase_components/varbase_components.module
----------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
----------------------------------------------------------------------------------------------------
 71 | ERROR   | [x] Expected 1 space(s) before asterisk; 0 found
 72 | ERROR   | [x] Expected 1 space(s) before asterisk; 0 found
 79 | ERROR   | [x] Expected 1 space(s) before asterisk; 0 found
 80 | ERROR   | [x] Expected 1 space(s) before asterisk; 0 found
 82 | WARNING | [ ] Unused variable $menu_index.
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------

Time: 267ms; Memory: 16MB

Hence moving it to "Needs work" state

Please fix the remaining issues.

MR was applied successfully but got a fatal error on running the command drush redirect:purge-circular-redirects
Using redirect 8.x-1.10 & D10.3
Sharing ss:

Please fix the logger issue...

This feature would be helpful as we don't need to use any other module to schedule emails for content transition.

I've tested the patch in #3 on D10.3, it's working...

Sourav_Paul → made their first commit to this issue’s fork.

I've checked this issue on D10.3.x & 11.0.1.
Even after setting the 'Hide non translatable fields on translation forms' for the specific term.
attaching ss for reference.

It seems there is an issue in _content_translation_form_language_content_settings_form_alter() in content_translation.admin.inc file of content_translation module..

I've tried to replicate the issue but can't by using the following steps...
I've tested it D10.2 & D11.0.1

Needs more info...

I've tested the MR & its working, There was only one issue in the config form which I've fixed & committed to last PR.
Now the module is fully compatible with D11.

Adding SS with this..

Sourav_Paul → made their first commit to this issue’s fork.

I've applied the patch & tested it on D11.0.1.
Its working as expected.

Attaching SS:

Also attaching SR link: https://www.awesomescreenshot.com/video/30756442?key=f77f67ee31e883fa9e9...

I've tested the patch in D11, and the functionality was working but when I tried to open the config form it encountered an error due to a missing argument in the parent class ConfigFormBase of "TypedConfigManagerInterface". I've solved the issue in this MR...

It is working now in d11..

I've replicated the issue in D10.3 by using the following steps & By using the patch for 2.0.x fixed the issue...

Can you share ss of broken pager & views settings?

@droprocker I've tried to replicate the issue by following your steps, But it didn't work, The Pager is working fine even after upgrading the BEF module from V6->V7.

Please provide more info...

@Gowtham.Boopathiraj you have to update your server configuration to update your server's file size limit, if you are using nginx update the "client_max_body_size 300M" Or you can do it by updating the site's php.ini file with this "upload_max_filesize = 100M
post_max_size = 100M".

There is no issue with this module...

I've tried to replicate the issue in D10.3 But the like & dislike buttons is not showing on the content page, I've configured it for article content.

on viewing the content page, its showing this error at the bottom of the page & db log.

Drupal\Core\Entity\Query\QueryException: Entity queries must explicitly set whether the query should be access checked or not. See Drupal\Core\Entity\Query\QueryInterface::accessCheck(). in Drupal\Core\Entity\Query\Sql\Query->prepare() (line 142 of /app/web/core/lib/Drupal/Core/Entity/Query/Sql/Query.php)
#0 /app/web/core/lib/Drupal/Core/Entity/Query/Sql/Query.php(81): Drupal\Core\Entity\Query\Sql\Query->prepare()
#1 /app/web/modules/contrib/votingapi/src/VoteResultStorage.php(28): Drupal\Core\Entity\Query\Sql\Query->execute()
#2 /app/web/modules/contrib/like_and_dislike/like_and_dislike.module(65): Drupal\votingapi\VoteResultStorage->getEntityResults('node', '113', 'like', 'vote_sum')
#3 /app/web/modules/contrib/like_and_dislike/src/LikeDislikeVoteBuilder.php(75): like_and_dislike_get_votes(Object(Drupal\node\Entity\Node))
#4 [internal function]: Drupal\like_and_dislike\LikeDislikeVoteBuilder->build('node', '113')
#5 /app/web/core/lib/Drupal/Core/Security/DoTrustedCallbackTrait.php(113): call_user_func_array(Array, Array)
#6 /app/web/core/lib/Drupal/Core/Render/Renderer.php(870): Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #lazy_bu...', 'exception', 'Drupal\\Core\\Ren...')
#7 /app/web/core/lib/Drupal/Core/Render/Renderer.php(411): Drupal\Core\Render\Renderer->doCallback('#lazy_builder', 'like_and_dislik...', Array)
#8 /app/web/core/lib/Drupal/Core/Render/Renderer.php(248): Drupal\Core\Render\Renderer->doRender(Array, true)
#9 /app/web/core/lib/Drupal/Core/Render/Renderer.php(165): Drupal\Core\Render\Renderer->render(Array, true)
#10 /app/web/core/lib/Drupal/Core/Render/Renderer.php(638): Drupal\Core\Render\Renderer->Drupal\Core\Render\{closure}()
#11 /app/web/core/lib/Drupal/Core/Render/Renderer.php(164): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#12 /app/web/core/lib/Drupal/Core/Render/Renderer.php(191): Drupal\Core\Render\Renderer->renderInIsolation(Array)
#13 /app/web/core/lib/Drupal/Core/Render/Renderer.php(228): Drupal\Core\Render\Renderer->doRenderPlaceholder(Array)
#14 /app/web/core/modules/big_pipe/src/Render/BigPipe.php(697): Drupal\Core\Render\Renderer->renderPlaceholder('callback=like_a...', Array)
#15 /app/web/core/modules/big_pipe/src/Render/BigPipe.php(524): Drupal\big_pipe\Render\BigPipe->renderPlaceholder('callback=like_a...', Array)
#16 [internal function]: Drupal\big_pipe\Render\BigPipe->Drupal\big_pipe\Render\{closure}()
#17 /app/web/core/modules/big_pipe/src/Render/BigPipe.php(531): Fiber->start()
#18 /app/web/core/modules/big_pipe/src/Render/BigPipe.php(283): Drupal\big_pipe\Render\BigPipe->sendPlaceholders(Array, Array, Object(Drupal\Core\Asset\AttachedAssets))
#19 /app/web/core/modules/big_pipe/src/Render/BigPipeResponse.php(113): Drupal\big_pipe\Render\BigPipe->sendContent(Object(Drupal\big_pipe\Render\BigPipeResponse))
#20 /app/vendor/symfony/http-foundation/Response.php(423): Drupal\big_pipe\Render\BigPipeResponse->sendContent()
#21 /app/web/index.php(20): Symfony\Component\HttpFoundation\Response->send()
#22 {main}

the problem is in .module file

function like_and_dislike_get_votes(EntityInterface $entity) {
  /** @var \Drupal\votingapi\VoteResultStorageInterface $vote_result_storage */
  $vote_result_storage = \Drupal::entityTypeManager()->getStorage('vote_result');

  // Get like votes.
  $like = $vote_result_storage->getEntityResults($entity->getEntityTypeId(), $entity->id(), 'like', 'vote_sum');
  $likes = !empty($like) ? (int) current($like)->getValue() : 0;

  // Get dislike votes.
  $dislike = $vote_result_storage->getEntityResults($entity->getEntityTypeId(), $entity->id(), 'dislike', 'vote_sum');
  $dislikes = !empty($dislike) ? (int) current($dislike)->getValue() : 0;

Even after installing the module the tables 'vote_result', 'vote' was not created in db

@carstenhager have you checked? Is it working with or without the patch?

Updated the Twitter link with X...

Converted the VotingApiWidget annotation to an attribute, Can't find the discovery plugin...

Added a config field to configure "items per page" in reports.
Added update hook for config entity...

@aisforaaron or @generalredneck Please review this MR...

Its working after applying the patch.
Please find the attached SR with it.

Can't replicate the issue by following the mentioned steps.

Need more info.

Its working fine without any issue..

I've tested the patch of #2.
Its working.

Hence raised the MR..

Sourav_Paul → made their first commit to this issue’s fork.

Sourav_Paul → changed the visibility of the branch 3467117-fullscreen-stopped-working to hidden.

Sourav_Paul → made their first commit to this issue’s fork.

Sourav_Paul → changed the visibility of the branch 3467051-compatibility-with-D11 to hidden.

Tested the patch & raised a MR for the fix..

Sourav_Paul → made their first commit to this issue’s fork.

@Prashant.c

I retested it on Drupal 11.0.0-rc1 with Project Browser 2.0.0-alpha2.
& yes filters are not working for "Drupal core" tab..

Attaching screen recording link: https://www.awesomescreenshot.com/video/30323049?key=ccd0a70dfcc69d680b5...

attaching site's composer.json for reference

{
    "name": "drupal/recommended-project",
    "description": "Project template for Drupal projects with a relocated document root",
    "type": "project",
    "license": "GPL-2.0-or-later",
    "homepage": "https://www.drupal.org/project/drupal",
    "support": {
        "docs": "https://www.drupal.org/docs/user_guide/en/index.html",
        "chat": "https://www.drupal.org/node/314178"
    },
    "repositories": [
        {
            "type": "composer",
            "url": "https://packages.drupal.org/8"
        }
    ],
    "require": {
        "composer/installers": "^2.0",
        "drupal/admin_toolbar": "^3.5",
        "drupal/core-composer-scaffold": "^11",
        "drupal/core-project-message": "^11",
        "drupal/core-recommended": "^11",
        "drupal/project_browser": "^2.0@alpha",
        "drupal/upgrade_status": "^4.3",
        "drush/drush": "^13"
    },
    "conflict": {
        "drupal/drupal": "*"
    },
    "minimum-stability": "dev",
    "prefer-stable": true,
    "config": {
        "allow-plugins": {
            "composer/installers": true,
            "drupal/core-composer-scaffold": true,
            "drupal/core-project-message": true,
            "phpstan/extension-installer": true,
            "dealerdirect/phpcodesniffer-composer-installer": true,
            "php-http/discovery": true
        },
        "sort-packages": true
    },
    "extra": {
        "drupal-scaffold": {
            "locations": {
                "web-root": "web/"
            }
        },
        "installer-paths": {
            "web/core": [
                "type:drupal-core"
            ],
            "web/libraries/{$name}": [
                "type:drupal-library"
            ],
            "web/modules/contrib/{$name}": [
                "type:drupal-module"
            ],
            "web/profiles/contrib/{$name}": [
                "type:drupal-profile"
            ],
            "web/themes/contrib/{$name}": [
                "type:drupal-theme"
            ],
            "drush/Commands/contrib/{$name}": [
                "type:drupal-drush"
            ],
            "web/modules/custom/{$name}": [
                "type:drupal-custom-module"
            ],
            "web/profiles/custom/{$name}": [
                "type:drupal-custom-profile"
            ],
            "web/themes/custom/{$name}": [
                "type:drupal-custom-theme"
            ]
        },
        "drupal-core-project-message": {
            "include-keys": [
                "homepage",
                "support"
            ],
            "post-create-project-cmd-message": [
                "<bg=blue;fg=white>                                                         </>",
                "<bg=blue;fg=white>  Congratulations, you’ve installed the Drupal codebase  </>",
                "<bg=blue;fg=white>  from the drupal/recommended-project template!          </>",
                "<bg=blue;fg=white>                                                         </>",
                "",
                "<bg=yellow;fg=black>Next steps</>:",
                "  * Install the site: https://www.drupal.org/docs/installing-drupal",
                "  * Read the user guide: https://www.drupal.org/docs/user_guide/en/index.html",
                "  * Get support: https://www.drupal.org/support",
                "  * Get involved with the Drupal community:",
                "      https://www.drupal.org/getting-involved",
                "  * Remove the plugin that prints this message:",
                "      composer remove drupal/core-project-message"
            ]
        }
    },
    "require-dev": {
        "palantirnet/drupal-rector": "^0.20.3"
    }
}

re-opening this ticket.

@Prashant.c I am not facing this issue on Drupal 11.0.0-rc1 and Project Browser 2.0.0-alpha2.
Please find the screen recording with it.

attaching my composer.json for your reference

{
    "name": "drupal/recommended-project",
    "description": "Project template for Drupal projects with a relocated document root",
    "type": "project",
    "license": "GPL-2.0-or-later",
    "homepage": "https://www.drupal.org/project/drupal",
    "support": {
        "docs": "https://www.drupal.org/docs/user_guide/en/index.html",
        "chat": "https://www.drupal.org/node/314178"
    },
    "repositories": [
        {
            "type": "composer",
            "url": "https://packages.drupal.org/8"
        }
    ],
    "require": {
        "composer/installers": "^2.0",
        "drupal/admin_toolbar": "^3.5",
        "drupal/core-composer-scaffold": "^11",
        "drupal/core-project-message": "^11",
        "drupal/core-recommended": "^11",
        "drupal/project_browser": "^2.0@alpha",
        "drupal/upgrade_status": "^4.3",
        "drush/drush": "^13"
    },
    "conflict": {
        "drupal/drupal": "*"
    },
    "minimum-stability": "dev",
    "prefer-stable": true,
    "config": {
        "allow-plugins": {
            "composer/installers": true,
            "drupal/core-composer-scaffold": true,
            "drupal/core-project-message": true,
            "phpstan/extension-installer": true,
            "dealerdirect/phpcodesniffer-composer-installer": true,
            "php-http/discovery": true
        },
        "sort-packages": true
    },
    "extra": {
        "drupal-scaffold": {
            "locations": {
                "web-root": "web/"
            }
        },
        "installer-paths": {
            "web/core": [
                "type:drupal-core"
            ],
            "web/libraries/{$name}": [
                "type:drupal-library"
            ],
            "web/modules/contrib/{$name}": [
                "type:drupal-module"
            ],
            "web/profiles/contrib/{$name}": [
                "type:drupal-profile"
            ],
            "web/themes/contrib/{$name}": [
                "type:drupal-theme"
            ],
            "drush/Commands/contrib/{$name}": [
                "type:drupal-drush"
            ],
            "web/modules/custom/{$name}": [
                "type:drupal-custom-module"
            ],
            "web/profiles/custom/{$name}": [
                "type:drupal-custom-profile"
            ],
            "web/themes/custom/{$name}": [
                "type:drupal-custom-theme"
            ]
        },
        "drupal-core-project-message": {
            "include-keys": [
                "homepage",
                "support"
            ],
            "post-create-project-cmd-message": [
                "<bg=blue;fg=white>                                                         </>",
                "<bg=blue;fg=white>  Congratulations, you’ve installed the Drupal codebase  </>",
                "<bg=blue;fg=white>  from the drupal/recommended-project template!          </>",
                "<bg=blue;fg=white>                                                         </>",
                "",
                "<bg=yellow;fg=black>Next steps</>:",
                "  * Install the site: https://www.drupal.org/docs/installing-drupal",
                "  * Read the user guide: https://www.drupal.org/docs/user_guide/en/index.html",
                "  * Get support: https://www.drupal.org/support",
                "  * Get involved with the Drupal community:",
                "      https://www.drupal.org/getting-involved",
                "  * Remove the plugin that prints this message:",
                "      composer remove drupal/core-project-message"
            ]
        }
    },
    "require-dev": {
        "palantirnet/drupal-rector": "^0.20.3"
    }
}

Hence closing this...
Feel free to open if you are still facing this issue..

Thanks @fishfree I've successfully recreated the error by following your steps.
issue resolved by applying the patch of #6.

Raised an MR for the fix..

Sourav_Paul → changed the visibility of the branch 3464376-null-given-in-array_merge() to hidden.

Awesome..

I've applied the MR3.
there is an error for this file "src/Form/MDSliderImageForm.php" when applying the patch..
applied the patch on module version 1.5.4

curl https://git.drupalcode.org/project/md_slider/-/merge_requests/3.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  175k    0  175k    0     0   150k      0 --:--:--  0:00:01 --:--:--  151k
Checking patch .gitlab-ci.yml...
Checking patch md_slider.install...
Checking patch md_slider.module...
Checking patch src/Ajax/ImageDialogSave.php...
Checking patch src/Controller/MDSliderController.php...
error: while searching for:
<?php

/**
 * @file
 * Contains \Drupal\md_slider\Controller\MDSliderController.
 */

namespace Drupal\md_slider\Controller;

use Drupal\Core\Url;
use Drupal\Core\Controller\ControllerBase;
use Drupal\md_slider\MDSlider;
use Drupal\md_slider\MDSliderDataBase;
use Drupal\md_slider\MDCommon;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Response;
use Drupal\file\Entity\File;
use Drupal\imce\Imce;
use Drupal\Tests;
class MDSliderController extends ControllerBase {

  /**
   *
   */
  public function listMDSlider() {
    $all_slider = MDSliderDataBase::loadAll('md_sliders');
    $header = array(
      'slider-name' => t('Slider Name'),
      'slider-description' => t('Description'),
      'slider-operations' => t('Operations')
    );
    $rows = array();
    foreach ($all_slider as $index => $slide) {
      $rows[$index]['slider-name'] = $slide->title;
      $rows[$index]['slider-description'] = $slide->description;
      $operations = array(
        '#type' => 'operations',
        '#links' => array(
          'config' => array(
            'url' => Url::fromRoute('md_slider.admin.configure', ['slider' => $slide->machine_name]),
            'title' => 'Configuration'
          ),
          'edit' => array(
            'url' => Url::fromRoute('md_slider.admin.edit', ['slider' => $slide->machine_name]),
            'title' => 'Edit '
          ),
          'delete' => array(
            'url' => Url::fromRoute('md_slider.admin.delete', ['slider' => $slide->machine_name]),
            'title' => 'Delete'
          ),
          'clone' => array(
            'url' => Url::fromRoute('md_slider.admin.clone', ['slider' => $slide->machine_name]),
            'title' => 'Clone'
          ),
        )
      );
      $rows[$index]['slider-operations'] = array('data' => $operations);
    }
	//Url::fromRoute
    return array(
      '#theme' => 'table',
      '#header' => $header,
      '#rows' => $rows,
      '#empty' => t('No MegaSlider available. <a href="@link">Add MegaSlider</a>.', 
	  //array('@link' => \Drupal::url('md_slider.admin.add'))),
	  array('@link' => Url::fromRoute('md_slider.admin.add')->toString())),
      '#attributes' => array('id' => 'md-slider'),
    );
  }

  /**
   * @param $slider
   * @return array
   */
  public function configMDSlider($slider) {
    $MDSlider = new MDSlider();
    $MDSlider->getDataSlider($slider);
    $form = \Drupal::formBuilder()
      ->getForm('\Drupal\md_slider\Form\MDSliderConfigForm', $MDSlider);
    return $form;
  }


  /**
   * @param $slider
   */
  public function editMDSlider($slider) {
    $MDSlider = new MDSlider();
    $MDSlider->getDataSlider($slider);
    $build['form'] = \Drupal::formBuilder()
      ->getForm('\Drupal\md_slider\Form\MDSliderEditForm', $MDSlider);
    $build['slide_settings'] = array(
      '#theme' => 'slide_settings',
    );
    /*
	$json_url = \Drupal::url('md_slider.admin.json_response', array(), array('absolute' => TRUE));
    $html_url = \Drupal::url('md_slider.admin.html_response', array(), array('absolute' => TRUE));
    $image_url = \Drupal::url('md_slider.admin.image', array(), array('absolute' => TRUE));
	*/
	$json_url = Url::fromRoute('md_slider.admin.json_response')->toString();
	$html_url = Url::fromRoute('md_slider.admin.html_response')->toString();
	$image_url = Url::fromRoute('md_slider.admin.image')->toString();
    $build['#attached']['drupalSettings']['MDSlider']['jsonConfigURL'] = $json_url;
    $build['#attached']['drupalSettings']['MDSlider']['htmlConfigURL'] = $html_url;
    $build['#attached']['drupalSettings']['MDSlider']['imageConfigURL'] = $image_url;
    return $build;
  }

  public function jsonResponse() {
    $action = isset($_POST['action']) ? $_POST['action'] : NULL;
    $response = '';
    switch ($action) {
      case 'bgSlider':
        $fid = -1;
        $slid = -1;
        if (isset($_POST['fid'])) {
          $fid = $_POST['fid'];
        }

        if (isset($_POST['slider_id'])) {
          $slid = urldecode($_POST['slider_id']);
        }

      
error: patch failed: src/Controller/MDSliderController.php:1
error: src/Controller/MDSliderController.php: patch does not apply
Checking patch src/Form/MDSliderCloneForm.php...
Checking patch src/Form/MDSliderConfigForm.php...
Checking patch src/Form/MDSliderDeleteForm.php...
Checking patch src/Form/MDSliderEditForm.php...
Checking patch src/Form/MDSliderExportForm.php...
Checking patch src/Form/MDSliderImageForm.php...
error: while searching for:
  public function submitForm(array &$form, FormStateInterface $form_state) {
    $response = new AjaxResponse();

    $fid = $form_state->getValue(array('fid', 0));
    if (!empty($fid)) {
      $file = $this->fileStorage->load($fid);
      $file->setPermanent();
      $this->fileStorage->save($file);
	    $file_url =\Drupal::service('file_url_generator')->generateAbsoluteString($file->getFileUri()) ;
      // Transform absolute image URLs to relative image URLs: prevent problems
      // on multisite set-ups and prevent mixed content errors.
	  $file_url =  \Drupal::service('file_url_generator')->transformRelative($file_url);
      $form_state->setValue(array('attributes', 'src'), $file_url);
      $form_state->setValue(array('attributes', 'data-entity-uuid'), $file->uuid());
      $form_state->setValue(array('attributes', 'data-entity-type'), 'file');
    }
    // When the alt attribute is set to two double quotes, transform it to the
    // empty string: two double quotes signify "empty alt attribute". See above.
    if (trim($form_state->getValue(array('attributes', 'alt'))) === '""') {
      $form_state->setValue(array('attributes', 'alt'), '');
    }

    if ($form_state->getErrors()) {

error: patch failed: src/Form/MDSliderImageForm.php:138
error: src/Form/MDSliderImageForm.php: patch does not apply
Checking patch src/Form/MDSliderImportForm.php...
Checking patch src/MDCommon.php...
Checking patch src/MDSlide.php...
Checking patch src/MDSlider.php...
Checking patch src/MDSliderDataBase.php...
Checking patch src/MDSliderInterface.php...
Checking patch src/Plugin/Block/MDSliderBlock.php...
Checking patch src/Plugin/Derivative/MDSliderBlock.php...
Checking patch src/Plugin/Field/FieldFormatter/MDSliderFormatter.php...
Checking patch src/Plugin/Field/FieldType/FieldMDSlider.php...
Checking patch src/Plugin/Field/FieldWidget/MDSliderWidget.php...
Checking patch src/Slider/MDSliderExport.php...
Checking patch src/Slider/MDSliderImport.php...
Checking patch src/Slider/MDSliderRenderCss.php...
Checking patch src/Slider/MDSliderZip.php...

I've applied the patch & it's working as described...

IMO: the log message could be more precise by showing the actual file name, It would be more useful for site administrators.

Attaching SS with this:

phpcs issue is resolved after applying the patch...

attaching ss with this comment.

@deepak5423 gitlab-ci code is already added by maintainer in this commit: https://git.drupalcode.org/project/scanner/-/commit/34997ae64eea08270ede...

hence closing this...

After applying patch, still found some phpcs warnings...
hence, reopening this issue.

Sharing ss: