Kolkata
Account created on 10 October 2022, over 2 years ago
  • Junior Software Developer at Innoraft 
#

Merge Requests

More

Recent comments

🇮🇳India sourav_paul Kolkata

@mrharolda Thanks for this novel solution, But facing same issue in D10 with views filter for encrypted field, So It would be helpful if we get a release for D10.

& @tedbow it would be nice if you could add this module: https://www.drupal.org/project/field_encrypt_views_filters as sub module of field_encrypt

🇮🇳India sourav_paul Kolkata

@cholasni Could you please provide proper reproducing step?

As i'm not getting any issue after clearing the cache & i've also visited the mentioned urls in which I've got 404 as it not a valid path
I'm using drupal_CMS 1.0.0-rc1

🇮🇳India sourav_paul Kolkata

@bluegeek9 I'm still getting this kind of similar error even after updating the module 2.21 -> 2.23, while tried to rebuild device using drush visitors:rebuild:device as you mentioned earlier in this https://www.drupal.org/project/visitors/issues/3456340#comment-15669444 💬 Historical data not visible after upgrade from 2.16 to 2.19 Active to fix historical data visible issue.

Could you please help me?

🇮🇳India sourav_paul Kolkata

I've fixed the issue.
It would be great, if anyone could refractor test on the basis of above change...

🇮🇳India sourav_paul Kolkata

I've retested the patch.
The patch applied cleanly on 11.x & it fixed the site slogan visibility issue..

Attaching ss:

Hence moving it to RTBC.

Thanks @arunkumark & @tirupati_singh

🇮🇳India sourav_paul Kolkata

@frondeau I've fixed the issue.
Could you please test & verify the mr from your end...

Thanks...

🇮🇳India sourav_paul Kolkata

I've figured out some issues, which I've mentioned in the attach SS.
specially look into the menu section which makes the site UX so bad.

my screen resolution 1280px*780px

Look forward to discuss..
SS:

Thanks..

🇮🇳India sourav_paul Kolkata

Thank you so much @quietone for explaining regarding novice tag & policies, I'll keep it mind form next time...

But, have a question that can anyone(who isn't novice) review novice issue ?

🇮🇳India sourav_paul Kolkata

@nigelcunningham facing same error after updating these modules drupal/printable (3.0.2 => 3.1.3), drupal/pdf_api (2.4.1 => 2.4.4), using drupal 10.3.10, I've already got updates by running drush updb & also cleared the cache...

🇮🇳India sourav_paul Kolkata

Okay I understand, But I don't feel its a good idea as if we cache url path with args, it could create problem with contextual filtration of view.

Welcome for Opinions...

🇮🇳India sourav_paul Kolkata

I've made the necessary changes, please review the MR..

🇮🇳India sourav_paul Kolkata

sourav_paul changed the visibility of the branch 11.x to hidden.

🇮🇳India sourav_paul Kolkata

sourav_paul changed the visibility of the branch 11.x to active.

🇮🇳India sourav_paul Kolkata

working on to port changes into 10.4.x

🇮🇳India sourav_paul Kolkata

I've checked that updated stylelint-formatter: gitlab-formatters/stylelint-formatter-gitlab is already in there..

Hence please move it into correct state...

🇮🇳India sourav_paul Kolkata

Replaced those life-cycle links with updated links as mentioned..

🇮🇳India sourav_paul Kolkata

It would be appreciating, if anyone could write the test coverage.

🇮🇳India sourav_paul Kolkata

I've tested the MR!86, which fixed the issue..
Hence moving it to RTBC..

Attaching ss:

before:

after:

🇮🇳India sourav_paul Kolkata

Closing this issue
As cannot reproduce the issue using mentioned steps & there is no further comment from reporter.

🇮🇳India sourav_paul Kolkata

Tried to applied the patch but its giving error..

🇮🇳India sourav_paul Kolkata

@avpaderno & @akulsaxena I've tested both MR!5 & MR!6 on the branch 1.0.x

MR!5 test result:

curl https://git.drupalcode.org/project/parameters/-/merge_requests/5.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 48118    0 48118    0     0  70738      0 --:--:-- --:--:-- --:--:-- 70657
Checking patch .gitlab-ci.yml...
Checking patch modules/parameters_ui/src/Controller/ParametersUiController.php...
Checking patch modules/parameters_ui/src/Form/ParameterDeleteForm.php...
Checking patch modules/parameters_ui/src/Form/ParameterForm.php...
Checking patch modules/parameters_ui/src/Form/ParametersCollectionAddForm.php...
Checking patch modules/parameters_ui/src/Form/ParametersCollectionForm.php...
Hunk #4 succeeded at 165 (offset 7 lines).
Hunk #5 succeeded at 239 (offset 7 lines).
Hunk #6 succeeded at 404 (offset 7 lines).
Checking patch modules/parameters_ui/src/Form/ParametersCollectionLockForm.php...
Checking patch modules/parameters_ui/src/Form/ParametersCollectionUnlockForm.php...
Checking patch modules/parameters_ui/src/ParametersUiListBuilder.php...
Checking patch modules/parameters_ui/src/Routing/ParametersUiRouteEnhancer.php...
Checking patch parameters.install...
Checking patch parameters.module...
Checking patch src/Entity/ParametersCollectionStorage.php...
Checking patch src/EventSubscriber/ParametersConfigOverrideSubscriber.php...
Checking patch src/Exception/ParameterNotFoundException.php...
Checking patch src/Internals/ContentSerializationCompilerPass.php...
Checking patch src/Internals/ItemSortTrait.php...
Checking patch src/Normalizer/Legacy/ParametersContentEntityNormalizer.php...
Checking patch src/Normalizer/ParametersContentEntityNormalizer.php...
Checking patch src/Normalizer/ParametersEntityReferenceFieldItemNormalizer.php...
Checking patch src/ParameterRepository.php...
error: while searching for:
use Drupal\parameters\Event\CollectionsPreparationEvent;
use Drupal\parameters\Event\ParameterEvents;
use Drupal\parameters\Exception\ParameterNotFoundException;
use Drupal\parameters\Plugin\ParameterPluginCollection;
use Drupal\parameters\Plugin\ParameterInterface;
use Drupal\parameters\Plugin\ParameterManager;
use Drupal\parameters\Plugin\PropertyParameterInterface;
use Symfony\Contracts\EventDispatcher\EventDispatcherInterface;


error: patch failed: src/ParameterRepository.php:10
error: src/ParameterRepository.php: patch does not apply
Checking patch src/Plugin/Derivative/Parameter/ContentDeriver.php...
Checking patch src/Plugin/Parameter/Bundles.php...
Hunk #1 succeeded at 155 (offset 2 lines).
Hunk #2 succeeded at 259 (offset 2 lines).
Hunk #3 succeeded at 277 (offset 2 lines).
Hunk #4 succeeded at 347 (offset 2 lines).
Checking patch src/Plugin/Parameter/Content.php...
error: while searching for:
use Drupal\parameters\Entity\ParametersCollectionStorage;
use Drupal\parameters\Internals\NormalizerContainer;
use Drupal\parameters\Plugin\EntityParameterInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Drupal\parameters\Plugin\ParameterBase;
use Drupal\parameters\Plugin\ParameterInterface;
use Drupal\parameters\Plugin\ParameterManager;
use Drupal\parameters\Plugin\PropertyParameterInterface;
use Drupal\parameters\Plugin\UsageParameterInterface;
use Symfony\Component\Serializer\Serializer;
use Drupal\user\RoleInterface;
use Drupal\user\UserInterface;

/**
 * Defines content as parameter.

error: patch failed: src/Plugin/Parameter/Content.php:31
error: src/Plugin/Parameter/Content.php: patch does not apply
Checking patch src/Plugin/Parameter/Fields.php...
Hunk #1 succeeded at 274 (offset 2 lines).
Hunk #2 succeeded at 437 (offset 2 lines).
Hunk #3 succeeded at 455 (offset 2 lines).
Checking patch src/Plugin/Parameter/Http.php...
Hunk #1 succeeded at 20 (offset 2 lines).
Hunk #2 succeeded at 71 (offset 1 line).
Hunk #3 succeeded at 103 (offset 1 line).
Hunk #4 succeeded at 272 (offset 1 line).
Hunk #5 succeeded at 293 (offset 1 line).
Hunk #6 succeeded at 314 (offset 1 line).
Hunk #7 succeeded at 326 (offset 1 line).
Hunk #8 succeeded at 335 (offset 1 line).
Hunk #9 succeeded at 348 (offset 1 line).
Hunk #10 succeeded at 490 (offset 1 line).
Hunk #11 succeeded at 626 (offset 1 line).
Checking patch src/Plugin/Parameter/Increment.php...
Hunk #1 succeeded at 27 (offset 1 line).
Checking patch src/Plugin/Parameter/NullObject.php...
Hunk #1 succeeded at 36 (offset 1 line).
Checking patch src/Plugin/Parameter/Roles.php...
Hunk #1 succeeded at 165 (offset 8 lines).
Hunk #2 succeeded at 286 (offset 8 lines).
Hunk #3 succeeded at 315 (offset 8 lines).
Checking patch src/Plugin/Parameter/Types.php...
Hunk #1 succeeded at 264 (offset 1 line).
Checking patch src/Plugin/ParameterManager.php...
error: while searching for:
namespace Drupal\parameters\Plugin;

use Drupal\Component\Plugin\PluginManagerInterface;
use Drupal\Core\Plugin\DefaultPluginManager;
use Drupal\Core\Cache\CacheBackendInterface;
use Drupal\Core\Extension\ModuleHandlerInterface;

/**
 * The manager for parameter plugins.

error: patch failed: src/Plugin/ParameterManager.php:3
error: src/Plugin/ParameterManager.php: patch does not apply
Checking patch tests/src/Kernel/ParametersTokenTest.php...

MR!6 test result:

curl https://git.drupalcode.org/project/parameters/-/merge_requests/6.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 52512    0 52512    0     0  63637      0 --:--:-- --:--:-- --:--:-- 63573
Checking patch .gitlab-ci.yml...
Checking patch modules/parameters_ui/src/Controller/ParametersUiController.php...
Checking patch modules/parameters_ui/src/Form/ParameterDeleteForm.php...
Checking patch modules/parameters_ui/src/Form/ParameterForm.php...
Checking patch modules/parameters_ui/src/Form/ParametersCollectionAddForm.php...
Checking patch modules/parameters_ui/src/Form/ParametersCollectionForm.php...
Hunk #4 succeeded at 165 (offset 7 lines).
Hunk #5 succeeded at 239 (offset 7 lines).
Hunk #6 succeeded at 404 (offset 7 lines).
Checking patch modules/parameters_ui/src/Form/ParametersCollectionLockForm.php...
Checking patch modules/parameters_ui/src/Form/ParametersCollectionUnlockForm.php...
Checking patch modules/parameters_ui/src/ParametersUiListBuilder.php...
Checking patch modules/parameters_ui/src/Routing/ParametersUiRouteEnhancer.php...
Checking patch parameters.install...
Checking patch src/Entity/ParametersCollectionStorage.php...
Checking patch src/EventSubscriber/ParametersConfigOverrideSubscriber.php...
Checking patch src/Exception/ParameterNotFoundException.php...
Checking patch src/Internals/ContentSerializationCompilerPass.php...
Checking patch src/Normalizer/Legacy/ParametersContentEntityNormalizer.php...
Checking patch src/Normalizer/ParametersContentEntityNormalizer.php...
Checking patch src/Normalizer/ParametersEntityReferenceFieldItemNormalizer.php...
Checking patch src/ParameterRepository.php...
error: while searching for:
use Drupal\parameters\Event\CollectionsPreparationEvent;
use Drupal\parameters\Event\ParameterEvents;
use Drupal\parameters\Exception\ParameterNotFoundException;
use Drupal\parameters\Plugin\ParameterPluginCollection;
use Drupal\parameters\Plugin\ParameterInterface;
use Drupal\parameters\Plugin\ParameterManager;
use Drupal\parameters\Plugin\PropertyParameterInterface;
use Symfony\Contracts\EventDispatcher\EventDispatcherInterface;


error: patch failed: src/ParameterRepository.php:10
error: src/ParameterRepository.php: patch does not apply
Checking patch src/Plugin/Derivative/Parameter/ContentDeriver.php...
Checking patch src/Plugin/Parameter/Bundles.php...
Hunk #2 succeeded at 155 (offset 11 lines).
Hunk #3 succeeded at 259 (offset 11 lines).
Hunk #4 succeeded at 277 (offset 11 lines).
Checking patch src/Plugin/Parameter/Content.php...
error: while searching for:
use Drupal\parameters\Entity\ParametersCollectionStorage;
use Drupal\parameters\Internals\NormalizerContainer;
use Drupal\parameters\Plugin\EntityParameterInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Drupal\parameters\Plugin\ParameterBase;
use Drupal\parameters\Plugin\ParameterInterface;
use Drupal\parameters\Plugin\ParameterManager;
use Drupal\parameters\Plugin\PropertyParameterInterface;
use Drupal\parameters\Plugin\UsageParameterInterface;
use Symfony\Component\Serializer\Serializer;
use Drupal\user\RoleInterface;
use Drupal\user\UserInterface;

/**
 * Defines content as parameter.

error: patch failed: src/Plugin/Parameter/Content.php:31
error: src/Plugin/Parameter/Content.php: patch does not apply
Checking patch src/Plugin/Parameter/Fields.php...
Hunk #2 succeeded at 274 (offset 10 lines).
Hunk #3 succeeded at 437 (offset 10 lines).
Hunk #4 succeeded at 455 (offset 10 lines).
Checking patch src/Plugin/Parameter/Http.php...
Hunk #2 succeeded at 20 (offset 2 lines).
Hunk #3 succeeded at 71 (offset 1 line).
Hunk #4 succeeded at 103 (offset 1 line).
Hunk #5 succeeded at 272 (offset 1 line).
Hunk #6 succeeded at 293 (offset 1 line).
Hunk #7 succeeded at 314 (offset 1 line).
Hunk #8 succeeded at 326 (offset 1 line).
Hunk #9 succeeded at 335 (offset 1 line).
Hunk #10 succeeded at 348 (offset 1 line).
Hunk #11 succeeded at 490 (offset 1 line).
Hunk #12 succeeded at 626 (offset 1 line).
Checking patch src/Plugin/Parameter/Increment.php...
Hunk #1 succeeded at 27 (offset 1 line).
Checking patch src/Plugin/Parameter/NullObject.php...
Hunk #1 succeeded at 36 (offset 1 line).
Checking patch src/Plugin/Parameter/Roles.php...
Hunk #2 succeeded at 165 (offset 17 lines).
Checking patch src/Plugin/Parameter/Types.php...
Checking patch src/Plugin/ParameterManager.php...
error: while searching for:
namespace Drupal\parameters\Plugin;

use Drupal\Component\Plugin\PluginManagerInterface;
use Drupal\Core\Plugin\DefaultPluginManager;
use Drupal\Core\Cache\CacheBackendInterface;
use Drupal\Core\Extension\ModuleHandlerInterface;

/**
 * The manager for parameter plugins.

error: patch failed: src/Plugin/ParameterManager.php:3
error: src/Plugin/ParameterManager.php: patch does not apply

Please have a look...

🇮🇳India sourav_paul Kolkata

@rahul17 you should create other issue for gitlab-ci, it's irrelevant in this issue.

Do you have any confirmation that this module will drop D8 support?

🇮🇳India sourav_paul Kolkata

I've scan the module using upgrade status & made required changes to make it compatible with D11.

🇮🇳India sourav_paul Kolkata

sourav_paul made their first commit to this issue’s fork.

🇮🇳India sourav_paul Kolkata

sourav_paul made their first commit to this issue’s fork.

🇮🇳India sourav_paul Kolkata

I've faced the same issue, this patch fixed the issue, hence raising MR..

🇮🇳India sourav_paul Kolkata

I've test it locally, it works fine..

SS:

🇮🇳India sourav_paul Kolkata

Then @cilefen what could be the best approach?
Please let us know, will work on that..

🇮🇳India sourav_paul Kolkata

@rhovland have you retested the issue?

🇮🇳India sourav_paul Kolkata

It would be appreciated, if anyone could do the test of this fix.

🇮🇳India sourav_paul Kolkata

sourav_paul changed the visibility of the branch 3474139-drupal-11-compatibility to hidden.

🇮🇳India sourav_paul Kolkata

Thank you @anybody for your support,
Sorry for being late as I was bit busy with project work.

I've updated the MR !3 with D11 fixes..

I would appreciate if anyone could test & review this...

🇮🇳India sourav_paul Kolkata

Closing this issue as the module is works as designed.
if anyone faced the same issue please follow the steps mentioned on #2.

Thanks...

🇮🇳India sourav_paul Kolkata

hey @bluegeek9, Could you please review the Mr...

🇮🇳India sourav_paul Kolkata

I will appriciate, if anyone could build test cases for this code changes & fix the phpunit test failing..

🇮🇳India sourav_paul Kolkata

@joachim Could you please review the MR?

🇮🇳India sourav_paul Kolkata

@dhavalpanchal Can't replicate the issue on D10.3 & there is no need to add colorboxAttachmen as it already in developement branch 2.1.x,

Please share proper reproducing steps..

🇮🇳India sourav_paul Kolkata

Facing issue on regenerating phpstan-baseline, I will appreciate if anyone could help by regenerating the baseline...

🇮🇳India sourav_paul Kolkata

sourav_paul changed the visibility of the branch 3483146-add-string-return to hidden.

🇮🇳India sourav_paul Kolkata

I've checked the MR !5 & the patch was applied cleanly.

curl https://git.drupalcode.org/project/addthis_social_share/-/merge_requests/5.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  120k    0  120k    0     0   110k      0 --:--:--  0:00:01 --:--:--  110k
Checking patch .gitlab-ci.yml...
Checking patch addthis_social_share.info.yml...
Checking patch addthis_social_share.links.menu.yml...
Checking patch addthis_social_share.links.task.yml...
Checking patch addthis_social_share.module...
Checking patch addthis_social_share.permissions.yml...
Checking patch addthis_social_share.routing.yml...
Checking patch addthis_social_share.services.yml...
Checking patch config/install/addthis_social_share.settings.advanced.yml...
Checking patch config/install/addthis_social_share.settings.yml...
Checking patch config/schema/addthis_social_share.schema.yml...
Checking patch css/addthis.admin.css...
Checking patch css/addthis.css...
Checking patch js/addthis.js...
Checking patch src/AddThisBasicButtonFormTrait.php...
Checking patch src/AddThisBasicToolboxFormTrait.php...
Checking patch src/AddThisScriptManager.php...
Checking patch src/Element/AddThisBasicButton.php...
Checking patch src/Element/AddThisBasicToolbox.php...
Checking patch src/Form/AddThisSettingsAdvancedForm.php...
Checking patch src/Form/AddThisSettingsForm.php...
Checking patch src/Plugin/Block/AddThisBlock.php...
Checking patch src/Plugin/Field/FieldFormatter/AddThisBasicButtonFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/AddThisBasicToolboxFormatter.php...
Checking patch src/Plugin/Field/FieldFormatter/AddThisFormatter.php...
Checking patch src/Plugin/Field/FieldType/AddThisItem.php...
Checking patch src/Plugin/Field/FieldWidget/AddThisWidget.php...
Checking patch src/Tests/AddThisBaseTest.php...
Checking patch src/Tests/AddThisBlockTest.php...
Checking patch src/Tests/AddThisFieldTest.php...
Checking patch src/Tests/AddThisFieldWebTestBase.php...
Checking patch src/Tests/AddThisPermissionsTest.php...
Checking patch src/Util/AddThisJson.php...
Checking patch templates/addthis-share-toolbox.html.twig...
Applied patch .gitlab-ci.yml cleanly.
Applied patch addthis_social_share.info.yml cleanly.
Applied patch addthis_social_share.links.menu.yml cleanly.
Applied patch addthis_social_share.links.task.yml cleanly.
Applied patch addthis_social_share.module cleanly.
Applied patch addthis_social_share.permissions.yml cleanly.
Applied patch addthis_social_share.routing.yml cleanly.
Applied patch addthis_social_share.services.yml cleanly.
Applied patch config/install/addthis_social_share.settings.advanced.yml cleanly.
Applied patch config/install/addthis_social_share.settings.yml cleanly.
Applied patch config/schema/addthis_social_share.schema.yml cleanly.
Applied patch css/addthis.admin.css cleanly.
Applied patch css/addthis.css cleanly.
Applied patch js/addthis.js cleanly.
Applied patch src/AddThisBasicButtonFormTrait.php cleanly.
Applied patch src/AddThisBasicToolboxFormTrait.php cleanly.
Applied patch src/AddThisScriptManager.php cleanly.
Applied patch src/Element/AddThisBasicButton.php cleanly.
Applied patch src/Element/AddThisBasicToolbox.php cleanly.
Applied patch src/Form/AddThisSettingsAdvancedForm.php cleanly.
Applied patch src/Form/AddThisSettingsForm.php cleanly.
Applied patch src/Plugin/Block/AddThisBlock.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/AddThisBasicButtonFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/AddThisBasicToolboxFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldFormatter/AddThisFormatter.php cleanly.
Applied patch src/Plugin/Field/FieldType/AddThisItem.php cleanly.
Applied patch src/Plugin/Field/FieldWidget/AddThisWidget.php cleanly.
Applied patch src/Tests/AddThisBaseTest.php cleanly.
Applied patch src/Tests/AddThisBlockTest.php cleanly.
Applied patch src/Tests/AddThisFieldTest.php cleanly.
Applied patch src/Tests/AddThisFieldWebTestBase.php cleanly.
Applied patch src/Tests/AddThisPermissionsTest.php cleanly.
Applied patch src/Util/AddThisJson.php cleanly.
Applied patch templates/addthis-share-toolbox.html.twig cleanly.

I've verified that all the phpsc error got fixed using the MR!5.

Hence moving it to RTBC.

Thanks...

🇮🇳India sourav_paul Kolkata

@tirupati_singh Please resolved merged conflict, as can't apply the patch,but successfully recreated the issue...

🇮🇳India sourav_paul Kolkata

@phenaproxima If you have some bandwidth, could you please look into it?

🇮🇳India sourav_paul Kolkata

@berdir Could you please look into it?

🇮🇳India sourav_paul Kolkata

@kala4ek I've Tried to replicate the issue by following steps but can't achieve the redirect loop. Even I've tried different scenarios.
I've tested it on Drupal 10.3.3, PHP 8.3, module dev branch: 8.x-1.x-dev.

"Automatically create redirects when URL aliases are changed." - functionality working fine as expected.

Attaching ss:

Please provide proper reproducing steps...

🇮🇳India sourav_paul Kolkata

Thanks @uttam for your contribution. I've retested the MR, which was applied cleanly.
Drush command working as expected.

Attaching ss:

Hence Moving it to RTBC.

🇮🇳India sourav_paul Kolkata

Even after creating an instance of serializer, as the 4th parameter in the DatabaseBackend::__construct method must be an instance of ObjectAwareSerializationInterface, facing this issue

ArgumentCountError: Too few arguments to function Drupal\tome_static\StaticCache::__construct(), 2 passed in /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 and exactly 3 expected in Drupal\tome_static\StaticCache->__construct() (line 33 of /app/web/modules/contrib/tome/modules/tome_static/src/StaticCache.php).

🇮🇳India sourav_paul Kolkata

I've tested it on drupal 10.3 with module version 4.1 this is working as expected even with default value of select list.

Attaching ss...

Please provide proper issue reproducing steps..

🇮🇳India sourav_paul Kolkata

@lpeidro Nice job...

🇮🇳India sourav_paul Kolkata

hey @BramDriesen, I've changed the function name could you please check & review...

🇮🇳India sourav_paul Kolkata

I don't feel droping onKeydown() is better approach as after doping the function, can't switch project browser tabs using arrow keys Or tab.

Production build 0.71.5 2024