Fix the issues reported by PHPCS

Issue created by @urvashi_vora
Status changed to Needs work over 1 year ago1:18pm 18 April 2023
Comment over 1 year ago →
🇵🇭Philippines clarkssquared
Hi urvashi_vora,

I applied patch https://www.drupal.org/files/issues/2023-04-18/coding-standard-fixes_3.patch → to the "Parameters" module against Version 1.0.x-dev. and noticed that there are still phpcs issues reported

Please see the screenshots attached.

For your review.
Thank you.
Comment over 1 year ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.
Status changed to Needs review over 1 year ago8:38am 15 May 2023
Open in Jenkins → Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8
last update over 1 year ago
2 pass
Comment over 1 year ago →
🇮🇳India Ashutosh Ahirwal India
Providing patch with fixes.
please review.
Status changed to Needs work over 1 year ago9:54am 15 May 2023

🇮🇹Italy apaderno Brescia, 🇮🇹

-      $form_state->setError($form, $this->t('You don\'t have permission to manage this configuration.'));
+      $form_state->setError($form, $this->t("You don\'t have permission to manage this configuration."));

   public function validateForm(array &$form, FormStateInterface $form_state) {
     if (!$this->collection->access('update')) {
-      $form_state->setError($form, $this->t('You don\'t have permission to manage this configuration.'));
+      $form_state->setError($form, $this->t("You don\'t have permission to manage this configuration."));
     }

There is no need to escape the single-quote character, since that is not anymore the string delimiter.

-    $config['name'] = $form_state->getValue('name', $form_state->getValue(['config', 'parameter_name'], $config['name'] ?? ''));
+    $config['name'] = $form_state->getValue('name', $form_state->getValue([
+      'config',
+      'parameter_name',
+    ], $config['name'] ?? ''));

Code lines are allowed to exceed 80 characters, if they are more readable. I find the existing code more readable.

-    if (($form_state->getValue(['config', 'parameter_name'], '') !== '') && $form_state->getValue(['config', 'parameter_name']) !== $parameter_name) {
-      unset($parameters_array[$form_state->getValue(['config', 'parameter_name'], '')]);
+    if (($form_state->getValue([
+      'config', 'parameter_name',
+    ], '') !== '') && $form_state->getValue([
+      'config', 'parameter_name',
+    ]) !== $parameter_name) {
+      unset($parameters_array[$form_state->getValue([
+        'config',
+        'parameter_name',
+      ], '')]);
     }

Control structure conditions are allowed to exceed the 80 characters, if they are more readable. The existing code is more readable.

-   * return \Drupal\Core\StringTranslation\TranslatableMarkup[]
+   * Return \Drupal\Core\StringTranslation\TranslatableMarkup[]
    *   The options.
    */
   public static function options(): array {

return must be changed to @return, not Return.

+  /**
+   * {@inheritdoc}
+   */
   public function onOverrideSave($event) {
     $this->applyChanges($event, 'config_override_save');
   }
 
+  /**
+   * {@inheritdoc}
+   */
   public function onOverrideDelete($event) {
     $this->applyChanges($event, 'config_override_delete');
   }

+  /**
+   * {@inheritdoc}
+   */
   protected function applyChanges($event, string $op): void {

Those methods are not inherited from a parent class, nor defined in an interface. Their documentation comment cannot contain {@inheritdoc}.

-    [$provider, $type, $id] = array_merge(explode('.', $config_name, 3), ['', '']);
+    [$provider, $type, $id] = array_merge(explode('.', $config_name, 3), [
+      '',
+      '',
+    ]);

The existing code is more readable.

+ /**
+ * The UUID for this entity.
+ *
+ * @var string
+ */
+ protected $uuid;

Since that property is initialized with a \Drupal\Component\Uuid\UuidInterface instance, it is not an entity UUID nor can its type be string. The correct description is the same used for the constructor parameter.

+  /**
+   * Constructs a new block form.
+   *

The description for a constructor must start with Constructs a new followed by the class name (including its namespace), and end with object.
Also, since the class for that constructor is ParametersContentEntityNormalizer, which extends ContentEntityNormalizer, the constructor does not construct a new block form.

-   * return string[]
+   * Return string[]
    *   The contained parts.
    */

The tag to use for the return value type is @return.

-        $bundle_label = isset($info['label']) ? ($info['label'] instanceof TranslatableMarkup ? $info['label'] : new TranslatableMarkup((string) $info['label'])) : $bundle;
+        $bundle_label = $info['label'] ?? $bundle;

The changed code is not equivalent to the existing code. The existing code also checks $info['label'] is an instance of TranslatableMarkup.

-   * var \Drupal\Core\Lock\LockBackendInterface
+   * Var \Drupal\Core\Lock\LockBackendInterface.

That line must start with @var. The period at the end is not necessary.

       $values['pass'] = [[
         'value' => $entity->getPassword(),
         'pre_hashed' => TRUE,
-      ]];
+      ],
+      ];

The existing code is already correct.

   /**
    * Submit callback for elements of the user account form.
    *
-   * @param array &$element
-   *   The element being processed.
+   * @param array $form
+   *   The form array to add elements to.
    * @param \Drupal\Core\Form\FormStateInterface $form_state
    *   The form state.
    */

Documentation comments for submission callbacks do not need to describe the parameters they get.

-        $this->logger->warning(t('Lock wait exceeded for endpoint @uri. Now trying to fetch data from it. This may cause more traffic than needed.', ['@url' => $uri]));
+        $this->logger->warning($this->t('Lock wait exceeded for endpoint @uri. Now trying to fetch data from it. This may cause more traffic than needed.', ['@url' => $uri]));
       }

Since that code is changed, the first argument passed to $this->logger->warning() must be changed too: It must be a literal string, not the value returned from $this->t().

-      $this->logger->error(t('Failed to read response body contents from @url. Exception message: @message',
+      $this->logger->error($this->t('Failed to read response body contents from @url. Exception message: @message',
         ['@url' => $uri, '@message' => $e->getMessage()]));

The same holds true for the first argument passed to $this->logger->error().

First commit to issue fork.
Merge request !5Fixed the issues reported by phpcs → (Open) created by realsp
Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8
last update 11 months ago
2 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8
last update 11 months ago
2 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8
last update 11 months ago
2 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8
last update 11 months ago
2 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8
last update 11 months ago
2 pass
Status changed to Needs review 10 months ago3:51pm 12 January 2024
Comment 10 months ago →
🇮🇳India realsp
Status changed to Needs work 10 months ago11:25am 13 January 2024
Comment 10 months ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Assigned to realsp
Comment 10 months ago →
🇮🇳India realsp
Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8
last update 10 months ago
PHPLint Failed
Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.1 & MySQL 8
last update 10 months ago
PHPLint Failed
Issue was unassigned.
Status changed to Needs review 10 months ago6:28am 29 January 2024
Comment 10 months ago →
🇮🇳India realsp
Thanks @apaderno for the suggestions, I've updated the MR, Please review the MR.
Thank you.
Status changed to Needs work 6 months ago1:33pm 29 May 2024

Comment 6 months ago →

a.aaronjake

Hi @realsp,

Applied the plain diff of MR !5 latest version, it applied successfully, however multiple errors/warnings still persist.

parameters git:(1.0.x) curl https://git.drupalcode.org/project/parameters/-/merge_requests/5.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 43464    0 43464    0     0   109k      0 --:--:-- --:--:-- --:--:--  113k
patching file modules/parameters_ui/src/Controller/ParametersUiController.php
patching file modules/parameters_ui/src/Form/ParameterDeleteForm.php
patching file modules/parameters_ui/src/Form/ParameterForm.php
patching file modules/parameters_ui/src/Form/ParametersCollectionAddForm.php
patching file modules/parameters_ui/src/Form/ParametersCollectionForm.php
patching file modules/parameters_ui/src/Form/ParametersCollectionLockForm.php
patching file modules/parameters_ui/src/Form/ParametersCollectionUnlockForm.php
patching file modules/parameters_ui/src/ParametersUiListBuilder.php
patching file modules/parameters_ui/src/Routing/ParametersUiRouteEnhancer.php
patching file parameters.install
patching file src/Entity/ParametersCollectionStorage.php
patching file src/EventSubscriber/ParametersConfigOverrideSubscriber.php
patching file src/Exception/ParameterNotFoundException.php
patching file src/Internals/ContentSerializationCompilerPass.php
patching file src/Normalizer/ParametersContentEntityNormalizer.php
patching file src/ParameterRepository.php
patching file src/Plugin/Derivative/Parameter/ContentDeriver.php
patching file src/Plugin/Parameter/Bundles.php
patching file src/Plugin/Parameter/Content.php
patching file src/Plugin/Parameter/Fields.php
patching file src/Plugin/Parameter/Http.php
patching file src/Plugin/Parameter/Increment.php
patching file src/Plugin/Parameter/NullObject.php
patching file src/Plugin/Parameter/Roles.php
patching file src/Plugin/Parameter/Types.php
patching file src/Plugin/ParameterManager.php
patching file tests/src/Kernel/ParametersTokenTest.php
➜  parameters git:(1.0.x) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig parameters

FILE: ...odules/contrib/parameters/modules/parameters_ui/src/Form/ParameterForm.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
  21 | ERROR | [x] Use statements should be sorted alphabetically. The first
     |       |     wrong one is Drupal\Core\Session\AccountInterface.
 405 | ERROR | [ ] The array declaration extends to column 126 (the limit is
     |       |     120). The array content should be split up over multiple
     |       |     lines
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...l-orgissue/web/modules/contrib/parameters/src/Plugin/Parameter/Content.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 10 WARNINGS AFFECTING 12 LINES
--------------------------------------------------------------------------------
  186 | WARNING | [ ] Unused variable $bundle.
  189 | WARNING | [ ] Unused variable $bundle.
  357 | WARNING | [ ] Unused variable $cleanupFieldValues.
  358 | WARNING | [ ] Unused variable $normalizeNewEntities.
  363 | WARNING | [ ] Unused variable $cleanupFieldValues.
  364 | WARNING | [ ] Unused variable $normalizeNewEntities.
  381 | WARNING | [ ] Unused variable $cleanupFieldValues.
  382 | WARNING | [ ] Unused variable $normalizeNewEntities.
  387 | WARNING | [ ] Unused variable $cleanupFieldValues.
  388 | WARNING | [ ] Unused variable $normalizeNewEntities.
  561 | ERROR   | [x] Closing parenthesis of array declaration must be on a new
      |         |     line
 1232 | ERROR   | [x] Closing parenthesis of array declaration must be on a new
      |         |     line
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...rib/parameters/src/Normalizer/Legacy/ParametersContentEntityNormalizer.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 128 | ERROR | The array declaration extends to column 132 (the limit is 120).
     |       | The array content should be split up over multiple lines
--------------------------------------------------------------------------------

Time: 4.35 secs; Memory: 20MB

Kindly check

Thanks,
Jake

First commit to issue fork.
Assigned to akshaydalvi212
Comment 3 months ago →
🇮🇳India akshaydalvi212
hi,
I removed the remaining issues related to the array declarations.
only unused variables issues are remaining for the Content.php file.
FILE: /home/admin1/open-source/drupal10.3/drupal/modules/contrib/parameters/src/Plugin/Parameter/Content.php
------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
------------------------------------------------------------------------------------------------------------
186 | WARNING | Unused variable $bundle.
189 | WARNING | Unused variable $bundle.
357 | WARNING | Unused variable $cleanupFieldValues.
358 | WARNING | Unused variable $normalizeNewEntities.
363 | WARNING | Unused variable $cleanupFieldValues.
364 | WARNING | Unused variable $normalizeNewEntities.
381 | WARNING | Unused variable $cleanupFieldValues.
382 | WARNING | Unused variable $normalizeNewEntities.
387 | WARNING | Unused variable $cleanupFieldValues.
388 | WARNING | Unused variable $normalizeNewEntities.
------------------------------------------------------------------------------------------------------------
Issue was unassigned.
Comment 3 months ago →
🇮🇳India akshaydalvi212

Comment 2 months ago →

a.aaronjake

Hi @Akshay

I have applied the commits you made on MR!5, confirmed it can be applied successfully, however, there are still indentions issues not yet fixed. Please see below:

➜  parameters git:(1.0.x) curl https://git.drupalcode.org/project/parameters/-/merge_requests/5.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 45872    0 45872    0     0   114k      0 --:--:-- --:--:-- --:--:--  117k
patching file modules/parameters_ui/src/Controller/ParametersUiController.php
patching file modules/parameters_ui/src/Form/ParameterDeleteForm.php
patching file modules/parameters_ui/src/Form/ParameterForm.php
patching file modules/parameters_ui/src/Form/ParametersCollectionAddForm.php
patching file modules/parameters_ui/src/Form/ParametersCollectionForm.php
patching file modules/parameters_ui/src/Form/ParametersCollectionLockForm.php
patching file modules/parameters_ui/src/Form/ParametersCollectionUnlockForm.php
patching file modules/parameters_ui/src/ParametersUiListBuilder.php
patching file modules/parameters_ui/src/Routing/ParametersUiRouteEnhancer.php
patching file parameters.install
patching file src/Entity/ParametersCollectionStorage.php
patching file src/EventSubscriber/ParametersConfigOverrideSubscriber.php
patching file src/Exception/ParameterNotFoundException.php
patching file src/Internals/ContentSerializationCompilerPass.php
patching file src/Normalizer/Legacy/ParametersContentEntityNormalizer.php
patching file src/Normalizer/ParametersContentEntityNormalizer.php
patching file src/ParameterRepository.php
patching file src/Plugin/Derivative/Parameter/ContentDeriver.php
patching file src/Plugin/Parameter/Bundles.php
patching file src/Plugin/Parameter/Content.php
patching file src/Plugin/Parameter/Fields.php
patching file src/Plugin/Parameter/Http.php
patching file src/Plugin/Parameter/Increment.php
patching file src/Plugin/Parameter/NullObject.php
patching file src/Plugin/Parameter/Roles.php
patching file src/Plugin/Parameter/Types.php
patching file src/Plugin/ParameterManager.php
patching file tests/src/Kernel/ParametersTokenTest.php
➜  parameters git:(1.0.x) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig parameters

FILE: ...mo-site/drupal10-orgissue/web/modules/contrib/parameters/parameters.module
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
 84 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
 87 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
 89 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...0-orgissue/web/modules/contrib/parameters/src/Plugin/Parameter/Content.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
--------------------------------------------------------------------------------
 186 | WARNING | Unused variable $bundle.
 189 | WARNING | Unused variable $bundle.
 357 | WARNING | Unused variable $cleanupFieldValues.
 358 | WARNING | Unused variable $normalizeNewEntities.
 363 | WARNING | Unused variable $cleanupFieldValues.
 364 | WARNING | Unused variable $normalizeNewEntities.
 381 | WARNING | Unused variable $cleanupFieldValues.
 382 | WARNING | Unused variable $normalizeNewEntities.
 387 | WARNING | Unused variable $cleanupFieldValues.
 388 | WARNING | Unused variable $normalizeNewEntities.
--------------------------------------------------------------------------------

Time: 3.45 secs; Memory: 20MB

Also, can you please change the status of the issue to 'Needs Review' if you made your work on it? It is so that this will be seen as 'Needs Review' on the Issues page.

Kindly check

Thanks,
Jake

Merge request !6Created a new merge request to get the list of all the PHP_CodeSniffer errors/warnings to fix → (Open) created by apaderno
Pipeline finished with Success
2 months ago
Total: 145s
#280932
Pipeline finished with Failed
2 months ago
Total: 162s
#280934
Comment about 1 month ago →
🇮🇳India akulsaxena
Working on it
Pipeline finished with Failed
about 1 month ago
#309214
Pipeline finished with Failed
about 1 month ago
#309216
Pipeline finished with Failed
about 1 month ago
#309224
Pipeline finished with Success
about 1 month ago
#309228
Comment about 1 month ago →
🇮🇳India akulsaxena
Solved all PHPCS errors and warnings
Comment about 1 month ago →
🇩🇪Germany mxh Offenburg
You obviously don't know what you are doing. What I can see is that you are removing whole code blocks without providing any replacement. It means if someone would actually commit your garbage, it would break existing functionality.

Example: https://git.drupalcode.org/project/parameters/-/merge_requests/6/diffs#d...

This is grossly negligent and I'm considering to report you for the attempt of breaking things. Because I don't know whether that was on purpose or you are just blindly applying some CLI tools without thinking of what you are actually doing. At least you won't get any credit for this from me.
Comment about 1 month ago →
🇮🇳India akulsaxena
Sorry for the misunderstanding
I removed those blocks because those functionalities were duplicated when i committed for the first time and had the same code inside them multiple times, so i removed the duplicates and kept one instance of each functionality.
Comment about 1 month ago →
🇮🇳India akulsaxena
The functionalities were duplicated multiple times in the Content.php file and those duplicates are the only blocks of code i removed. there still exists one instance of each functionality whose duplicate i have removed. i have also cleared all the phpcs errors and warnings that were present in the given 28 files
Comment about 1 month ago →
🇮🇳India akulsaxena
I just noticed what happened in the ParametersCollectionForm.php and i am sorry for that. I didnt notice that earlier. I could try to work on the issue again with more accuracy if you permit
Comment about 1 month ago →
🇮🇳India akulsaxena
Pipeline finished with Success
about 1 month ago
#309321
Comment about 1 month ago →
🇮🇳India akulsaxena
Hi, I am a novice and am trying to do my best. I tried to improve what I did. I also got back the code blocks that were deleted and fixed all the PHPCS errors and warnings. The only warnings that remain are in Content.php file that are of a few unused variables. Please check if this works?
Comment about 1 month ago →
🇮🇳India akulsaxena
Hi @qichanghai and @mxh
I did some unintended mistakes earlier but I tried to resolve them and I think they are now fixed. Can you please take a look now.
Thanks
Comment about 1 month ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
avpaderno → changed the visibility of the branch 3354883-gitlab-ci-reports to hidden.
Merge request !7Created a new merge request to get the list of all the PHP_CodeSniffer errors/warnings to fix → (Open) created by apaderno
Pipeline finished with Success
about 1 month ago
Total: 146s
#315117
Comment about 1 month ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Comment about 1 month ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
avpaderno → changed the visibility of the branch 3354883-reports-gitlab-ci to hidden.
Pipeline finished with Failed
about 1 month ago
Total: 187s
#315147
Pipeline finished with Failed
about 1 month ago
Total: 193s
#315157
Pipeline finished with Failed
about 1 month ago
Total: 154s
#315160
Pipeline finished with Failed
about 1 month ago
Total: 159s
#315166
Pipeline finished with Failed
about 1 month ago
Total: 163s
#315172

Comment about 5 hours ago →

🇮🇳India sourav_paul Kolkata

@avpaderno & @akulsaxena I've tested both MR!5 & MR!6 on the branch 1.0.x

MR!5 test result:

curl https://git.drupalcode.org/project/parameters/-/merge_requests/5.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 48118    0 48118    0     0  70738      0 --:--:-- --:--:-- --:--:-- 70657
Checking patch .gitlab-ci.yml...
Checking patch modules/parameters_ui/src/Controller/ParametersUiController.php...
Checking patch modules/parameters_ui/src/Form/ParameterDeleteForm.php...
Checking patch modules/parameters_ui/src/Form/ParameterForm.php...
Checking patch modules/parameters_ui/src/Form/ParametersCollectionAddForm.php...
Checking patch modules/parameters_ui/src/Form/ParametersCollectionForm.php...
Hunk #4 succeeded at 165 (offset 7 lines).
Hunk #5 succeeded at 239 (offset 7 lines).
Hunk #6 succeeded at 404 (offset 7 lines).
Checking patch modules/parameters_ui/src/Form/ParametersCollectionLockForm.php...
Checking patch modules/parameters_ui/src/Form/ParametersCollectionUnlockForm.php...
Checking patch modules/parameters_ui/src/ParametersUiListBuilder.php...
Checking patch modules/parameters_ui/src/Routing/ParametersUiRouteEnhancer.php...
Checking patch parameters.install...
Checking patch parameters.module...
Checking patch src/Entity/ParametersCollectionStorage.php...
Checking patch src/EventSubscriber/ParametersConfigOverrideSubscriber.php...
Checking patch src/Exception/ParameterNotFoundException.php...
Checking patch src/Internals/ContentSerializationCompilerPass.php...
Checking patch src/Internals/ItemSortTrait.php...
Checking patch src/Normalizer/Legacy/ParametersContentEntityNormalizer.php...
Checking patch src/Normalizer/ParametersContentEntityNormalizer.php...
Checking patch src/Normalizer/ParametersEntityReferenceFieldItemNormalizer.php...
Checking patch src/ParameterRepository.php...
error: while searching for:
use Drupal\parameters\Event\CollectionsPreparationEvent;
use Drupal\parameters\Event\ParameterEvents;
use Drupal\parameters\Exception\ParameterNotFoundException;
use Drupal\parameters\Plugin\ParameterPluginCollection;
use Drupal\parameters\Plugin\ParameterInterface;
use Drupal\parameters\Plugin\ParameterManager;
use Drupal\parameters\Plugin\PropertyParameterInterface;
use Symfony\Contracts\EventDispatcher\EventDispatcherInterface;


error: patch failed: src/ParameterRepository.php:10
error: src/ParameterRepository.php: patch does not apply
Checking patch src/Plugin/Derivative/Parameter/ContentDeriver.php...
Checking patch src/Plugin/Parameter/Bundles.php...
Hunk #1 succeeded at 155 (offset 2 lines).
Hunk #2 succeeded at 259 (offset 2 lines).
Hunk #3 succeeded at 277 (offset 2 lines).
Hunk #4 succeeded at 347 (offset 2 lines).
Checking patch src/Plugin/Parameter/Content.php...
error: while searching for:
use Drupal\parameters\Entity\ParametersCollectionStorage;
use Drupal\parameters\Internals\NormalizerContainer;
use Drupal\parameters\Plugin\EntityParameterInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Drupal\parameters\Plugin\ParameterBase;
use Drupal\parameters\Plugin\ParameterInterface;
use Drupal\parameters\Plugin\ParameterManager;
use Drupal\parameters\Plugin\PropertyParameterInterface;
use Drupal\parameters\Plugin\UsageParameterInterface;
use Symfony\Component\Serializer\Serializer;
use Drupal\user\RoleInterface;
use Drupal\user\UserInterface;

/**
 * Defines content as parameter.

error: patch failed: src/Plugin/Parameter/Content.php:31
error: src/Plugin/Parameter/Content.php: patch does not apply
Checking patch src/Plugin/Parameter/Fields.php...
Hunk #1 succeeded at 274 (offset 2 lines).
Hunk #2 succeeded at 437 (offset 2 lines).
Hunk #3 succeeded at 455 (offset 2 lines).
Checking patch src/Plugin/Parameter/Http.php...
Hunk #1 succeeded at 20 (offset 2 lines).
Hunk #2 succeeded at 71 (offset 1 line).
Hunk #3 succeeded at 103 (offset 1 line).
Hunk #4 succeeded at 272 (offset 1 line).
Hunk #5 succeeded at 293 (offset 1 line).
Hunk #6 succeeded at 314 (offset 1 line).
Hunk #7 succeeded at 326 (offset 1 line).
Hunk #8 succeeded at 335 (offset 1 line).
Hunk #9 succeeded at 348 (offset 1 line).
Hunk #10 succeeded at 490 (offset 1 line).
Hunk #11 succeeded at 626 (offset 1 line).
Checking patch src/Plugin/Parameter/Increment.php...
Hunk #1 succeeded at 27 (offset 1 line).
Checking patch src/Plugin/Parameter/NullObject.php...
Hunk #1 succeeded at 36 (offset 1 line).
Checking patch src/Plugin/Parameter/Roles.php...
Hunk #1 succeeded at 165 (offset 8 lines).
Hunk #2 succeeded at 286 (offset 8 lines).
Hunk #3 succeeded at 315 (offset 8 lines).
Checking patch src/Plugin/Parameter/Types.php...
Hunk #1 succeeded at 264 (offset 1 line).
Checking patch src/Plugin/ParameterManager.php...
error: while searching for:
namespace Drupal\parameters\Plugin;

use Drupal\Component\Plugin\PluginManagerInterface;
use Drupal\Core\Plugin\DefaultPluginManager;
use Drupal\Core\Cache\CacheBackendInterface;
use Drupal\Core\Extension\ModuleHandlerInterface;

/**
 * The manager for parameter plugins.

error: patch failed: src/Plugin/ParameterManager.php:3
error: src/Plugin/ParameterManager.php: patch does not apply
Checking patch tests/src/Kernel/ParametersTokenTest.php...

MR!6 test result:

curl https://git.drupalcode.org/project/parameters/-/merge_requests/6.diff | git apply -v
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 52512    0 52512    0     0  63637      0 --:--:-- --:--:-- --:--:-- 63573
Checking patch .gitlab-ci.yml...
Checking patch modules/parameters_ui/src/Controller/ParametersUiController.php...
Checking patch modules/parameters_ui/src/Form/ParameterDeleteForm.php...
Checking patch modules/parameters_ui/src/Form/ParameterForm.php...
Checking patch modules/parameters_ui/src/Form/ParametersCollectionAddForm.php...
Checking patch modules/parameters_ui/src/Form/ParametersCollectionForm.php...
Hunk #4 succeeded at 165 (offset 7 lines).
Hunk #5 succeeded at 239 (offset 7 lines).
Hunk #6 succeeded at 404 (offset 7 lines).
Checking patch modules/parameters_ui/src/Form/ParametersCollectionLockForm.php...
Checking patch modules/parameters_ui/src/Form/ParametersCollectionUnlockForm.php...
Checking patch modules/parameters_ui/src/ParametersUiListBuilder.php...
Checking patch modules/parameters_ui/src/Routing/ParametersUiRouteEnhancer.php...
Checking patch parameters.install...
Checking patch src/Entity/ParametersCollectionStorage.php...
Checking patch src/EventSubscriber/ParametersConfigOverrideSubscriber.php...
Checking patch src/Exception/ParameterNotFoundException.php...
Checking patch src/Internals/ContentSerializationCompilerPass.php...
Checking patch src/Normalizer/Legacy/ParametersContentEntityNormalizer.php...
Checking patch src/Normalizer/ParametersContentEntityNormalizer.php...
Checking patch src/Normalizer/ParametersEntityReferenceFieldItemNormalizer.php...
Checking patch src/ParameterRepository.php...
error: while searching for:
use Drupal\parameters\Event\CollectionsPreparationEvent;
use Drupal\parameters\Event\ParameterEvents;
use Drupal\parameters\Exception\ParameterNotFoundException;
use Drupal\parameters\Plugin\ParameterPluginCollection;
use Drupal\parameters\Plugin\ParameterInterface;
use Drupal\parameters\Plugin\ParameterManager;
use Drupal\parameters\Plugin\PropertyParameterInterface;
use Symfony\Contracts\EventDispatcher\EventDispatcherInterface;


error: patch failed: src/ParameterRepository.php:10
error: src/ParameterRepository.php: patch does not apply
Checking patch src/Plugin/Derivative/Parameter/ContentDeriver.php...
Checking patch src/Plugin/Parameter/Bundles.php...
Hunk #2 succeeded at 155 (offset 11 lines).
Hunk #3 succeeded at 259 (offset 11 lines).
Hunk #4 succeeded at 277 (offset 11 lines).
Checking patch src/Plugin/Parameter/Content.php...
error: while searching for:
use Drupal\parameters\Entity\ParametersCollectionStorage;
use Drupal\parameters\Internals\NormalizerContainer;
use Drupal\parameters\Plugin\EntityParameterInterface;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Drupal\parameters\Plugin\ParameterBase;
use Drupal\parameters\Plugin\ParameterInterface;
use Drupal\parameters\Plugin\ParameterManager;
use Drupal\parameters\Plugin\PropertyParameterInterface;
use Drupal\parameters\Plugin\UsageParameterInterface;
use Symfony\Component\Serializer\Serializer;
use Drupal\user\RoleInterface;
use Drupal\user\UserInterface;

/**
 * Defines content as parameter.

error: patch failed: src/Plugin/Parameter/Content.php:31
error: src/Plugin/Parameter/Content.php: patch does not apply
Checking patch src/Plugin/Parameter/Fields.php...
Hunk #2 succeeded at 274 (offset 10 lines).
Hunk #3 succeeded at 437 (offset 10 lines).
Hunk #4 succeeded at 455 (offset 10 lines).
Checking patch src/Plugin/Parameter/Http.php...
Hunk #2 succeeded at 20 (offset 2 lines).
Hunk #3 succeeded at 71 (offset 1 line).
Hunk #4 succeeded at 103 (offset 1 line).
Hunk #5 succeeded at 272 (offset 1 line).
Hunk #6 succeeded at 293 (offset 1 line).
Hunk #7 succeeded at 314 (offset 1 line).
Hunk #8 succeeded at 326 (offset 1 line).
Hunk #9 succeeded at 335 (offset 1 line).
Hunk #10 succeeded at 348 (offset 1 line).
Hunk #11 succeeded at 490 (offset 1 line).
Hunk #12 succeeded at 626 (offset 1 line).
Checking patch src/Plugin/Parameter/Increment.php...
Hunk #1 succeeded at 27 (offset 1 line).
Checking patch src/Plugin/Parameter/NullObject.php...
Hunk #1 succeeded at 36 (offset 1 line).
Checking patch src/Plugin/Parameter/Roles.php...
Hunk #2 succeeded at 165 (offset 17 lines).
Checking patch src/Plugin/Parameter/Types.php...
Checking patch src/Plugin/ParameterManager.php...
error: while searching for:
namespace Drupal\parameters\Plugin;

use Drupal\Component\Plugin\PluginManagerInterface;
use Drupal\Core\Plugin\DefaultPluginManager;
use Drupal\Core\Cache\CacheBackendInterface;
use Drupal\Core\Extension\ModuleHandlerInterface;

/**
 * The manager for parameter plugins.

error: patch failed: src/Plugin/ParameterManager.php:3
error: src/Plugin/ParameterManager.php: patch does not apply

Please have a look...

Fix the issues reported by PHPCS

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

Merge Requests

!5Fix the issues reported by PHPCS
Open

!7Fix the issues reported by PHPCS
Open

!6Fix the issues reported by PHPCS
Open

Comments & Activities

Fix the issues reported by PHPCS

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

Merge Requests

!5Fix the issues reported by PHPCSOpen

!7Fix the issues reported by PHPCSOpen

!6Fix the issues reported by PHPCSOpen

Comments & Activities

!5Fix the issues reported by PHPCS
Open

!7Fix the issues reported by PHPCS
Open

!6Fix the issues reported by PHPCS
Open