undefined - Contrib.social

🇮🇳India Ashutosh Ahirwal India

🐛 | Feature Boost | Twitter logo needs to be changed to the X

🇮🇳India Ashutosh Ahirwal India

Hi akhil_01
Can you please double check this issue its already a X logo for twitter

🐛 | Feature Boost | Bootstrap icon library is not working.

🇮🇳India Ashutosh Ahirwal India

Hi adarshv Its working fine on my end can you please double check this on your side.

🐛 | Feature Boost | Add left and right margin to the main content.

🇮🇳India Ashutosh Ahirwal India

Hi Rajan Kumar@2026, adarshv Thanks for working on theme.
This is working as design because adding a container will cause issue for full width component on the page and will also have to override the twig for making the component full width.
To resolve this use container class on the component itself.

Thanks

🐛 | Business Bee | Need fixes for level 2 menus for last menus

🇮🇳India Ashutosh Ahirwal India

I have reviewed the MR and tried to apply it but it get failed.
Moving to need work

🐛 | Barrio Bootstrap 5 Theme | Header menu distorted CSS.

🇮🇳India Ashutosh Ahirwal India

I have reviewed the patch and the changes are reflecting but the previous layout look more correct for a search.
Moving to RTBC

🐛 | Showcase Lite | Twitter logo needs to be changed to the X

🇮🇳India Ashutosh Ahirwal India

I have reviewed MR9 and if we use then this will resolve this issue
I have created my own custom block from demo site.
moving to RTBC

🐛 | Showcase Lite | No mobile menu displayed

🇮🇳India Ashutosh Ahirwal India

I have reviewed the #5 MR10 and it turns to a hamburger on mobile and also working on click.
Moving to RTBC++

🐛 | Pico - Minimalist and Lightweight Theme | Page look broken (No css)

🇮🇳India Ashutosh Ahirwal India

Ashutosh Ahirwal → created an issue.

🐛 | FlexiStyle | Last menu breaking the site

🇮🇳India Ashutosh Ahirwal India

Ashutosh Ahirwal → created an issue.

🐛 | FlexiStyle | Page get break when header fixed is used

🇮🇳India Ashutosh Ahirwal India

Ashutosh Ahirwal → created an issue.

🐛 | Business Bee | Need to design login page with tabs

🇮🇳India Ashutosh Ahirwal India

Hi sourojeetpaul → Thanks for putting efforts to design and working on this issue.
Can you please make it according to the home page color code so this page will not look different from the theme.

✨ | Lazy Views | Remove jQuery dependency

🇮🇳India Ashutosh Ahirwal India

jquery dependency removed
Moving to RTBC

🐛 | Techy News Theme | CSS distorted while adding content to basic content type

🇮🇳India Ashutosh Ahirwal India

Adding css like this will effect globally because added css in provided patch is a field specific and adding display none for label and page title is not a correct way.

+.page-title {
+  display: none; }
+
+.field--label-above .field__label {
+  display: none; }

🐛 | Business | Fix Content CSS

🇮🇳India Ashutosh Ahirwal India

Instant of adding display none to each field label, set the label hidden from manage display form for content type.

🐛 | Business Bee | Need to design login page with tabs

🇮🇳India Ashutosh Ahirwal India

Ashutosh Ahirwal → created an issue.

🐛 | Business Bee | Need fixes for level 2 menus for last menus

🇮🇳India Ashutosh Ahirwal India

Ashutosh Ahirwal → created an issue.

🐛 | Education Bee | Twitter logo needs to be changed to the X

🇮🇳India Ashutosh Ahirwal India

Moving to Need work to get some progress in this issue.

🐛 | Potent Allure | Tabs are missing on login page

🇮🇳India Ashutosh Ahirwal India

Ashutosh Ahirwal → created an issue.

🐛 | Market Wave | White space found on banner disable

🇮🇳India Ashutosh Ahirwal India

Ashutosh Ahirwal → created an issue.

🐛 | Market Wave | Menus are broken if long text is added on level 2

🇮🇳India Ashutosh Ahirwal India

Ashutosh Ahirwal → created an issue.

🐛 | Market Wave | Banner navigation arrows not getting load on theme installation

🇮🇳India Ashutosh Ahirwal India

Ashutosh Ahirwal → created an issue.

🐛 | Market Wave | Banner text is not available on install

🇮🇳India Ashutosh Ahirwal India

Ashutosh Ahirwal → created an issue.

🐛 | Pets Clinic | Add new icon of twitter(X)

🇮🇳India Ashutosh Ahirwal India

Ashutosh Ahirwal → created an issue.

🐛 | Pets Clinic | Menus breaking for second level

🇮🇳India Ashutosh Ahirwal India

Ashutosh Ahirwal → created an issue.

🐛 | Festeva Live | Twitter logo needs to be changed to the X

🇮🇳India Ashutosh Ahirwal India

I have update the x icon and also updated the bootstrap-icon for new icons.
Providing Updated MR.
Please review.

🐛 | Festeva Live | Twitter logo needs to be changed to the X

🇮🇳India Ashutosh Ahirwal India

Ashutosh Ahirwal → made their first commit to this issue’s fork.

📌 | Etherpad API | Unused variables in install file

🇮🇳India Ashutosh Ahirwal India

Hi, I have reviewed the #3 and also providing MR with fixes.
Please review it.

📌 | Etherpad API | Unused variables in install file

🇮🇳India Ashutosh Ahirwal India

Ashutosh Ahirwal → made their first commit to this issue’s fork.

📌 | Classy | Remove package and version lines

🇮🇳India Ashutosh Ahirwal India

I have updated the MR4 with #9.
Please review need review.

📌 | Classy | Remove package and version lines

🇮🇳India Ashutosh Ahirwal India

Ashutosh Ahirwal → made their first commit to this issue’s fork.

🐛 | Education Bee | The drop down menus are breaking in navigation

🇮🇳India Ashutosh Ahirwal India

Hi, I have reviewed provided patch and also checked the added SS in #6
drop-down menu taking too much white space in right side.
Moving this to Need work to get noticed.

🐛 | Education Bee | form css distorted

🇮🇳India Ashutosh Ahirwal India

I have reviewed the patch and its working fine and updating the layout.
Moving to RTBC.

🐛 | Feature Boost | Twitter icon should be updated

🇮🇳India Ashutosh Ahirwal India

Closing the issue its fixed in new tag.

🐛 | Feature Boost | Twitter icon should be updated

🇮🇳India Ashutosh Ahirwal India

Hi govind_giri_goswami →
Thanks for the issue.
Issue is fixed in new tag 10.0.1.
Thanks

📌 | Rate | \Drupal calls should be avoided in classes, use dependency injection instead

🇮🇳India Ashutosh Ahirwal India

Hi I have reviewed the patch and it fixes all the issue related to dependency injection but still there are so many issue found related to phpcs
Moving to RTBC.

Used command
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/rate

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/rate/js/w-thumbsup.js
----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
18 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/rate/js/w-yesno.js
-------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------
18 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/rate/js/w-fivestar.js
----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
24 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/rate/js/w-numberupdown.js
--------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
18 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
--------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/rate/js/unvote-helper.js
-------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------
23 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
-------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/rate/js/w-custom.js
--------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------
18 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
--------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/rate/js/w-emotion.js
---------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
18 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
---------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/rate/js/w-thumbsupdown.js
--------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
18 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
--------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/rate/rate.api.php
------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------
3 | ERROR | Missing short description in doc comment
------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/rate/src/Controller/WidgetResultsController.php
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
102 | WARNING | Unused variable $id.
------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/rate/src/RateWidgetForm.php
----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
292 | WARNING | Unused variable $plugin_id.
----------------------------------------------------------------------------------------------------

Time: 1.79 secs; Memory: 18MB

📌 | Ultimate Cron | \Drupal calls should be avoided in classes, use dependency injection instead

🇮🇳India Ashutosh Ahirwal India

Hi, I have reviewed the patch #2 it resolved all the dependency injection issue but still there are so many issue found by phpcs issue.
Moving to RTBC.

🐛 | Commerce User Points | Fix code style

🇮🇳India Ashutosh Ahirwal India

Hi have reviewed the MR but its still showing so many errors.
moving to need work

Used command
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/commerceuserpoints

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/commerceuserpoints/commerce_user_points.info.yml
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
6 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
-------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/commerceuserpoints/commerce_user_points.module
-----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------
38 | WARNING | Unused variable $role_order_point_discount.
39 | WARNING | Unused variable $role_date_discount.
-----------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/commerceuserpoints/src/Form/ReferralPointsConfigurationForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
------------------------------------------------------------------------------------------------------------------------------------------
63 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
76 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
89 | WARNING | Role::loadMultiple calls should be avoided in classes, use dependency injection instead
107 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
119 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
143 | WARNING | Role::loadMultiple calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/commerceuserpoints/src/Form/ThresholdAmountConfigurationForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
------------------------------------------------------------------------------------------------------------------------------------------
63 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
71 | WARNING | Role::loadMultiple calls should be avoided in classes, use dependency injection instead
74 | WARNING | Unused variable $roles_field.
97 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
105 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
107 | WARNING | Unused variable $roleDetails.
127 | WARNING | Role::loadMultiple calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/commerceuserpoints/src/Form/UserPointsConfigurationForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 24 WARNINGS AFFECTING 24 LINES
------------------------------------------------------------------------------------------------------------------------------------------
82 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
83 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
92 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
93 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
94 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
95 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
96 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
97 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
98 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
103 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
105 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
123 | WARNING | Role::loadMultiple calls should be avoided in classes, use dependency injection instead
159 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
160 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
169 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
170 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
171 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
172 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
173 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
174 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
175 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
180 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
182 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
215 | WARNING | Role::loadMultiple calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/commerceuserpoints/src/Plugin/Commerce/CheckoutPane/CommerceUserPoints.php
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------
115 | WARNING | Unused variable $roles.
116 | WARNING | Unused variable $role.
136 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
137 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
150 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
152 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
177 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
277 | WARNING | Unused variable $paymentInformation.
361 | WARNING | Unused variable $key.
416 | WARNING | Unused variable $nodeId.
---------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/commerceuserpoints/src/Plugin/Block/ReferralLinkBlock.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------
37 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
39 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/commerceuserpoints/src/Controller/ReferralLink.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
---------------------------------------------------------------------------------------------------------------------------
19 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
21 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
24 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
29 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
32 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
35 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/commerceuserpoints/src/EventSubscriber/OrderCompleteSubscriber.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
-------------------------------------------------------------------------------------------------------------------------------------------
63 | WARNING | Unused variable $userPoints.
70 | WARNING | Unused variable $userPoints.
78 | WARNING | Unused variable $orderTotal.
80 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
81 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
82 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/commerceuserpoints/src/ReferralLinkService.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
-----------------------------------------------------------------------------------------------------------------------
17 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
28 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
46 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
49 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------------------

Time: 467ms; Memory: 12MB

📌 | GlobalLink Connect for Drupal | Fix the issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

Hi, Patch provided in #2 is not getting apply throwing error
Moving to need work
Result after applying patch

globallink % git apply -v 3344157-2.patch
Checking patch config/schema/globallink.schema.yml...
error: while searching for:
label: Email notification levels
pd_user_agent:
type: select
label: GlobalLink User Agent Level
error: patch failed: config/schema/globallink.schema.yml:32
error: config/schema/globallink.schema.yml: patch does not apply
Checking patch globallink.install...
Checking patch globallink.module...
Checking patch src/EventSubscriber/GloballinkContinuousEvents.php...
Checking patch src/GlExchangeAdapter.php...
Checking patch src/GlobalLinkTranslatorUi.php...
error: while searching for:

$form['pd_url'] = [
'#type' => 'url',
'#title' => t('GlobalLink api url'),
'#required' => TRUE,
'#default_value' => $translator->getSetting('pd_url'),
'#description' => t('Add the api url provided by translations.com'),
];
$form['pd_username'] = [
'#type' => 'textfield',
'#title' => t('GlobalLink username'),
'#required' => TRUE,
'#default_value' => $translator->getSetting('pd_username'),
'#description' => t('Add the username provided by translations.com'),
];
$form['pd_password'] = [
'#type' => 'password',
'#title' => t('GlobalLink password'),
'#required' => TRUE,
'#default_value' => $translator->getSetting('pd_password'),
'#description' => t('Add the password provided by translations.com'),
];
$form['pd_projectid'] = [
'#type' => 'textfield',
'#title' => t('GlobalLink project id'),
'#required' => TRUE,
'#default_value' => $translator->getSetting('pd_projectid'),
'#description' => t('Add the project id provided by translations.com'),
];
$form['pd_submissionprefix'] = [
'#type' => 'textfield',
'#title' => t('GlobalLink submission prefix'),
'#required' => TRUE,
'#default_value' => $translator->getSetting('pd_submissionprefix'),
'#description' => t('Choose a prefix'),
];
$form['pd_classifier'] = [
'#type' => 'textfield',
'#title' => t('GlobalLink classifier'),
'#required' => TRUE,
'#default_value' => $translator->getSetting('pd_classifier'),
'#description' => t('Add a classifier'),
];
$form['pd_notify_emails'] = [
'#type' => 'textfield',
'#title' => t('Emails for notification'),
'#default_value' => $translator->getSetting('pd_notify_emails'),
'#description' => t('A space separated list of emails to notify. Leave blank for no notifications'),
];
$form['pd_combine'] = [
'#type' => 'checkbox',
'#title' => t('Combine all items into a single document'),
'#default_value' => $translator->getSetting('pd_combine'),
'#description' => t('If checked, a single document will be sent for a translation job, otherwise a separate document within a single submission will be created for each job item.'),
];
$form['pd_due_date_offset'] = [
'#type' => 'textfield',
'#title' => t('Default due date offset in working days'),
'#default_value' => $translator->getSetting('pd_due_date_offset') ?: 3,
'#description' => t('Controls the default due date, which then by default uses the configured amount of working days in the future.'),
];
$form['pd_notify_level'] = [
'#type' => 'checkboxes',
'#title' => t('Email notification levels'),
'#options' => [
GlobalLinkTranslator::MSG_STATUS => t('Status'),
GlobalLinkTranslator::MSG_DEBUG => t('Debug'),
GlobalLinkTranslator::MSG_WARNING => t('Warning'),
GlobalLinkTranslator::MSG_ERROR => t('Error'),
],
'#default_value' => (array) $translator->getSetting('pd_notify_level'),
'#description' => t('Select which tmgmt message types to send via email. Selecting all can result in a high volume of emails being sent.')
];
$form['pd_user_agent'] = [
'#type' => 'select',
'#title' => t('Select Environment Type'),
'#options' => [
'dev' => $this->t('Development Environment'),
'test' => $this->t('Test Environment'),
'stage' => $this->t('Staging Environment'),
'prod' => $this->t('Production Environment'),
],
'#default_value' => (array) $translator->getSetting('pd_user_agent'),
'#description' => t('Select which type of environment this is installed on. This will provide more information for Project Director.')
];

return $form;
}

error: patch failed: src/GlobalLinkTranslatorUi.php:44
error: src/GlobalLinkTranslatorUi.php: patch does not apply
Checking patch src/Plugin/tmgmt/Translator/GlobalLinkTranslator.php...
Hunk #8 succeeded at 572 (offset 5 lines).
Hunk #9 succeeded at 616 (offset 5 lines).
Hunk #10 succeeded at 686 (offset 5 lines).
error: while searching for:
$this->glExchangeAdapter->getGlExchange($pd_config);
}
catch (\Exception $e) {
return AvailableResult::no(t('@translator is not available. Make sure it is properly configured.', [
'@translator' => $translator->label(),
':configured' => $translator->url(),
]));

error: patch failed: src/Plugin/tmgmt/Translator/GlobalLinkTranslator.php:681
error: src/Plugin/tmgmt/Translator/GlobalLinkTranslator.php: patch does not apply

📌 | Multi Image Formatter | Fix the issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

Hi, Provided patch in #2 is not getting apply and throwing error.
Moving to need work.

📌 | QueryBuilder | Fix the issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

Hi Provided MR resolved issue but still there are some issue found.
Moving to need work to get notice.
Used command:-
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/querybuilder

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/querybuilder/querybuilder.info.yml
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
1 | WARNING | "core_version_requirement" property is missing in the info.yml file
-----------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/querybuilder/src/Form/OptimiseDatabaseForm.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
35 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

Time: 94ms; Memory: 10MB

📌 | Facebook Page Plugin | Fix the issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

Hi, MR3 resolve phpcs issue but still there are one issue.
Moving to need work to get notice
Used command:-
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/fb_likebox

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/fb_likebox/tests/src/Functional/FBLikeboxBlockTest.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
38 | WARNING | Line exceeds 80 characters; contains 82 characters
-------------------------------------------------------------------------------------------------------------------------------

Time: 186ms; Memory: 12MB

📌 | Extended HTML Filter | Fix the errors/warnings reported by Php_CodeSniffer

🇮🇳India Ashutosh Ahirwal India

Hi, I reviewed the MR1 it resolve the issues but still there are so many issue found.
moving to need work to get noticed.

Used command:- ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/extended_html_filter

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/extended_html_filter/extended_html_filter.info.yml
---------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------
7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
---------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/extended_html_filter/src/Form/ExtendedHTMLFilterSettingsForm.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
11 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/extended_html_filter/src/Plugin/Filter/ExtendedHTMLFilter.php
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait.
13 | WARNING | [ ] Line exceeds 80 characters; contains 92 characters
24 | WARNING | [ ] Line exceeds 80 characters; contains 193 characters
69 | ERROR | [ ] Public method name "ExtendedHTMLFilter::getHTMLRestrictions" is not in lowerCamel format
112 | WARNING | [ ] Unused bound variable $star_protector.
--------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/extended_html_filter/src/Utility/ExtendedHTMLFilterStandard.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | Doc comment is empty
12 | ERROR | Doc comment is empty
----------------------------------------------------------------------------------------------------------------------------------------

Time: 165ms; Memory: 12MB

📌 | CKEditor Autocomplete Link | [1.0.2] Fix the issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

Hi I reviewed #3 patch it get applied cleanly and no error found.
Moving to RTBC

📌 | Corporate Lite | Fix the issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

Hi I reviewed it but there are so many issue found related to phpcs issue updating the issue description.
Need work on it.

📌 | Field Group | GitlabCI: Fix PHPCS and PHPSTAN validation errors

🇮🇳India Ashutosh Ahirwal India

Hi Provided MR working fine but there are still some error found related to js
I have updated MR Needs Review.
Used command:- ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/field_group

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/field_group/js/field_group.field_ui.js
---------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
---------------------------------------------------------------------------------------------------------------
49 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
58 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
111 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
120 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/field_group/js/field_group.js
------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------
15 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/field_group/formatters/tabs/horizontal-tabs.js
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
72 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/field_group/formatters/tabs/tabs.js
------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------
24 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
40 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/field_group/formatters/accordion/accordion.js
----------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------------------------
22 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
32 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
35 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
45 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/field_group/formatters/html_element/html-element.js
----------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------------
55 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
66 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
69 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------

Time: 1.8 secs; Memory: 18MB

📌 | Field Group | GitlabCI: Fix PHPCS and PHPSTAN validation errors

🇮🇳India Ashutosh Ahirwal India

Ashutosh Ahirwal → made their first commit to this issue’s fork.

📌 | 403 to 404 | Resolve Issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

Hi Patch provided in #2 get applied cleanly but still throwing error.
Providing updated patch.

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/m4032404

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/m4032404/tests/src/Unit/EventSubscriber/M4032404EventSubscriberTest.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\m4032404\EventSubscriber\M4032404EventSubscriber.
-------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/m4032404/src/EventSubscriber/M4032404EventSubscriber.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface.
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------

Time: 127ms; Memory: 10MB

📌 | TopPlus Lite | Fix the issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

Hi, I have applied patch but there are still so many errors found.
Moving to Need work

Used command:- ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/topplus_lite

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/css/components/dropdowns.css
------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
36 | ERROR | Style definitions must end with a semicolon
------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/css/components/inverted-header.css
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
42 | ERROR | Style definitions must end with a semicolon
------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/css/components/social-links.css
---------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------
41 | ERROR | Style definitions must end with a semicolon
---------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/css/components/forms.css
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
167 | ERROR | Style definitions must end with a semicolon
--------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/css/components/menu.css
-------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
819 | ERROR | Class definition is empty
-------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/css/components/owl-carousel-global.css
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
69 | ERROR | Style definitions must end with a semicolon
----------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/css/theme/local-theme.css
---------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Additional whitespace found at start of file
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/popper/popper.min.js
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
-------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/waypoints/shortcuts/inview.min.js
--------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/waypoints/shortcuts/sticky.min.js
--------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/waypoints/jquery.waypoints.min.js
--------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/magnific-popup/jquery.magnific-popup.min.js
------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/magnific-popup/jquery.magnific-popup.js
--------------------------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
--------------------------------------------------------------------------------------------------------------------------------
1106 | ERROR | String concat is not required here; use a single string instead
1107 | ERROR | String concat is not required here; use a single string instead
1108 | ERROR | String concat is not required here; use a single string instead
1109 | ERROR | String concat is not required here; use a single string instead
1110 | ERROR | String concat is not required here; use a single string instead
1113 | ERROR | String concat is not required here; use a single string instead
1114 | ERROR | String concat is not required here; use a single string instead
1115 | ERROR | String concat is not required here; use a single string instead
1116 | ERROR | String concat is not required here; use a single string instead
1544 | ERROR | String concat is not required here; use a single string instead
--------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/slideout/slideout.min.js
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
-----------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/mt-modernizr/mt-modernizr.js
---------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
---------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/flexslider/jquery.flexslider-min.js
----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
----------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/flexslider/changelog.txt
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------
13 | WARNING | Line exceeds 80 characters; contains 103 characters
33 | WARNING | Line exceeds 80 characters; contains 96 characters
36 | WARNING | Line exceeds 80 characters; contains 111 characters
-----------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/flexslider/jquery.flexslider.js
------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------
885 | ERROR | [ ] Blank lines are not allowed after DEFAULT statements
1115 | ERROR | [x] Inline control structures are not allowed
1136 | ERROR | [x] Inline control structures are not allowed
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/owl-carousel/README.md
---------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
---------------------------------------------------------------------------------------------------------------
37 | WARNING | Line exceeds 80 characters; contains 92 characters
41 | WARNING | Line exceeds 80 characters; contains 96 characters
44 | WARNING | Line exceeds 80 characters; contains 114 characters
61 | WARNING | Line exceeds 80 characters; contains 166 characters
74 | WARNING | Line exceeds 80 characters; contains 116 characters
95 | WARNING | Line exceeds 80 characters; contains 81 characters
98 | WARNING | Line exceeds 80 characters; contains 100 characters
---------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/owl-carousel/owl.carousel.min.js
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
-------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/theme-settings.php
--------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------
3 | ERROR | Missing short description in doc comment
7 | ERROR | Doc comment is empty
121 | WARNING | Avoid backslash escaping in translatable strings when possible, use "" quotes instead
--------------------------------------------------------------------------------------------------------

Time: 2.55 secs; Memory: 54MB

📌 | Commerce Tax Conditions | Fix the issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

Hi I have found one remaining error after applying #2 patch.
Providing updated patch.

📌 | stub project from issue ref | Fix the issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

📌 | Commerce Abandoned Carts | Fix the warnings/errors reported by PHP_CodeSniffer

🇮🇳India Ashutosh Ahirwal India

Hi, Provided patch in #2 get applied cleanly but still found some issue.
Moving to need work.

Used command:- ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/commerce_abandoned_carts

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/commerce_abandoned_carts/commerce_abandoned_carts.module
---------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
---------------------------------------------------------------------------------------------------------------------------------
79 | WARNING | Line exceeds 80 characters; contains 98 characters
80 | WARNING | Line exceeds 80 characters; contains 97 characters
91 | WARNING | Line exceeds 80 characters; contains 111 characters
182 | WARNING | Unused variable $nid.
---------------------------------------------------------------------------------------------------------------------------------

Time: 461ms; Memory: 12MB

📌 | Group Content Menu | Fix the issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

Hi I have reviewed the MR and it resolve the issue but there are still some issue remains.
Moving this to Need Work for get it done.

Used command:-./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/group_content_menu

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/group_content_menu/group_content_menu.post_update.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------
49 | ERROR | The array declaration extends to column 121 (the limit is 120). The array content should be split up over multiple lines
76 | ERROR | The array declaration extends to column 122 (the limit is 120). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/group_content_menu/tests/src/Functional/GroupContentMenuTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
161 | WARNING | Line exceeds 80 characters; contains 82 characters
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/group_content_menu/src/Access/GroupOwnsMenuContentAccessChecker.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------
77 | WARNING | Line exceeds 80 characters; contains 83 characters
--------------------------------------------------------------------------------------------------------------------------------------------

Time: 881ms; Memory: 14MB

📌 | Syncore | Fix the issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

Hi I have reviewed the MR 1 and resolved all the issue.
Moving to RTBC.

📌 | Pirate | Fix the errors/warnings reported by Php_CodeSniffer

🇮🇳India Ashutosh Ahirwal India

Hi, I have fixes all the phpcs issue and updated the PR.
Needs review.

📌 | Pirate | Fix the errors/warnings reported by Php_CodeSniffer

🇮🇳India Ashutosh Ahirwal India

Ashutosh Ahirwal → made their first commit to this issue’s fork.

📌 | Time Spent | Fix the issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

Hi I have update the MR with some remaining fixes of PHPcs issues.

There are one remaining issue need maintainer comment on it
Moving to Need work to get notice this issue for remaining task

Used command:- ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/time_spent

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/time_spent/time_spent.module
-----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------
23 | WARNING | Unused variable $variables.
-----------------------------------------------------------------------------------------------------

Time: 299ms; Memory: 14MB

📌 | Time Spent | Fix the issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

Ashutosh Ahirwal → made their first commit to this issue’s fork.

📌 | Magnify Images | Fix the issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

I reviewed the MR and its resolving the all phpcs issue.
Moving to RTBC

📌 | Tooltip Ckeditor | Fix the issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

I have resolve remaing issue but need to upgrade module from D8 to D10.

Used command:- ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/tooltip_ckeditor

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/tooltip_ckeditor/tooltip_ckeditor.info.yml
-------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
1 | WARNING | "core_version_requirement" property is missing in the info.yml file
-------------------------------------------------------------------------------------------------------------------

Time: 147ms; Memory: 12MB

📌 | Tooltip Ckeditor | Fix the issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

Ashutosh Ahirwal → made their first commit to this issue’s fork.

📌 | Queue Unique | Fix the errors/warnings reported by Php_CodeSniffer

🇮🇳India Ashutosh Ahirwal India

Hi I have updated the MR need review.

📌 | Queue Unique | Fix the errors/warnings reported by Php_CodeSniffer

🇮🇳India Ashutosh Ahirwal India

Ashutosh Ahirwal → made their first commit to this issue’s fork.

🐛 | IMCE | Fix the errors/warnings reported by PHP_CodeSniffer.

🇮🇳India Ashutosh Ahirwal India

Hi I reviewed the MR in #2 but still there are so many error found by phpcs command

Used command with argument is:-
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/imce

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/imce/css/imce.icons.css
------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------
5 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
5 | ERROR | [ ] No style definition found on line; check for missing colon
6 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
6 | ERROR | [ ] No style definition found on line; check for missing colon
7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
7 | ERROR | [ ] No style definition found on line; check for missing colon
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/imce/js/imce.Folder.js
-------------------------------------------------------------------------------------------------
FOUND 31 ERRORS AFFECTING 31 LINES
-------------------------------------------------------------------------------------------------
32 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
187 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
235 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
241 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
268 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
273 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
313 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
344 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
369 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
375 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
395 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
397 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
398 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
410 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
418 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
551 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
576 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
587 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
620 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
623 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
676 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
681 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
685 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
691 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
695 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
720 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
745 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
752 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
754 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
772 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
786 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
-------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 31 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/imce/js/imce.js
--------------------------------------------------------------------------------------------------
FOUND 71 ERRORS AFFECTING 69 LINES
--------------------------------------------------------------------------------------------------
274 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
276 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
393 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
439 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
542 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
545 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
553 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
587 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
621 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
632 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
675 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
676 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
679 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
680 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
683 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
701 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
705 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
714 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
716 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
725 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
728 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
737 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
739 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
748 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
754 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
759 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
761 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
770 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
777 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
779 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
786 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
789 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
791 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
793 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
919 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
919 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
920 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
1039 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
1039 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
1040 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
1089 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
1138 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
1180 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
1185 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
1199 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
1234 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
1274 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
1289 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
1297 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
1319 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
1336 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
1337 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
1338 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
1342 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
1368 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
1373 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
1406 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
1474 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
1488 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
1497 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
1596 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
1615 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
1619 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
1772 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
1831 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
1857 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
1883 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
1954 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
1976 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
2041 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
2044 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
--------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 71 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/imce/js/imce.File.js
---------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------
31 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
57 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
---------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/imce/js/imce.input.js
----------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
----------------------------------------------------------------------------------------------
26 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
34 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
49 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
54 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
98 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/imce/js/plugins/ckeditor/imce.ckeditor.js
------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
90 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/imce/js/plugins/bueditor/imce.bueditor.js
------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
54 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/imce/js/plugins/ckeditor5/imce.ckeditor5.js
--------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------
86 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
122 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
--------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/imce/js/plugins/imce/imce.newfolder.js
---------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
---------------------------------------------------------------------------------------------------------------
48 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
59 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
63 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
65 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/imce/js/plugins/imce/imce.upload.js
------------------------------------------------------------------------------------------------------------
FOUND 19 ERRORS AFFECTING 19 LINES
------------------------------------------------------------------------------------------------------------
39 | ERROR | [ ] String concat is not required here; use a single string instead
40 | ERROR | [ ] String concat is not required here; use a single string instead
42 | ERROR | [ ] String concat is not required here; use a single string instead
45 | ERROR | [ ] String concat is not required here; use a single string instead
47 | ERROR | [ ] String concat is not required here; use a single string instead
86 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
94 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
98 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
112 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
116 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
119 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
126 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
136 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
146 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
150 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
153 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
215 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
230 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
235 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 14 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/imce/js/plugins/imce/imce.UploadQueue.js
-----------------------------------------------------------------------------------------------------------------
FOUND 17 ERRORS AFFECTING 17 LINES
-----------------------------------------------------------------------------------------------------------------
61 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
62 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
73 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
74 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
141 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
197 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
198 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
206 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
262 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
276 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
291 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
308 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
316 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
333 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
352 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
354 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
361 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
-----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 17 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/imce/js/plugins/imce/imce.resize.js
------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------
37 | ERROR | [ ] String concat is not required here; use a single string instead
40 | ERROR | [ ] String concat is not required here; use a single string instead
43 | ERROR | [ ] String concat is not required here; use a single string instead
74 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
102 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/imce/js/imce.Item.js
-------------------------------------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 11 LINES
-------------------------------------------------------------------------------------------------
370 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
392 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
411 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
428 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
428 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
443 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
458 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
470 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
486 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
489 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
505 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
516 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
-------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/imce/js/imce.Tbb.js
-------------------------------------------------------------------------------------------------
FOUND 9 ERRORS AFFECTING 9 LINES
-------------------------------------------------------------------------------------------------
90 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
94 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
114 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
150 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
155 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
160 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
175 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
179 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
208 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
-------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/imce/js/imce.filefield.js
--------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------
76 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
84 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
--------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/imce/tests/src/Kernel/CKE4to5UpgradePathTest.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------

Time: 1.82 secs; Memory: 32MB

📌 | Webform Product | Fix the issues reported by phpcs

🌱 | JASS | Please do not file pointless issues for the newly added dev snapshot of this new project.

🇮🇳India Ashutosh Ahirwal India

Hi Provided patch get applied cleanly but still found some error.
Used command with arguments:-
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/webform_product

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/webform_product/webform_product.routing.yml
--------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------------------
6 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
13 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
20 | WARNING | Open page callback found, please add a comment before the line why there is no access restriction
--------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/webform_product/src/WebFormProductFormHelper.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
27 | WARNING | Unused variable $element_info.
-------------------------------------------------------------------------------------------------------------------------

Time: 532ms; Memory: 16MB

🇮🇳India Ashutosh Ahirwal India

Ashutosh Ahirwal → created an issue.

🐛 | Picked Fresh | Need to design the login form looks broken

🇮🇳India Ashutosh Ahirwal India

Ashutosh Ahirwal → created an issue.

🐛 | Canvas Chronicles | Theme not getting install found drupal core inside directory

🇮🇳India Ashutosh Ahirwal India

Ashutosh Ahirwal → created an issue.

🐛 | Techy News Theme | Found two login form on login page need to add conditon for it.

🇮🇳India Ashutosh Ahirwal India

Ashutosh Ahirwal → created an issue.

📌 | Zoom on hover | Fix the issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

📌 | Zoom on hover | Fix the issues reported by phpcs

📌 | General Data Protection Regulation Compliance | Fix the errors/warnings reported by Php_CodeSniffer

🇮🇳India Ashutosh Ahirwal India

Found so many errors after applying #6 patch
Providing fixes

Command used with arguments
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/zoom_on_hover

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/zoom_on_hover/js/zoom-on-hover.js
----------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 6 LINES
----------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
5 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
10 | ERROR | [x] Expected 1 space before "/"; 0 found
10 | ERROR | [x] Expected 1 space after "/"; 0 found
21 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
32 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
65 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------

Time: 281ms; Memory: 22MB

🇮🇳India Ashutosh Ahirwal India

Hi have reviewed the MR its resolving the issue but still there are some errors found.
Moving to need work.

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/gdpr_compliance

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/gdpr_compliance/gdpr_compliance.module
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\gdpr_compliance\Hook\FormNodeFormAlter.
---------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/gdpr_compliance/assets/gulpfile.js
-----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
14 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
-----------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/gdpr_compliance/src/Form/SettingsFormWarning.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeBundleInfo.
---------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/gdpr_compliance/src/Controller/PagePolicy.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
12 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Symfony\Component\HttpFoundation\Request.
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------

Time: 264ms; Memory: 12MB

🐛 | Varbase Core | Fix the issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

Hi Provided patch in #3 does not get applied throw error.
Moving to Need Work

📌 | Drupy | Fix the issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

Hi Provided patch in #2 get applied cleanly and resolved issue found in .theme file but still there are so many issue found

Command used with arguments
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/drupy

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/drupy/webpack.config.js
------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------
23 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
23 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
24 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/drupy/README.md
----------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
----------------------------------------------------------------------------------------
4 | WARNING | Line exceeds 80 characters; contains 103 characters
5 | WARNING | Line exceeds 80 characters; contains 114 characters
7 | WARNING | Line exceeds 80 characters; contains 147 characters
9 | WARNING | Line exceeds 80 characters; contains 240 characters
12 | WARNING | Line exceeds 80 characters; contains 117 characters
15 | WARNING | Line exceeds 80 characters; contains 170 characters
17 | WARNING | Line exceeds 80 characters; contains 141 characters
19 | WARNING | Line exceeds 80 characters; contains 97 characters
22 | WARNING | Line exceeds 80 characters; contains 89 characters
24 | WARNING | Line exceeds 80 characters; contains 191 characters
----------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/drupy/drupy.info.yml
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-----------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/drupy/src/js/_menu_toggler.js
------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------
39 | ERROR | [x] Expected 1 space before "-"; 0 found
39 | ERROR | [x] Expected 1 space after "-"; 0 found
72 | ERROR | [x] Expected 1 newline at end of file; 3 found
74 | ERROR | [x] Additional whitespace found at end of file
------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------

Time: 236ms; Memory: 12MB

📌 | FSK Demo | Fix the issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

Provided MR resolved all the error raised by PHPcs and no errors found.
Moving to RTBC.

📌 | Portfolio theme v2 | Fix the issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

📌 | Look | Fix the issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

Hi provided patch get applied cleanly and no error found.
Moving to RTBC

📌 | Asset Autoload | Fix the issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

Hi provided patch in #2 get applied and resolved most of the issue
Remaining once issue

Used command with arguments
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/asset_autoload

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/asset_autoload/src/SuggestionHelper.php
----------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------
51 | ERROR | [x] Use null coalesce operator instead of ternary operator.
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------

Time: 309ms; Memory: 12MB

📌 | Filtered Text Wrapper | Fix the issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

Hi provided patch in #2 get applied cleanly
Moving to RTBC

🐛 | Private Taxonomy Terms | Issue reported by Drupal coding standards

🇮🇳India Ashutosh Ahirwal India

Confirming the #2 comment and moving to Need work for remaining issue.

📌 | Password Notification | Fix the issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

Hi Provided patch get applied cleanly but its still showing some error.
Moving to Need work.

Used command with arguments
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/password_notification

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/password_notification/includes/password_notification.admin.inc
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
37 | WARNING | All variables defined by your module must be prefixed with your module's name to avoid name collisions with others. Expected start with "password_notification" but found "mail_subject"
44 | WARNING | All variables defined by your module must be prefixed with your module's name to avoid name collisions with others. Expected start with "password_notification" but found "mail_body"
50 | WARNING | All variables defined by your module must be prefixed with your module's name to avoid name collisions with others. Expected start with "password_notification" but found "mail_bcc"
56 | WARNING | All variables defined by your module must be prefixed with your module's name to avoid name collisions with others. Expected start with "password_notification" but found "mail_cc"
68 | WARNING | All variables defined by your module must be prefixed with your module's name to avoid name collisions with others. Expected start with "password_notification" but found
| | "delete_records_limit"
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/password_notification/password_notification.module
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
118 | WARNING | Unused variable $save_data.
152 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "password_changed_history_delete_form" but expected
| | "password_notification_password_changed_history_delete_form"
184 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "password_changed_history_delete_form_submit" but expected
| | "password_notification_password_changed_history_delete_form_submit"
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 307ms; Memory: 12MB

📌 | Views Bulk Reference Edit | Fix the issues reported by phpcs

🇮🇳India Ashutosh Ahirwal India

Hi provided patch in #2 get applied cleanly but still found some issue.
Moving to Need work

Used command with argument
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/views_bulk_reference_edit

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/views_bulk_reference_edit/src/Plugin/Action/ModifyReferencedEntityValues.php
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 4 WARNINGS AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\views_bulk_operations\Service\ViewsBulkOperationsActionProcessor.
52 | WARNING | [ ] Possible useless method overriding detected
237 | WARNING | [ ] Unused variable $k.
238 | WARNING | [ ] Unused variable $entity_type_id.
246 | WARNING | [ ] Unused variable $entity_type_id.
---------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 261ms; Memory: 12MB

📌 | Layout Builder Modal | Fix the issues reported by phpcs.

📌 | File Entity Browser | File::load calls should be avoided in classes, use dependency injection instead

🇮🇳India Ashutosh Ahirwal India

Hi provided patch in #2 get applied cleanly but its still showing error found by Phpcs.

Used command with arguments
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/layout_builder_modal

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/layout_builder_modal/tests/src/FunctionalJavascript/LayoutBuilderModalTest.php
-------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------
265 | WARNING | Unused variable $page.
-------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/layout_builder_modal/layout_builder_modal.module
------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/layout_builder_modal/theme/seven/css/classy.css
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/layout_builder_modal/theme/seven/css/media_library.css
-------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
-------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/layout_builder_modal/theme/seven/css/js.css
--------------------------------------------------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
1 | ERROR | [x] Opening brace should be the last content on the line
1 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
1 | ERROR | [ ] Style definitions must end with a semicolon
1 | ERROR | [x] Closing brace of class definition must be on new line
1 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found
1 | ERROR | [x] Opening brace should be the last content on the line
1 | ERROR | [x] Each style definition must be on a line by itself
1 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
1 | ERROR | [ ] Style definitions must end with a semicolon
1 | ERROR | [x] Closing brace of class definition must be on new line
--------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 9 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/layout_builder_modal/theme/seven/css/details.css
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
-------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/layout_builder_modal/theme/seven/css/form.css
----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
----------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/layout_builder_modal/theme/seven/css/autocomplete.css
------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/layout_builder_modal/theme/seven/css/elements.css
--------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/layout_builder_modal/theme/seven/css/buttons.css
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
-------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/layout_builder_modal/theme/seven/css/icons.css
-----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
-----------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/layout_builder_modal/theme/seven/css/normalize.css
---------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
---------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/layout_builder_modal/theme/seven/css/tables.css
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/layout_builder_modal/src/Form/LayoutBuilderModalSettingsForm.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
66 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
67 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/layout_builder_modal/src/EventSubscriber/AjaxResponseSubscriber.php
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Symfony\Component\EventDispatcher\EventSubscriberInterface.
----------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------------------------

Time: 330ms; Memory: 12MB

📌 | Group Content Moderation | \Drupal calls should be avoided in classes, use dependency injection instead

🇮🇳India Ashutosh Ahirwal India

Provided patch in #2 applied cleanly but still there are error found by phpcs

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/file_browser

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/file_browser/js/file_browser.view.js
-------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------
70 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
71 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
-------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/file_browser/file_browser.module
-----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Form\FormStateInterface.
-----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/file_browser/tests/src/Functional/InstallTest.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
20 | ERROR | Do not disable strict config schema checking in tests. Instead ensure your module properly declares its schema for configurations.
-------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/file_browser/file_browser.install
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 6 LINES
--------------------------------------------------------------------------------------------------------------------------------------------
11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\File\FileSystemInterface.
101 | ERROR | [ ] The array declaration extends to column 95 (the limit is 80). The array content should be split up over multiple lines
104 | WARNING | [ ] Unused variable $text.
123 | ERROR | [ ] The array declaration extends to column 95 (the limit is 80). The array content should be split up over multiple lines
223 | ERROR | [ ] The array declaration extends to column 97 (the limit is 80). The array content should be split up over multiple lines
245 | ERROR | [ ] The array declaration extends to column 95 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/file_browser/src/Plugin/views/field/FileBrowserPreview.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
72 | ERROR | [x] list(...) is forbidden, use [...] instead.
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/file_browser/src/Plugin/Block/ImageEmbedBlock.php
----------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AND 1 WARNING AFFECTING 7 LINES
----------------------------------------------------------------------------------------------------------------------------
8 | WARNING | [x] Unused use statement
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Image\ImageFactory.
23 | ERROR | [x] Whitespace found at end of line
38 | ERROR | [ ] Parameter $entity_type_manager is not described in comment
86 | ERROR | [x] Use null coalesce operator instead of ternary operator.
189 | ERROR | [x] Use null coalesce operator instead of ternary operator.
270 | ERROR | [x] Use null coalesce operator instead of ternary operator.
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------

Time: 299ms; Memory: 12MB

🇮🇳India Ashutosh Ahirwal India

Provided patch in #2 get applied cleanly but there are still some error found
Providing updated patch

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/gcontent_moderation

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/gcontent_moderation/tests/modules/gcontent_moderation_test/src/GroupStateTransitionValidation.php
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------
12 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityTypeManagerInterface.
33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
34 | ERROR | [x] Expected 5 space(s) before asterisk; 3 found
35 | ERROR | [x] Expected 5 space(s) before asterisk; 3 found
36 | ERROR | [x] Expected 5 space(s) before asterisk; 3 found
37 | ERROR | [x] Expected 5 space(s) before asterisk; 3 found
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/gcontent_moderation/tests/src/Functional/ContentModerationIntegrationTest.php
------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 4 WARNINGS AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------
151 | ERROR | The array declaration extends to column 86 (the limit is 80). The array content should be split up over multiple lines
173 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
188 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
190 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
204 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 346ms; Memory: 12MB

📌 | Commerce - Stripe Checkout | Fix the errors/warnings reported by PHP_CodeSniffer

🇮🇳India Ashutosh Ahirwal India

Providing Updated patch for 1.2.x version previous version is not showing.

📌 | MTCaptcha | Fix the warnings/errors reported by PHP_CodeSniffer

🇮🇳India Ashutosh Ahirwal India

Patch provided in #2 get applied cleanly but still there are so many error found

Providing updated patch with fixes

Used command with arguments:-
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/mtcaptcha

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/mtcaptcha/js/mtcaptcha-common.js
---------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 8 LINES
---------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Additional whitespace found at start of file
4 | ERROR | [x] Whitespace found at end of line
7 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
8 | ERROR | [x] Whitespace found at end of line
12 | ERROR | [x] Whitespace found at end of line
14 | ERROR | [x] Whitespace found at end of line
18 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
18 | ERROR | [x] Expected 1 space before opening brace; found 0
18 | ERROR | [x] Expected 1 newline at end of file; 2 found
19 | ERROR | [x] Additional whitespace found at end of file
---------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/mtcaptcha/js/mtcaptcha-admin.js
--------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Additional whitespace found at start of file
2 | ERROR | [x] Whitespace found at end of line
11 | ERROR | [x] Whitespace found at end of line
31 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/mtcaptcha/js/mtcaptcha.js
--------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
3 | ERROR | [x] Whitespace found at end of line
--------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/mtcaptcha/mtcaptcha.module
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 10 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
107 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
109 | ERROR | [ ] All functions defined in a module file must be prefixed with the module's name, found "mtcapcha_render" but expected "mtcaptcha_mtcapcha_render"
137 | ERROR | [ ] Missing parameter name
138 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 1 spaces
157 | ERROR | [x] Array indentation error, expected 6 spaces but found 7
178 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
190 | ERROR | [ ] Missing parameter comment
190 | ERROR | [ ] Missing parameter name
191 | ERROR | [ ] Missing parameter comment
191 | ERROR | [ ] Missing parameter name
223 | ERROR | [ ] The $_POST super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->request->get('mtcaptcha-verifiedtoken') instead
233 | ERROR | [ ] The $_POST super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->request->get('mtcaptcha-verifiedtoken') instead
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Time: 331ms; Memory: 12MB

📌 | Postmark | Drupal calls should be avoided in classes, use dependency injection instead.

🇮🇳India Ashutosh Ahirwal India

Provided patch in #2 applied cleanly but still there are some issue remains
Providing updated patch with all fixes.

📌 | Message | Issues reported by phpstan