🇮🇳India @ashutosh ahirwal

This issue is fixed and will reflect in upcoming version.

This issue is fixed and will reflect in upcoming version.

This fixes will reflect in upcoming version.

This fix changes will reflect in upcoming version.

Remove the Unwanted code from the MR, Only issue related code should be in MR.

Remove the Unwanted code from the MR, Only issue related code should be in MR.

Remove the Unwanted code from the MR, Only issue related code should be in MR.

Remove the Unwanted code from the MR, Only issue related code should be in MR.

Remove the Unwanted code from the MR, Only issue related code should be in MR.

Remove the Unwanted code from the MR, Only issue related code should be in MR.

This Fixes will reflect in upcoming version.

This fixes will reflect in upcoming version

This Fixes will reflect in upcoming version.

This fixes will reflect in new version.

This fixes will reflect in next version.

This will be fix in upcoming version

This Fixes will reflect in upcoming version

This will be fix in upcoming version.

This fix reflect in upcoming version.

This will be fix in upcoming version.

Moving to RTBC

I have installed this theme and checked this without any patches and its working.
Suggested to close this issue.

I have tried Patches to apply but its not getting apply and throwing error.

I have tried to apply #15 and its not getting apply and throwing error for it.

Patch provided in #5 resolve this issue moving to RTBC.

Patch provided in #2 is not getting apply.
Throwing error.

Ashutosh Ahirwal → created an issue.

Ashutosh Ahirwal → created an issue.

Hi @shweta__sharma Can you please add some css to make positioning according to the admin toolbar for loggin user and anonymous user?

Hi @alok_singh Can you please add some more context so other developers can review it proper.

Hi @sourojeetpaul Sorry for the late reply can you updated the color which is exist in the background color of login button found on tabs.

Ashutosh Ahirwal → created an issue.

I have tried MR2 but it was not fixing the issue.
Proving Updated MR

Ashutosh Ahirwal → made their first commit to this issue’s fork.

Hi SeaserWeb, Close this issue if this is fixed in latest version.
Thanks

Hi, Patch provided in #2 not getting apply throwing error
Moving to Need work

Hi Kritika_21
Thanks for working on this issue your provided patch is not getting apply kindly share updated patch and try to create patch from theme directory itself

Hi adarshv Thanks for again working on this issue.
Your changes are reflecting fine can you please shift it bit more and we not need scroll on page

Thanks

Ashutosh Ahirwal → created an issue.

Hi akhil_01
Can you please double check this issue its already a X logo for twitter

Hi adarshv Its working fine on my end can you please double check this on your side.

Hi Rajan Kumar@2026, adarshv Thanks for working on theme.
This is working as design because adding a container will cause issue for full width component on the page and will also have to override the twig for making the component full width.
To resolve this use container class on the component itself.

Thanks

I have reviewed the MR and tried to apply it but it get failed.
Moving to need work

I have reviewed the patch and the changes are reflecting but the previous layout look more correct for a search.
Moving to RTBC

I have reviewed MR9 and if we use then this will resolve this issue
I have created my own custom block from demo site.
moving to RTBC

I have reviewed the #5 MR10 and it turns to a hamburger on mobile and also working on click.
Moving to RTBC++

Ashutosh Ahirwal → created an issue.

Ashutosh Ahirwal → created an issue.

Ashutosh Ahirwal → created an issue.

Hi sourojeetpaul → Thanks for putting efforts to design and working on this issue.
Can you please make it according to the home page color code so this page will not look different from the theme.

jquery dependency removed
Moving to RTBC

Adding css like this will effect globally because added css in provided patch is a field specific and adding display none for label and page title is not a correct way.

+.page-title {
+  display: none; }
+
+.field--label-above .field__label {
+  display: none; }

Instant of adding display none to each field label, set the label hidden from manage display form for content type.

Ashutosh Ahirwal → created an issue.

Ashutosh Ahirwal → created an issue.

Moving to Need work to get some progress in this issue.

Ashutosh Ahirwal → created an issue.

Ashutosh Ahirwal → created an issue.

Ashutosh Ahirwal → created an issue.

Ashutosh Ahirwal → created an issue.

Ashutosh Ahirwal → created an issue.

Ashutosh Ahirwal → created an issue.

Ashutosh Ahirwal → created an issue.

I have update the x icon and also updated the bootstrap-icon for new icons.
Providing Updated MR.
Please review.

Ashutosh Ahirwal → made their first commit to this issue’s fork.

Hi, I have reviewed the #3 and also providing MR with fixes.
Please review it.

Ashutosh Ahirwal → made their first commit to this issue’s fork.

I have updated the MR4 with #9.
Please review need review.

Ashutosh Ahirwal → made their first commit to this issue’s fork.

Hi, I have reviewed provided patch and also checked the added SS in #6
drop-down menu taking too much white space in right side.
Moving this to Need work to get noticed.

I have reviewed the patch and its working fine and updating the layout.
Moving to RTBC.

Closing the issue its fixed in new tag.

Hi govind_giri_goswami →
Thanks for the issue.
Issue is fixed in new tag 10.0.1.
Thanks

Hi I have reviewed the patch and it fixes all the issue related to dependency injection but still there are so many issue found related to phpcs
Moving to RTBC.

Used command
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/rate

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/rate/js/w-thumbsup.js
----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
18 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/rate/js/w-yesno.js
-------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------
18 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
-------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/rate/js/w-fivestar.js
----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
24 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
----------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/rate/js/w-numberupdown.js
--------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
18 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
--------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/rate/js/unvote-helper.js
-------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------
23 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
-------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/rate/js/w-custom.js
--------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------
18 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
--------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/rate/js/w-emotion.js
---------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------
18 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
---------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/rate/js/w-thumbsupdown.js
--------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------
18 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
--------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/rate/rate.api.php
------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------
3 | ERROR | Missing short description in doc comment
------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/rate/src/Controller/WidgetResultsController.php
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
102 | WARNING | Unused variable $id.
------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/rate/src/RateWidgetForm.php
----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
292 | WARNING | Unused variable $plugin_id.
----------------------------------------------------------------------------------------------------

Time: 1.79 secs; Memory: 18MB

Hi, I have reviewed the patch #2 it resolved all the dependency injection issue but still there are so many issue found by phpcs issue.
Moving to RTBC.

Hi have reviewed the MR but its still showing so many errors.
moving to need work

Used command
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/commerceuserpoints

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/commerceuserpoints/commerce_user_points.info.yml
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
6 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
-------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/commerceuserpoints/commerce_user_points.module
-----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------
38 | WARNING | Unused variable $role_order_point_discount.
39 | WARNING | Unused variable $role_date_discount.
-----------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/commerceuserpoints/src/Form/ReferralPointsConfigurationForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
------------------------------------------------------------------------------------------------------------------------------------------
63 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
76 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
89 | WARNING | Role::loadMultiple calls should be avoided in classes, use dependency injection instead
107 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
119 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
143 | WARNING | Role::loadMultiple calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/commerceuserpoints/src/Form/ThresholdAmountConfigurationForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
------------------------------------------------------------------------------------------------------------------------------------------
63 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
71 | WARNING | Role::loadMultiple calls should be avoided in classes, use dependency injection instead
74 | WARNING | Unused variable $roles_field.
97 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
105 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
107 | WARNING | Unused variable $roleDetails.
127 | WARNING | Role::loadMultiple calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/commerceuserpoints/src/Form/UserPointsConfigurationForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 24 WARNINGS AFFECTING 24 LINES
------------------------------------------------------------------------------------------------------------------------------------------
82 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
83 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
92 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
93 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
94 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
95 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
96 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
97 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
98 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
103 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
105 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
123 | WARNING | Role::loadMultiple calls should be avoided in classes, use dependency injection instead
159 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
160 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
169 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
170 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
171 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
172 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
173 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
174 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
175 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
180 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
182 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
215 | WARNING | Role::loadMultiple calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/commerceuserpoints/src/Plugin/Commerce/CheckoutPane/CommerceUserPoints.php
---------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 10 WARNINGS AFFECTING 10 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------
115 | WARNING | Unused variable $roles.
116 | WARNING | Unused variable $role.
136 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
137 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
150 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
152 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
177 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
277 | WARNING | Unused variable $paymentInformation.
361 | WARNING | Unused variable $key.
416 | WARNING | Unused variable $nodeId.
---------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/commerceuserpoints/src/Plugin/Block/ReferralLinkBlock.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------
37 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
39 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/commerceuserpoints/src/Controller/ReferralLink.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
---------------------------------------------------------------------------------------------------------------------------
19 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
21 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
24 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
29 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
32 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
35 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/commerceuserpoints/src/EventSubscriber/OrderCompleteSubscriber.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
-------------------------------------------------------------------------------------------------------------------------------------------
63 | WARNING | Unused variable $userPoints.
70 | WARNING | Unused variable $userPoints.
78 | WARNING | Unused variable $orderTotal.
80 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
81 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
82 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/commerceuserpoints/src/ReferralLinkService.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
-----------------------------------------------------------------------------------------------------------------------
17 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
28 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
46 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
49 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------------------

Time: 467ms; Memory: 12MB

Hi, Patch provided in #2 is not getting apply throwing error
Moving to need work
Result after applying patch

globallink % git apply -v 3344157-2.patch
Checking patch config/schema/globallink.schema.yml...
error: while searching for:
label: Email notification levels
pd_user_agent:
type: select
label: GlobalLink User Agent Level
error: patch failed: config/schema/globallink.schema.yml:32
error: config/schema/globallink.schema.yml: patch does not apply
Checking patch globallink.install...
Checking patch globallink.module...
Checking patch src/EventSubscriber/GloballinkContinuousEvents.php...
Checking patch src/GlExchangeAdapter.php...
Checking patch src/GlobalLinkTranslatorUi.php...
error: while searching for:

$form['pd_url'] = [
'#type' => 'url',
'#title' => t('GlobalLink api url'),
'#required' => TRUE,
'#default_value' => $translator->getSetting('pd_url'),
'#description' => t('Add the api url provided by translations.com'),
];
$form['pd_username'] = [
'#type' => 'textfield',
'#title' => t('GlobalLink username'),
'#required' => TRUE,
'#default_value' => $translator->getSetting('pd_username'),
'#description' => t('Add the username provided by translations.com'),
];
$form['pd_password'] = [
'#type' => 'password',
'#title' => t('GlobalLink password'),
'#required' => TRUE,
'#default_value' => $translator->getSetting('pd_password'),
'#description' => t('Add the password provided by translations.com'),
];
$form['pd_projectid'] = [
'#type' => 'textfield',
'#title' => t('GlobalLink project id'),
'#required' => TRUE,
'#default_value' => $translator->getSetting('pd_projectid'),
'#description' => t('Add the project id provided by translations.com'),
];
$form['pd_submissionprefix'] = [
'#type' => 'textfield',
'#title' => t('GlobalLink submission prefix'),
'#required' => TRUE,
'#default_value' => $translator->getSetting('pd_submissionprefix'),
'#description' => t('Choose a prefix'),
];
$form['pd_classifier'] = [
'#type' => 'textfield',
'#title' => t('GlobalLink classifier'),
'#required' => TRUE,
'#default_value' => $translator->getSetting('pd_classifier'),
'#description' => t('Add a classifier'),
];
$form['pd_notify_emails'] = [
'#type' => 'textfield',
'#title' => t('Emails for notification'),
'#default_value' => $translator->getSetting('pd_notify_emails'),
'#description' => t('A space separated list of emails to notify. Leave blank for no notifications'),
];
$form['pd_combine'] = [
'#type' => 'checkbox',
'#title' => t('Combine all items into a single document'),
'#default_value' => $translator->getSetting('pd_combine'),
'#description' => t('If checked, a single document will be sent for a translation job, otherwise a separate document within a single submission will be created for each job item.'),
];
$form['pd_due_date_offset'] = [
'#type' => 'textfield',
'#title' => t('Default due date offset in working days'),
'#default_value' => $translator->getSetting('pd_due_date_offset') ?: 3,
'#description' => t('Controls the default due date, which then by default uses the configured amount of working days in the future.'),
];
$form['pd_notify_level'] = [
'#type' => 'checkboxes',
'#title' => t('Email notification levels'),
'#options' => [
GlobalLinkTranslator::MSG_STATUS => t('Status'),
GlobalLinkTranslator::MSG_DEBUG => t('Debug'),
GlobalLinkTranslator::MSG_WARNING => t('Warning'),
GlobalLinkTranslator::MSG_ERROR => t('Error'),
],
'#default_value' => (array) $translator->getSetting('pd_notify_level'),
'#description' => t('Select which tmgmt message types to send via email. Selecting all can result in a high volume of emails being sent.')
];
$form['pd_user_agent'] = [
'#type' => 'select',
'#title' => t('Select Environment Type'),
'#options' => [
'dev' => $this->t('Development Environment'),
'test' => $this->t('Test Environment'),
'stage' => $this->t('Staging Environment'),
'prod' => $this->t('Production Environment'),
],
'#default_value' => (array) $translator->getSetting('pd_user_agent'),
'#description' => t('Select which type of environment this is installed on. This will provide more information for Project Director.')
];

return $form;
}

error: patch failed: src/GlobalLinkTranslatorUi.php:44
error: src/GlobalLinkTranslatorUi.php: patch does not apply
Checking patch src/Plugin/tmgmt/Translator/GlobalLinkTranslator.php...
Hunk #8 succeeded at 572 (offset 5 lines).
Hunk #9 succeeded at 616 (offset 5 lines).
Hunk #10 succeeded at 686 (offset 5 lines).
error: while searching for:
$this->glExchangeAdapter->getGlExchange($pd_config);
}
catch (\Exception $e) {
return AvailableResult::no(t('@translator is not available. Make sure it is properly configured.', [
'@translator' => $translator->label(),
':configured' => $translator->url(),
]));

error: patch failed: src/Plugin/tmgmt/Translator/GlobalLinkTranslator.php:681
error: src/Plugin/tmgmt/Translator/GlobalLinkTranslator.php: patch does not apply

Hi, Provided patch in #2 is not getting apply and throwing error.
Moving to need work.

Hi Provided MR resolved issue but still there are some issue found.
Moving to need work to get notice.
Used command:-
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/querybuilder

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/querybuilder/querybuilder.info.yml
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
1 | WARNING | "core_version_requirement" property is missing in the info.yml file
-----------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/querybuilder/src/Form/OptimiseDatabaseForm.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
35 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

Time: 94ms; Memory: 10MB

Hi, MR3 resolve phpcs issue but still there are one issue.
Moving to need work to get notice
Used command:-
./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/fb_likebox

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/fb_likebox/tests/src/Functional/FBLikeboxBlockTest.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------
38 | WARNING | Line exceeds 80 characters; contains 82 characters
-------------------------------------------------------------------------------------------------------------------------------

Time: 186ms; Memory: 12MB

Hi, I reviewed the MR1 it resolve the issues but still there are so many issue found.
moving to need work to get noticed.

Used command:- ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/extended_html_filter

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/extended_html_filter/extended_html_filter.info.yml
---------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------
7 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
---------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/extended_html_filter/src/Form/ExtendedHTMLFilterSettingsForm.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
11 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/extended_html_filter/src/Plugin/Filter/ExtendedHTMLFilter.php
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\StringTranslation\StringTranslationTrait.
13 | WARNING | [ ] Line exceeds 80 characters; contains 92 characters
24 | WARNING | [ ] Line exceeds 80 characters; contains 193 characters
69 | ERROR | [ ] Public method name "ExtendedHTMLFilter::getHTMLRestrictions" is not in lowerCamel format
112 | WARNING | [ ] Unused bound variable $star_protector.
--------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/extended_html_filter/src/Utility/ExtendedHTMLFilterStandard.php
----------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------------------------------------------
7 | ERROR | Doc comment is empty
12 | ERROR | Doc comment is empty
----------------------------------------------------------------------------------------------------------------------------------------

Time: 165ms; Memory: 12MB

Hi I reviewed #3 patch it get applied cleanly and no error found.
Moving to RTBC

Hi I reviewed it but there are so many issue found related to phpcs issue updating the issue description.
Need work on it.

Hi Provided MR working fine but there are still some error found related to js
I have updated MR Needs Review.
Used command:- ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/field_group

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/field_group/js/field_group.field_ui.js
---------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
---------------------------------------------------------------------------------------------------------------
49 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
58 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
111 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
120 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/field_group/js/field_group.js
------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------
15 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/field_group/formatters/tabs/horizontal-tabs.js
-----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
72 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
-----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/field_group/formatters/tabs/tabs.js
------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------
24 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
40 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/field_group/formatters/accordion/accordion.js
----------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------------------------
22 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
32 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
35 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
45 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/field_group/formatters/html_element/html-element.js
----------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------------------------------
55 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
66 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
69 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------

Time: 1.8 secs; Memory: 18MB

Ashutosh Ahirwal → made their first commit to this issue’s fork.

Hi Patch provided in #2 get applied cleanly but still throwing error.
Providing updated patch.

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/m4032404

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/m4032404/tests/src/Unit/EventSubscriber/M4032404EventSubscriberTest.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\m4032404\EventSubscriber\M4032404EventSubscriber.
-------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/m4032404/src/EventSubscriber/M4032404EventSubscriber.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface.
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------

Time: 127ms; Memory: 10MB

Hi, I have applied patch but there are still so many errors found.
Moving to Need work

Used command:- ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/topplus_lite

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/css/components/dropdowns.css
------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
36 | ERROR | Style definitions must end with a semicolon
------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/css/components/inverted-header.css
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
42 | ERROR | Style definitions must end with a semicolon
------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/css/components/social-links.css
---------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------
41 | ERROR | Style definitions must end with a semicolon
---------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/css/components/forms.css
--------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
167 | ERROR | Style definitions must end with a semicolon
--------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/css/components/menu.css
-------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
819 | ERROR | Class definition is empty
-------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/css/components/owl-carousel-global.css
----------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
69 | ERROR | Style definitions must end with a semicolon
----------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/css/theme/local-theme.css
---------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] Additional whitespace found at start of file
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/popper/popper.min.js
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
-------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/waypoints/shortcuts/inview.min.js
--------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/waypoints/shortcuts/sticky.min.js
--------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/waypoints/jquery.waypoints.min.js
--------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
--------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/magnific-popup/magnific-popup.css
--------------------------------------------------------------------------------------------------------------------------
FOUND 162 ERRORS AFFECTING 135 LINES
--------------------------------------------------------------------------------------------------------------------------
11 | ERROR | [x] Closing brace of class definition must be on new line
21 | ERROR | [x] Closing brace of class definition must be on new line
31 | ERROR | [x] Closing brace of class definition must be on new line
37 | ERROR | [x] Closing brace of class definition must be on new line
40 | ERROR | [x] Closing brace of class definition must be on new line
48 | ERROR | [x] Closing brace of class definition must be on new line
53 | ERROR | [x] Closing brace of class definition must be on new line
56 | ERROR | [x] Closing brace of class definition must be on new line
58 | ERROR | [x] Multiple selectors should each be on a single line
61 | ERROR | [x] Closing brace of class definition must be on new line
67 | ERROR | [x] Closing brace of class definition must be on new line
70 | ERROR | [x] Closing brace of class definition must be on new line
78 | ERROR | [x] Closing brace of class definition must be on new line
81 | ERROR | [x] Closing brace of class definition must be on new line
84 | ERROR | [x] Closing brace of class definition must be on new line
87 | ERROR | [x] CSS colours must be defined in lowercase; expected #ccc but found #CCC
95 | ERROR | [x] Closing brace of class definition must be on new line
96 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
97 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
97 | ERROR | [x] CSS colours must be defined in lowercase; expected #ccc but found #CCC
97 | ERROR | [x] Closing brace of class definition must be on new line
98 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 4
99 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
99 | ERROR | [x] CSS colours must be defined in lowercase; expected #fff but found #FFF
99 | ERROR | [x] Closing brace of class definition must be on new line
102 | ERROR | [x] Closing brace of class definition must be on new line
105 | ERROR | [x] Closing brace of class definition must be on new line
119 | ERROR | [x] Closing brace of class definition must be on new line
123 | ERROR | [x] Closing brace of class definition must be on new line
136 | ERROR | [x] CSS colours must be defined in lowercase; expected #fff but found #FFF
139 | ERROR | [x] Closing brace of class definition must be on new line
140 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
141 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
142 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
142 | ERROR | [x] Closing brace of class definition must be on new line
143 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
144 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
144 | ERROR | [x] Closing brace of class definition must be on new line
147 | ERROR | [x] Closing brace of class definition must be on new line
151 | ERROR | [x] CSS colours must be defined in lowercase; expected #fff but found #FFF
155 | ERROR | [x] Closing brace of class definition must be on new line
161 | ERROR | [x] CSS colours must be defined in lowercase; expected #ccc but found #CCC
164 | ERROR | [x] Closing brace of class definition must be on new line
175 | ERROR | [x] Closing brace of class definition must be on new line
176 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
177 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
177 | ERROR | [x] Closing brace of class definition must be on new line
178 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
179 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
180 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
180 | ERROR | [x] Closing brace of class definition must be on new line
181 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
182 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
183 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
184 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
185 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
186 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
187 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
188 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
189 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
190 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
191 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
192 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
192 | ERROR | [x] Closing brace of class definition must be on new line
193 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
194 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
195 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
196 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
196 | ERROR | [x] Closing brace of class definition must be on new line
197 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
198 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
199 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
200 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
200 | ERROR | [x] Closing brace of class definition must be on new line
203 | ERROR | [x] Closing brace of class definition must be on new line
204 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
205 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
205 | ERROR | [x] CSS colours must be defined in lowercase; expected #fff but found #FFF
206 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
206 | ERROR | [x] Closing brace of class definition must be on new line
207 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
208 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
209 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
209 | ERROR | [x] CSS colours must be defined in lowercase; expected #3f3f3f but found #3F3F3F
209 | ERROR | [x] Closing brace of class definition must be on new line
212 | ERROR | [x] Closing brace of class definition must be on new line
213 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
214 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
214 | ERROR | [x] CSS colours must be defined in lowercase; expected #fff but found #FFF
215 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
215 | ERROR | [x] Closing brace of class definition must be on new line
216 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
217 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
217 | ERROR | [x] CSS colours must be defined in lowercase; expected #3f3f3f but found #3F3F3F
217 | ERROR | [x] Closing brace of class definition must be on new line
221 | ERROR | [x] Closing brace of class definition must be on new line
222 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
223 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
224 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
225 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
225 | ERROR | [x] Closing brace of class definition must be on new line
226 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
227 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
227 | ERROR | [x] Closing brace of class definition must be on new line
233 | ERROR | [x] Closing brace of class definition must be on new line
234 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
235 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
236 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
237 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
238 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
239 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
240 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
241 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
242 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
242 | ERROR | [x] Closing brace of class definition must be on new line
253 | ERROR | [x] Closing brace of class definition must be on new line
257 | ERROR | [x] Closing brace of class definition must be on new line
258 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
259 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
260 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
261 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
262 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
263 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
264 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
265 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
266 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
267 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
268 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
269 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
270 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
270 | ERROR | [x] Closing brace of class definition must be on new line
271 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
272 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
272 | ERROR | [x] CSS colours must be defined in lowercase; expected #bdbdbd but found #BDBDBD
273 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
274 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
275 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
275 | ERROR | [x] Closing brace of class definition must be on new line
276 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 2
277 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
277 | ERROR | [x] Closing brace of class definition must be on new line
285 | ERROR | [x] Closing brace of class definition must be on new line
290 | ERROR | [x] CSS colours must be defined in lowercase; expected #f3f3f3 but found #F3F3F3
292 | ERROR | [x] Closing brace of class definition must be on new line
295 | ERROR | [x] Closing brace of class definition must be on new line
298 | ERROR | [x] Closing brace of class definition must be on new line
302 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
303 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
306 | ERROR | [x] Closing brace of class definition must be on new line
308 | ERROR | [x] Closing brace of class definition must be on new line
311 | ERROR | [x] Closing brace of class definition must be on new line
314 | ERROR | [x] Closing brace of class definition must be on new line
322 | ERROR | [x] Closing brace of class definition must be on new line
323 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
324 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
324 | ERROR | [x] Closing brace of class definition must be on new line
327 | ERROR | [x] Closing brace of class definition must be on new line
337 | ERROR | [x] Closing brace of class definition must be on new line
342 | ERROR | [x] Closing brace of class definition must be on new line
345 | ERROR | [x] Closing brace of class definition must be on new line
348 | ERROR | [x] Closing brace of class definition must be on new line
351 | ERROR | [x] Closing brace of class definition must be on new line
--------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 162 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/magnific-popup/jquery.magnific-popup.min.js
------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/magnific-popup/jquery.magnific-popup.js
--------------------------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 10 LINES
--------------------------------------------------------------------------------------------------------------------------------
1106 | ERROR | String concat is not required here; use a single string instead
1107 | ERROR | String concat is not required here; use a single string instead
1108 | ERROR | String concat is not required here; use a single string instead
1109 | ERROR | String concat is not required here; use a single string instead
1110 | ERROR | String concat is not required here; use a single string instead
1113 | ERROR | String concat is not required here; use a single string instead
1114 | ERROR | String concat is not required here; use a single string instead
1115 | ERROR | String concat is not required here; use a single string instead
1116 | ERROR | String concat is not required here; use a single string instead
1544 | ERROR | String concat is not required here; use a single string instead
--------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/slideout/slideout.min.js
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
-----------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/mt-modernizr/mt-modernizr.js
---------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
---------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/flexslider/jquery.flexslider-min.js
----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
----------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/flexslider/changelog.txt
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------
13 | WARNING | Line exceeds 80 characters; contains 103 characters
33 | WARNING | Line exceeds 80 characters; contains 96 characters
36 | WARNING | Line exceeds 80 characters; contains 111 characters
-----------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/flexslider/jquery.flexslider.js
------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------
885 | ERROR | [ ] Blank lines are not allowed after DEFAULT statements
1115 | ERROR | [x] Inline control structures are not allowed
1136 | ERROR | [x] Inline control structures are not allowed
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/owl-carousel/README.md
---------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
---------------------------------------------------------------------------------------------------------------
37 | WARNING | Line exceeds 80 characters; contains 92 characters
41 | WARNING | Line exceeds 80 characters; contains 96 characters
44 | WARNING | Line exceeds 80 characters; contains 114 characters
61 | WARNING | Line exceeds 80 characters; contains 166 characters
74 | WARNING | Line exceeds 80 characters; contains 116 characters
95 | WARNING | Line exceeds 80 characters; contains 81 characters
98 | WARNING | Line exceeds 80 characters; contains 100 characters
---------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/js/owl-carousel/owl.carousel.min.js
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
1 | WARNING | File appears to be minified and cannot be processed
-------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/topplus_lite/theme-settings.php
--------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
--------------------------------------------------------------------------------------------------------
3 | ERROR | Missing short description in doc comment
7 | ERROR | Doc comment is empty
121 | WARNING | Avoid backslash escaping in translatable strings when possible, use "" quotes instead
--------------------------------------------------------------------------------------------------------

Time: 2.55 secs; Memory: 54MB

Hi I have found one remaining error after applying #2 patch.
Providing updated patch.

Hi, Provided patch in #2 get applied cleanly but still found some issue.
Moving to need work.

Used command:- ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/commerce_abandoned_carts

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/commerce_abandoned_carts/commerce_abandoned_carts.module
---------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
---------------------------------------------------------------------------------------------------------------------------------
79 | WARNING | Line exceeds 80 characters; contains 98 characters
80 | WARNING | Line exceeds 80 characters; contains 97 characters
91 | WARNING | Line exceeds 80 characters; contains 111 characters
182 | WARNING | Unused variable $nid.
---------------------------------------------------------------------------------------------------------------------------------

Time: 461ms; Memory: 12MB

Hi I have reviewed the MR and it resolve the issue but there are still some issue remains.
Moving this to Need Work for get it done.

Used command:-./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/group_content_menu

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/group_content_menu/group_content_menu.post_update.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------
49 | ERROR | The array declaration extends to column 121 (the limit is 120). The array content should be split up over multiple lines
76 | ERROR | The array declaration extends to column 122 (the limit is 120). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/group_content_menu/tests/src/Functional/GroupContentMenuTest.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
161 | WARNING | Line exceeds 80 characters; contains 82 characters
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/group_content_menu/src/Access/GroupOwnsMenuContentAccessChecker.php
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------
77 | WARNING | Line exceeds 80 characters; contains 83 characters
--------------------------------------------------------------------------------------------------------------------------------------------

Time: 881ms; Memory: 14MB

Hi I have reviewed the MR 1 and resolved all the issue.
Moving to RTBC.

Hi, I have fixes all the phpcs issue and updated the PR.
Needs review.

Ashutosh Ahirwal → made their first commit to this issue’s fork.

Hi I have update the MR with some remaining fixes of PHPcs issues.

There are one remaining issue need maintainer comment on it
Moving to Need work to get notice this issue for remaining task

Used command:- ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/time_spent

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/time_spent/time_spent.module
-----------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------
23 | WARNING | Unused variable $variables.
-----------------------------------------------------------------------------------------------------

Time: 299ms; Memory: 14MB

Ashutosh Ahirwal → made their first commit to this issue’s fork.

I reviewed the MR and its resolving the all phpcs issue.
Moving to RTBC