- Issue created by @Neha Wadhwani
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 7:07am 24 August 2023 - ๐ฎ๐ณIndia TanujJain-TJ
Tanuj. โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia ashutosh ahirwal India
Hi Patch provided in #2 get applied cleanly but still throwing error.
Providing updated patch../vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/m4032404
FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/m4032404/tests/src/Unit/EventSubscriber/M4032404EventSubscriberTest.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\m4032404\EventSubscriber\M4032404EventSubscriber.
-------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------------------FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/m4032404/src/EventSubscriber/M4032404EventSubscriber.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface.
-----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------------Time: 127ms; Memory: 10MB
- Status changed to RTBC
11 months ago 8:19am 24 May 2024 - ๐ต๐ญPhilippines cleavinjosh
Hi @Ashutosh Ahirwal,
I applied patch #4, it was applied cleanly and fixed the issues.
โ m4032404 git:(8.x-1.0-alpha6) curl https://www.drupal.org/files/issues/2024-03-05/coding_standard-3383044-4.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 3579 100 3579 0 0 5397 0 --:--:-- --:--:-- --:--:-- 5406 patching file src/EventSubscriber/M4032404EventSubscriber.php patching file src/Form/M4032404Form.php patching file tests/src/Functional/M4032404TestCaseTest.php patching file tests/src/Unit/EventSubscriber/M4032404EventSubscriberTest.php โ m4032404 git:(8.x-1.0-alpha6) โ .. โ contrib git:(main) โ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml m4032404 โ contrib git:(main) โ
I am moving this to Reviewed & tested by the community.
Thank you.
- Status changed to Closed: duplicate
5 months ago 7:52am 6 December 2024 - ๐ง๐ชBelgium JeroenT ๐ง๐ช
Closing this as a duplicate of ๐ Fix the issues reported by phpcs Active