🇧🇪
Account created on 2 August 2012, almost 13 years ago
  • Technical Lead at iO 
#

Merge Requests

More

Recent comments

🇧🇪Belgium JeroenT 🇧🇪

Rebased the MR on 11.x.

🇧🇪Belgium JeroenT 🇧🇪

jeroent changed the visibility of the branch 2842780-11.x to active.

🇧🇪Belgium JeroenT 🇧🇪

The maintainers have the contact form disabled on their user profile, so I was unable to contact them.

https://www.drupal.org/u/subhransu-sekhar

https://www.drupal.org/u/suyashvaidya

🇧🇪Belgium JeroenT 🇧🇪

jeroent made their first commit to this issue’s fork.

🇧🇪Belgium JeroenT 🇧🇪

Merged to 1.1.x. Thanks!

🇧🇪Belgium JeroenT 🇧🇪

jeroent made their first commit to this issue’s fork.

🇧🇪Belgium JeroenT 🇧🇪

Merged to 8.x-1.x. Thanks!

🇧🇪Belgium JeroenT 🇧🇪

jeroent made their first commit to this issue’s fork.

🇧🇪Belgium JeroenT 🇧🇪

Merged to 8.x-1.x. Thanks!
I'm still discussing with the original maintainer to give me the right permissions to update the default branch to the 8.x-1.x branch.

🇧🇪Belgium JeroenT 🇧🇪

jeroent made their first commit to this issue’s fork.

🇧🇪Belgium JeroenT 🇧🇪

jeroent made their first commit to this issue’s fork.

🇧🇪Belgium JeroenT 🇧🇪

I contacted @suzymasri, via the contact form on drupal.org. @skwashd didn't have the contact form enabled, so I was unable to contact him.

🇧🇪Belgium JeroenT 🇧🇪

jeroent made their first commit to this issue’s fork.

🇧🇪Belgium JeroenT 🇧🇪

The last release on the 7.x branch was a security release in 2022 and the last feature release in 2019.

So you can hardly say the 7.x branch is still supported.

🇧🇪Belgium JeroenT 🇧🇪

This problem occurs when using a Drupal version older than 10.3.

I noticed the constraints in composer where not correct, so I updated the info_version_requirement in the .info.yml.
However 1.1.1 is still installable on Drupal 10.2 and older. To fix this, downgrade to 1.1.0.

Merged to 1.1.x. Thanks!

🇧🇪Belgium JeroenT 🇧🇪

jeroent made their first commit to this issue’s fork.

🇧🇪Belgium JeroenT 🇧🇪

Merged 11.x-dev back into the Merge request !4236

🇧🇪Belgium JeroenT 🇧🇪

I've added a gitlab-ci.yml file.
There are still some phpstan errors, but those don't seem to be related to the Drupal 11 compatibility. So I guess those can be fixed in a follow-up issue.

🇧🇪Belgium JeroenT 🇧🇪

jeroent made their first commit to this issue’s fork.

🇧🇪Belgium JeroenT 🇧🇪

The tests were failing because the token hooks moved to a hook class.

Tests are now green again.

🇧🇪Belgium JeroenT 🇧🇪

I fixed the feedback in the MR.

🇧🇪Belgium JeroenT 🇧🇪

jeroent made their first commit to this issue’s fork.

🇧🇪Belgium JeroenT 🇧🇪

jeroent created an issue.

🇧🇪Belgium JeroenT 🇧🇪

Merged to 8.x-1.x. Thanks!

🇧🇪Belgium JeroenT 🇧🇪

jeroent made their first commit to this issue’s fork.

🇧🇪Belgium JeroenT 🇧🇪

jeroent created an issue.

🇧🇪Belgium JeroenT 🇧🇪

jeroent created an issue.

🇧🇪Belgium JeroenT 🇧🇪

jeroent created an issue.

🇧🇪Belgium JeroenT 🇧🇪

jeroent created an issue.

🇧🇪Belgium JeroenT 🇧🇪

jeroent created an issue.

🇧🇪Belgium JeroenT 🇧🇪

jeroent created an issue.

🇧🇪Belgium JeroenT 🇧🇪

The new release is working fine here, Thanks!

🇧🇪Belgium JeroenT 🇧🇪

jeroent made their first commit to this issue’s fork.

🇧🇪Belgium JeroenT 🇧🇪

I made a mistake in my previous comment. @dqd, you are the owner of the MR, can you edit the target branch to 5.0.x?

🇧🇪Belgium JeroenT 🇧🇪

#3484837-10: Create D11 compatible version seems unrelated to the Drupal 11 update and can be handled in a separate issue.

Also, I don't think it's necessary to drop Drupal 10 support, so I would also keep that version in the core_version_requirement property and in composer.json.

🇧🇪Belgium JeroenT 🇧🇪

jeroent created an issue.

🇧🇪Belgium JeroenT 🇧🇪

@heddn,
I can't find any feedback on the MR?

🇧🇪Belgium JeroenT 🇧🇪

Patch #61 doesn't contain all newly added files.

🇧🇪Belgium JeroenT 🇧🇪

2 weeks have passed and @markdorison, one of the co-maintainers, also agrees.

🇧🇪Belgium JeroenT 🇧🇪

Closing this as a duplicate of 📌 Fix the issues reported by phpcs Active

🇧🇪Belgium JeroenT 🇧🇪

The patch no longer works since 💬 Custom entity types Active was committed.

Production build 0.71.5 2024