🇧🇪Belgium @JeroenT

The new release is working fine here, Thanks!

jeroent → created an issue.

jeroent → created an issue.

jeroent → made their first commit to this issue’s fork.

I made a mistake in my previous comment. @dqd, you are the owner of the MR, can you edit the target branch to 5.0.x?

#3484837-10: Create D11 compatible version → seems unrelated to the Drupal 11 update and can be handled in a separate issue.

Also, I don't think it's necessary to drop Drupal 10 support, so I would also keep that version in the core_version_requirement property and in composer.json.

jeroent → created an issue.

@heddn,
I can't find any feedback on the MR?

Patch #61 doesn't contain all newly added files.

2 weeks have passed and @markdorison, one of the co-maintainers, also agrees.

jeroent → created an issue.

deekayen, shrop, ms2011 and bdone can add new maintainers:

https://www.drupal.org/project/r4032login/maintainers.json →

Closing this as a duplicate of 📌 Fix the issues reported by phpcs Active

Closing as a duplicate of #3483281: User logout without CSRF token redirect to 404 →

The patch no longer works since 💬 Custom entity types Active was committed.

mr.baileys → credited jeroent → .

jeroent → made their first commit to this issue’s fork.

I also closed ✨ Adds support for translatable fields Closed: duplicate as a duplicate since that is also fixed here. Because of the changes in .routing.yml file, the entity is loaded immediately in the right language, so translated file fields are already handled.

Closing this as a duplicate of 💬 Custom entity types Active since that is also fixed over there.

This is a nice improvement for this module.

I took the patch in #5, created a merge request of it and made a couple of changes.

I also closed 🐛 Check if node is valid Closed: duplicate as a duplicate since we no longer need to check if the entity is a valid entity because this now happens automatically because of this changes in the routing.yml file:

  options:
    parameters:
      entity:
        type: entity:{entity_type}

I'm closing this as a duplicate of 💬 Custom entity types Active .

Once that issue is fixed, this check is no longer necessary because of the changes in the routing.yml file.

jeroent → changed the visibility of the branch 3197043-custom-entity-types to hidden.

jeroent → changed the visibility of the branch 3197043-custom-entity-types to active.

All CS are fixed in 📌 Automated Drupal 11 compatibility fixes for download_all_files Needs review .

📌 Automated Drupal 11 compatibility fixes for download_all_files Needs review will drop support for Drupal 8 and 9 so I guess we can close this one.

jeroent → made their first commit to this issue’s fork.

jeroent → made their first commit to this issue’s fork.

Tests are green again.

jeroent → made their first commit to this issue’s fork.

jeroent → made their first commit to this issue’s fork.

I contacted Dennis Cohn via the contact form on drupal.org about this issue.

jeroent → created an issue.

Created a MR that fixes D11 compatibility:
https://git.drupalcode.org/project/one_time_login_link_admin/-/merge_req...

jeroent → made their first commit to this issue’s fork.

Tests are currently failing.

jeroent → made their first commit to this issue’s fork.

jeroent → made their first commit to this issue’s fork.

jeroent → made their first commit to this issue’s fork.

jeroent → created an issue.

Tests are passing again.

jeroent → created an issue.

Currently, it's not possible to translate the templates because the configuration is not translatable.

jeroent → created an issue.

I added some changes to MR1 that adds D11 compatibility and fixes all validations tasks in the Gitlab pipeline.

jeroent → made their first commit to this issue’s fork.

I wrote a MR, which adds D11 compatibility and fixes all validation tasks:
https://git.drupalcode.org/issue/ckeditor_templates_ui-3484837/-/pipelin...

jeroent → made their first commit to this issue’s fork.

I just created a new release (1.0.0-alpha3) which fixes a couple of bugs.
I wasn't able to reproduce this error. Does this problem still occur in that version for you?

I updated the project page.

jeroent → made their first commit to this issue’s fork.

Sorry for the late response...

I started working a bit on this module and first wanted to write some basic test covarage, which I did in #3488487: Add test coverage → .

I was able to reproduce this error and included this patch in that issue. Thanks for the work.

jeroent → created an issue.

Merged to 1.0.x. Thanks!

jeroent → made their first commit to this issue’s fork.

How is this a problem? The only reference to ProfileInterface is in a php comment, which is fully namespaced. So an import is not necessary?

jeroent → created an issue.

jeroent → created an issue.

jeroent → made their first commit to this issue’s fork.

I made the changes suggested by the maintainer to the MR.

@naveenvalecha, since you created the MR, can you edit the target branch to 5.0.x?

jeroent → made their first commit to this issue’s fork.

jeroent → created an issue.

I tried to reproduce this error.
I also wrote a test, but it seems that this is working:
https://git.drupalcode.org/project/field_fallback/-/jobs/3366749

Am I missing something?

jeroent → made their first commit to this issue’s fork.

Merged to 2.0.x.

jeroent → created an issue.

Merged to 2.0.x. Thanks!

jeroent → made their first commit to this issue’s fork.