Update overrider context every time

Hi Alex,

I came across this patch when applying this patch https://www.drupal.org/project/domain_simple_sitemap/issues/3380309 ✨ Support Domain Language Access Needs review and added it to my composer file. But after this patch was applied, my drush stopped functioning. I think there still is a need for a check, but maybe a different check.
I now used only the other patch, but that did not fix my problem. Sitemaps still contain all languages.
Do you have any idea how to solve this?

Thanks,
Jeroen

P.S. I needed to rewrite the other patch, because the location of the setActiveDomain changed. I will post it there.

Yes, it looks like negotiating the active domain this early in the request (during the loading of config overrides) is not supported. I started a MR with an approach where the active domain is loaded on demand. Having our own static cache is unnecessary since the active domain is also just a property on the DomainNegotiator service, so there isn't any performance gain.

@dieterholvoet thanks for the MR, it makes sense. However the MR repeats a lot of changes from DomainLanguageOverrider service arguments 🐛 DomainLanguageOverrider::__construct(): Argument #1 ($current_user) must be of type AccountProxyInterface Active (MR!17), so it is impossible to apply both patches. Here is a patch that can be applied to fix this issue after MR!17 is applied.

MR no longer applies.

I merged 2.0.x into the feature branch.

Merged to 2.0.x-dev. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.