Contrib.social

Update overrider context every time

Open on Drupal.org →
Created on 9 August 2023, over 1 year ago
Updated 4 July 2024, 5 months ago

Problem/Motivation

In some cases (e.g. when sitemap is being generated) active domain changes during the same request. As overrider relies on cached context, it uses wrong domain and gives wrong value for the languages list.

Steps to reproduce

Proposed resolution

We should update the content every time the overrides are rebuilt and not rely on the cached one.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Needs review

Version

2.0

Component

Code

Created by

🇨🇾Cyprus alex.bukach

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @alex.bukach
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 5.7
    last update over 1 year ago
    Waiting for branch to pass
  • Comment over 1 year ago →
    🇨🇾Cyprus alex.bukach
  • Comment 5 months ago →
    🇳🇱Netherlands jeroen dost

    Hi Alex,

    I came across this patch when applying this patch https://www.drupal.org/project/domain_simple_sitemap/issues/3380309 ✨ Support Domain Language Access Needs review and added it to my composer file. But after this patch was applied, my drush stopped functioning. I think there still is a need for a check, but maybe a different check.
    I now used only the other patch, but that did not fix my problem. Sitemaps still contain all languages.
    Do you have any idea how to solve this?

    Thanks,
    Jeroen

    P.S. I needed to rewrite the other patch, because the location of the setActiveDomain changed. I will post it there.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024