Account created on 15 May 2012, over 13 years ago
#

Merge Requests

More

Recent comments

🇨🇾Cyprus alex.bukach

@orkut murat yılmaz, the problem with the patch is that you might need to manually fix profile-related views as they might become broken after applying it. It would be great to make it automatically, however I don;t have time for that now.

🇨🇾Cyprus alex.bukach

The patch #54 indeed breaks profile views, however for the time being they can be fixed manually.

The actual issue we faced is that when a user account is translated and profile form is displayed on it, profile is not getting translated.

I created a pull request baed on #54 and made profiles widget match the root form language.

🇨🇾Cyprus alex.bukach

alex.bukach made their first commit to this issue’s fork.

🇨🇾Cyprus alex.bukach

alex.bukach changed the visibility of the branch 3300625-allow-mapping-of to hidden.

🇨🇾Cyprus alex.bukach

@mably I profiled a site and found that resetting and re-negotiating domain in when it was already set took a significant time. You are right, the fix committed for https://www.drupal.org/project/domain/issues/3226427 🐛 Arbitrary null value from DomainNegotiator::getActiveDomain() Needs review already made the same changes I suggested here.

🇨🇾Cyprus alex.bukach

Yes @jsacksick, the validation of a plugin configuration is now skipped if the plugin checkbox is unchecked as the respective configuration is not added to the form. Previously a condition was considered as "enabled" based on the default value even if a user disabled it before submitting a form.

🇨🇾Cyprus alex.bukach

alex.bukach changed the visibility of the branch 3510759-unable-to-save to hidden.

🇨🇾Cyprus alex.bukach

It seems to be a general Commerce issue related to how Commerce condition checkboxes are handled on AJAX.

🇨🇾Cyprus alex.bukach

alex.bukach changed the visibility of the branch 3532411-the-commercepricelistscheduledimport-entity to hidden.

🇨🇾Cyprus alex.bukach

alex.bukach changed the visibility of the branch 3527960-configuration-fix to active.

🇨🇾Cyprus alex.bukach

alex.bukach changed the visibility of the branch 3527960-configuration-fix to hidden.

🇨🇾Cyprus alex.bukach

alex.bukach changed the visibility of the branch 3527960-configuration-fix to hidden.

🇨🇾Cyprus alex.bukach

See https://www.drupal.org/project/drupal/issues/3523018 📌 Update CKEditor 5 to 45.0.0 Active .

🇨🇾Cyprus alex.bukach

Just tested it on a fresh Drupal 11.2.x install, and the issue still exists. Here are the steps to reproduce it:

  1. Add a "List (integer)" field to an entity type
  2. Add a filter for that list field to a view that displays that entity type
  3. See that available filter operators are only "Is one of", "Is all of", "Is none of", "Is empty (NULL)", "Is not empty (NOT NULL)", but numeric filters like "Is equal to", "Is greater than", "Is greater than or equal to" are missing. Those operators were available in Drupal 7.
🇨🇾Cyprus alex.bukach

Created MR!160 that re-rolls patch #11 against HEAD (still based on the idea of MR!142). Here's the respective patch.

🇨🇾Cyprus alex.bukach

@dieterholvoet thanks for the MR, it makes sense. However the MR repeats a lot of changes from DomainLanguageOverrider service arguments 🐛 DomainLanguageOverrider::__construct(): Argument #1 ($current_user) must be of type AccountProxyInterface Active (MR!17), so it is impossible to apply both patches. Here is a patch that can be applied to fix this issue after MR!17 is applied.

🇨🇾Cyprus alex.bukach

I created a MR based on #2, but for 3.0.x.

🇨🇾Cyprus alex.bukach

@joeren dost, why do we need the "getAlternateUrlsForTranslatedLanguages" method?

🇨🇾Cyprus alex.bukach

It looks like we still need to check the profile in the ProfileFormWidget.

🇨🇾Cyprus alex.bukach

I have another idea (see MR!36): instead of deleting profiles let's not create them. Here's a respective patch.

🇨🇾Cyprus alex.bukach

alex.bukach made their first commit to this issue’s fork.

🇨🇾Cyprus alex.bukach

We regularly face the same issue:

Drupal\Component\Plugin\Exception\PluginNotFoundException: The "views_view:view.block_content.page_1" plugin does not exist. Valid plugin IDs for Drupal\Core\Menu\LocalTaskManager are: [long list here including some other views_view:view.... tabs].

Trace:

#0 /var/www/html/docroot/core/lib/Drupal/Component/Plugin/Discovery/DiscoveryCachedTrait.php(25): Drupal\Core\Plugin\DefaultPluginManager->doGetDefinition()
#1 /var/www/html/docroot/core/lib/Drupal/Core/Plugin/Factory/ContainerFactory.php(16): Drupal\Core\Plugin\DefaultPluginManager->getDefinition()
#2 /var/www/html/docroot/core/lib/Drupal/Component/Plugin/PluginManagerBase.php(83): Drupal\Core\Plugin\Factory\ContainerFactory->createInstance()
#3 /var/www/html/docroot/core/lib/Drupal/Core/Menu/LocalTaskManager.php(263): Drupal\Component\Plugin\PluginManagerBase->createInstance()
#4 /var/www/html/docroot/core/lib/Drupal/Core/Menu/LocalTaskManager.php(290): Drupal\Core\Menu\LocalTaskManager->getLocalTasksForRoute()
#5 /var/www/html/docroot/core/lib/Drupal/Core/Menu/LocalTaskManager.php(358): Drupal\Core\Menu\LocalTaskManager->getTasksBuild()
#6 /var/www/html/docroot/core/lib/Drupal/Core/Menu/Plugin/Block/LocalTasksBlock.php(106): Drupal\Core\Menu\LocalTaskManager->getLocalTasks()
#7 /var/www/html/docroot/core/modules/block/src/BlockViewBuilder.php(171): Drupal\Core\Menu\Plugin\Block\LocalTasksBlock->build()
#8 [internal function]: Drupal\block\BlockViewBuilder::preRender()
#9 /var/www/html/docroot/core/lib/Drupal/Core/Security/DoTrustedCallbackTrait.php(113): call_user_func_array()
#10 /var/www/html/docroot/core/lib/Drupal/Core/Render/Renderer.php(870): Drupal\Core\Render\Renderer->doTrustedCallback()
#11 /var/www/html/docroot/core/lib/Drupal/Core/Render/Renderer.php(432): Drupal\Core\Render\Renderer->doCallback()
#12 /var/www/html/docroot/core/lib/Drupal/Core/Render/Renderer.php(504): Drupal\Core\Render\Renderer->doRender()
#13 /var/www/html/docroot/core/lib/Drupal/Core/Render/Renderer.php(248): Drupal\Core\Render\Renderer->doRender()
#14 /var/www/html/docroot/core/lib/Drupal/Core/Template/TwigExtension.php(484): Drupal\Core\Render\Renderer->render()
#15 /tmp/leica/php_storage/twig/9ad7f806e7f62a8da0cf8fec8fd26b2f35d0db3c-from-scratch/leica/twig/6813a2e26d1fb_page.html.twig_8jw0unMsy9xel9gtHdkD_AeP4/g9mcBqpu1iHBB2Q37FpNjMU7HSKhWRVMixa-JUl42ck.php(48): Drupal\Core\Template\TwigExtension->escapeFilter()
#16 /var/www/html/vendor/twig/twig/src/Template.php(388): __TwigTemplate_c951409ee69548febe0276286d7ee635->doDisplay()
#17 /var/www/html/vendor/twig/twig/src/Template.php(344): Twig\Template->yield()
#18 /var/www/html/vendor/twig/twig/src/Template.php(359): Twig\Template->display()
#19 /var/www/html/vendor/twig/twig/src/TemplateWrapper.php(51): Twig\Template->render()
#20 /var/www/html/docroot/core/themes/engines/twig/twig.engine(33): Twig\TemplateWrapper->render()
#21 /var/www/html/docroot/core/lib/Drupal/Core/Theme/ThemeManager.php(348): twig_render_template()
#22 /var/www/html/docroot/core/lib/Drupal/Core/Render/Renderer.php(491): Drupal\Core\Theme\ThemeManager->render()
#23 /var/www/html/docroot/core/lib/Drupal/Core/Render/Renderer.php(248): Drupal\Core\Render\Renderer->doRender()
#24 /var/www/html/docroot/core/lib/Drupal/Core/Template/TwigExtension.php(484): Drupal\Core\Render\Renderer->render()
#25 /tmp/leica/php_storage/twig/9ad7f806e7f62a8da0cf8fec8fd26b2f35d0db3c-from-scratch/leica/twig/6813a2e26d1fb_html.html.twig_0eGYNs7FAmpskRX3hZ2zlny3c/MWzgBwyQ9kDK5D3ntueXGk66pUVVmeOPgdP97Q1F-VI.php(91): Drupal\Core\Template\TwigExtension->escapeFilter()
#26 /var/www/html/vendor/twig/twig/src/Template.php(388): __TwigTemplate_ec2974d8efb50073b65812b7f5055bb9->doDisplay()
#27 /var/www/html/vendor/twig/twig/src/Template.php(344): Twig\Template->yield()
#28 /var/www/html/vendor/twig/twig/src/Template.php(359): Twig\Template->display()
#29 /var/www/html/vendor/twig/twig/src/TemplateWrapper.php(51): Twig\Template->render()
#30 /var/www/html/docroot/core/themes/engines/twig/twig.engine(33): Twig\TemplateWrapper->render()
#31 /var/www/html/docroot/core/lib/Drupal/Core/Theme/ThemeManager.php(348): twig_render_template()
#32 /var/www/html/docroot/core/lib/Drupal/Core/Render/Renderer.php(491): Drupal\Core\Theme\ThemeManager->render()
#33 /var/www/html/docroot/core/lib/Drupal/Core/Render/Renderer.php(248): Drupal\Core\Render\Renderer->doRender()
#34 /var/www/html/docroot/core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php(158): Drupal\Core\Render\Renderer->render()
#35 /var/www/html/docroot/core/lib/Drupal/Core/Render/Renderer.php(638): Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}()
#36 /var/www/html/docroot/core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php(159): Drupal\Core\Render\Renderer->executeInRenderContext()
#37 /var/www/html/docroot/core/lib/Drupal/Core/EventSubscriber/MainContentViewSubscriber.php(90): Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse()
#38 [internal function]: Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray()
#39 /var/www/html/docroot/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(111): call_user_func()
#40 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(186): Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch()
#41 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw()
#42 /var/www/html/docroot/modules/contrib/simple_oauth/src/HttpMiddleware/BasicAuthSwap.php(68): Symfony\Component\HttpKernel\HttpKernel->handle()
#43 /var/www/html/docroot/core/lib/Drupal/Core/StackMiddleware/Session.php(53): Drupal\simple_oauth\HttpMiddleware\BasicAuthSwap->handle()
#44 /var/www/html/docroot/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle()
#45 /var/www/html/docroot/core/lib/Drupal/Core/StackMiddleware/ContentLength.php(28): Drupal\Core\StackMiddleware\KernelPreHandle->handle()
#46 /var/www/html/docroot/core/modules/big_pipe/src/StackMiddleware/ContentLength.php(32): Drupal\Core\StackMiddleware\ContentLength->handle()
#47 /var/www/html/docroot/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\big_pipe\StackMiddleware\ContentLength->handle()
#48 /var/www/html/docroot/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass()
#49 /var/www/html/docroot/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\page_cache\StackMiddleware\PageCache->handle()
#50 /var/www/html/docroot/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle()
#51 /var/www/html/docroot/core/lib/Drupal/Core/StackMiddleware/AjaxPageState.php(36): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle()
#52 /var/www/html/docroot/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\Core\StackMiddleware\AjaxPageState->handle()
#53 /var/www/html/docroot/core/lib/Drupal/Core/DrupalKernel.php(741): Drupal\Core\StackMiddleware\StackedHttpKernel->handle()
#54 /var/www/html/docroot/index.php(19): Drupal\Core\DrupalKernel->handle()
#55 {main}
🇨🇾Cyprus alex.bukach

I suggest a simpler solution: when a user entity is saved, it refers to all the profiles, so we can update those not having correct uid. I created MR !35 which implements this approach. Here's the respective patch.

🇨🇾Cyprus alex.bukach

Neither $status nor $payment_gateway are used in the function sop it is safe to simply remove them.

🇨🇾Cyprus alex.bukach

It seems to be a common Commerce issue, see Cannot remove conditions if you remove required field values first 🐛 Cannot remove conditions if you remove required field values first Fixed .

🇨🇾Cyprus alex.bukach

Agree @vidorado, the proper fix is to find the formatter(s) that return NULL and fix them.

🇨🇾Cyprus alex.bukach

@berdir, do you still think your solution in #8 will not work?

Why should not we store the result of isMultilingual() like this?

🇨🇾Cyprus alex.bukach

I checked how it happened that the active domain is reset in those two places. Here are respective commits: 32920b2f and ac6552da, and it looks like we should simply check whether a domain is previously set before resetting it. Please see MR !130 for the suggested change.

🇨🇾Cyprus alex.bukach

Good point, thanks @smustgrave, I have also created a MR!137 against 7.0.x. The patch in #27 works for both 6.x and 7.x.

🇨🇾Cyprus alex.bukach

alex.bukach changed the visibility of the branch 3396769-resource-not-found-7 to active.

🇨🇾Cyprus alex.bukach

alex.bukach changed the visibility of the branch 3396769-resource-not-found-7 to hidden.

🇨🇾Cyprus alex.bukach

The patch #12 does not work on pages with invalid route parameters, e.g. /node/[nid] for a non-existent node ID. Here's an updated patch (the PR !86 is updated respectively).

🇨🇾Cyprus alex.bukach

Thanks @jim_b, I faced the same issue, and the workaround worked for me.

🇨🇾Cyprus alex.bukach

@ptmkenny no, it does not look like you addressed in 2.x so it remains relevant. I rebased your MR against the head of 2.x.

🇨🇾Cyprus alex.bukach

As the patch #8 is not applicable anymore, I created a MR !11 with the same fix.

Production build 0.71.5 2024