- Issue created by @jordan.caldwell
- 🇨🇾Cyprus alex.bukach
It seems to be a common Commerce issue, see Cannot remove conditions if you remove required field values first 🐛 Cannot remove conditions if you remove required field values first Fixed .
- Assigned to alex.bukach
- 🇨🇾Cyprus alex.bukach
It seems to be a general Commerce issue related to how Commerce condition checkboxes are handled on AJAX.
- 🇨🇾Cyprus alex.bukach
alex.bukach → changed the visibility of the branch 3510759-unable-to-save to hidden.
- Merge request !474Issue #3510759 by alex.bukach, jordan.caldwell, jsacksick: Unable to save shipping method when a product has been deleted → (Merged) created by alex.bukach
- 🇮🇱Israel jsacksick
@alex.bukach: Can you explain what we're changing exactly? The validation is now skipped if the condition is unchecked... or? Not fully clear by just looking at the code change.
- 🇨🇾Cyprus alex.bukach
Yes @jsacksick, the validation of a plugin configuration is now skipped if the plugin checkbox is unchecked as the respective configuration is not added to the form. Previously a condition was considered as "enabled" based on the default value even if a user disabled it before submitting a form.
- 🇮🇱Israel jsacksick
I tried merging from the issue to give credits to multiple people but that didn't work. Merged from the MR but that didn't edit the commit message... Anyway... Thanks for this!
Automatically closed - issue fixed for 2 weeks with no activity.