- Status changed to Needs review
6 months ago 11:26am 4 September 2024 - 🇨🇾Cyprus alex.bukach
I confirm the module does not work as expected, I can see that issue in both 7.x and 8.x versions. The JavaScript code expects the numbers be wrapped in 's, however they are not. Fixing it was a part of a @burt.lo's patch in #2. Here's a 8.x patch.
Also confirming the module doesn't work as expected. I tested alex's patch ( https://www.drupal.org/project/countdown/issues/1591730#comment-15756791 🐛 Countdown not counting down at all Needs review ) in a sandbox with Drupal 10.3 and branch 8.x-1.x-dev, but the only apparent change was the numbers are now displaying in italics per the tags. The timer is still not counting down dynamically, but only shows a change in countdown time when you refresh/visit the page.
- 🇨🇾Cyprus alex.bukach
@hannakras I suggest you to have a look at https://www.drupal.org/project/countdown/issues/796110 🐛 Day is cached Needs review and the MR there. I ended up reworking the whole module.
Thank you, @alex.bukach. I tested your MR, and it is counting down as expected now. I will comment over in that ticket as well.