- Issue created by @longwave
- 🇬🇧United Kingdom longwave UK
yarn build:ckeditor5
results in some warningsWARNING in ./modules/ckeditor5/js/ckeditor5_plugins/drupalMedia/src/drupalelementstyle/drupalelementstyleediting.js 240:16-21 export 'icons' (imported as 'icons') was not found in 'ckeditor5/src/core' (possible exports: Command, Context, ContextPlugin, DataApiMixin, Editor, ElementApiMixin, MultiCommand, PendingActions, Plugin, attachToForm, secureSourceElement) @ ./modules/ckeditor5/js/ckeditor5_plugins/drupalMedia/src/drupalelementstyle.js 5:0-87 40:12-37 @ ./modules/ckeditor5/js/ckeditor5_plugins/drupalMedia/src/index.js 8:0-54 24:2-20 WARNING in ./modules/ckeditor5/js/ckeditor5_plugins/drupalMedia/src/drupalelementstyle/drupalelementstyleediting.js 241:27-32 export 'icons' (imported as 'icons') was not found in 'ckeditor5/src/core' (possible exports: Command, Context, ContextPlugin, DataApiMixin, Editor, ElementApiMixin, MultiCommand, PendingActions, Plugin, attachToForm, secureSourceElement) @ ./modules/ckeditor5/js/ckeditor5_plugins/drupalMedia/src/drupalelementstyle.js 5:0-87 40:12-37 @ ./modules/ckeditor5/js/ckeditor5_plugins/drupalMedia/src/index.js 8:0-54 24:2-20 WARNING in ./modules/ckeditor5/js/ckeditor5_plugins/drupalMedia/src/drupalmediacaption/drupalmediacaptionui.js 37:14-27 export 'icons' (imported as 'icons') was not found in 'ckeditor5/src/core' (possible exports: Command, Context, ContextPlugin, DataApiMixin, Editor, ElementApiMixin, MultiCommand, PendingActions, Plugin, attachToForm, secureSourceElement) @ ./modules/ckeditor5/js/ckeditor5_plugins/drupalMedia/src/drupalmediacaption.js 5:0-77 17:39-59 @ ./modules/ckeditor5/js/ckeditor5_plugins/drupalMedia/src/index.js 9:0-54 23:2-20 WARNING in ./modules/ckeditor5/js/ckeditor5_plugins/drupalMedia/src/mediaimagetextalternative/mediaimagetextalternativeui.js 69:14-29 export 'icons' (imported as 'icons') was not found in 'ckeditor5/src/core' (possible exports: Command, Context, ContextPlugin, DataApiMixin, Editor, ElementApiMixin, MultiCommand, PendingActions, Plugin, attachToForm, secureSourceElement) @ ./modules/ckeditor5/js/ckeditor5_plugins/drupalMedia/src/index.js 12:0-98 21:2-29 WARNING in ./modules/ckeditor5/js/ckeditor5_plugins/drupalMedia/src/mediaimagetextalternative/ui/textalternativeformview.js 53:6-17 export 'icons' (imported as 'icons') was not found in 'ckeditor5/src/core' (possible exports: Command, Context, ContextPlugin, DataApiMixin, Editor, ElementApiMixin, MultiCommand, PendingActions, Plugin, attachToForm, secureSourceElement) @ ./modules/ckeditor5/js/ckeditor5_plugins/drupalMedia/src/mediaimagetextalternative/mediaimagetextalternativeui.js 18:0-67 102:21-44 @ ./modules/ckeditor5/js/ckeditor5_plugins/drupalMedia/src/index.js 12:0-98 21:2-29 WARNING in ./modules/ckeditor5/js/ckeditor5_plugins/drupalMedia/src/mediaimagetextalternative/ui/textalternativeformview.js 63:6-18 export 'icons' (imported as 'icons') was not found in 'ckeditor5/src/core' (possible exports: Command, Context, ContextPlugin, DataApiMixin, Editor, ElementApiMixin, MultiCommand, PendingActions, Plugin, attachToForm, secureSourceElement) @ ./modules/ckeditor5/js/ckeditor5_plugins/drupalMedia/src/mediaimagetextalternative/mediaimagetextalternativeui.js 18:0-67 102:21-44 @ ./modules/ckeditor5/js/ckeditor5_plugins/drupalMedia/src/index.js 12:0-98 21:2-29
- 🇵🇱Poland salmonek
Looks like a result of breaking change in CKEditor 5 v45.0.0:
All CKEditor 5 icons are now available in the
@ckeditor/ckeditor5-icons
package.https://ckeditor.com/docs/ckeditor5/latest/updating/guides/changelog.htm...
- First commit to issue fork.
- 🇳🇿New Zealand quietone
I didn't get an warning from yarn. But there are many test failures, 2 1/2 pages worht.
Looking at this now: the icons were moved to @ckeditor/ckeditor5-icons and RENAMED.
Finally got all tests passing.
There are some breaking changes:
- The icon name changes as mentioned in #12
table
tags now will all have thetable
class added to them: https://github.com/ckeditor/ckeditor5/pull/17889/files- Also more documented here: https://ckeditor.com/docs/ckeditor5/latest/updating/guides/changelog.htm...
There are also changes in the UI for linking images and media.
Before (inserting media with link):
After (inserting media with link):
- 🇬🇧United Kingdom catch
Adding the release notes tag - we'll want to document the UI changes, and maybe the API changes if we think they could affect contrib, in the 11.2.0 release notes.
we'll want to document the UI changes
There might be others, but these were the ones that surfaced from failed tests. :)